Files
wuffs/internal/cgen/base
Nigel Tao e2b9566fc5 base: restrict x86_avx2 to 64-bit (not 32-bit) x86
32-bit C/C++ compilers don't always compile the AVX intrinsics. Per the
60773 bug below,
> clang++ -m32 etc etc fuzz/c/std/jpeg_fuzzer.c
> undefined reference to `_mm_cvtsi128_si64'
> undefined reference to `_mm256_extract_epi64'

See also the "#ifdef __x86_64__" guards in
https://github.com/gcc-mirror/gcc/blob/4a3895903c29ed85da6fcb886f31ff23d4c6e935/gcc/config/i386/emmintrin.h#L228-L231
https://github.com/llvm/llvm-project/blob/08fab9ebecf72a682279d75489dc2460121cbeed/clang/lib/Headers/emmintrin.h#L3502-L3515

Note that -m32 is not the same as -mx32
> $ touch empty.c
> $ gcc       -dM -E empty.c | grep -E '__i386__|__x86_64__'
> #define __x86_64__ 1
> $ gcc -m32  -dM -E empty.c | grep -E '__i386__|__x86_64__'
> #define __i386__ 1
> $ gcc -mx32 -dM -E empty.c | grep -E '__i386__|__x86_64__'
> #define __x86_64__ 1

Updates https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=60773
2023-07-23 21:20:35 +10:00
..
2023-04-09 16:12:49 +10:00
2023-05-16 16:29:58 +10:00
2023-04-09 16:12:49 +10:00
2021-09-04 15:54:31 +10:00

C Base Code

This directory (base) and its sibling (auxiliary) contain C and C++ code respectively. This C/C++ code combines with the transpiled-to-C/C++ form of the Wuffs code in the top-level std directory to create the "single file C/C++ library" form of the Wuffs standard library.

  • From Wuffs-the-language's point of view, this directory contains implementations of the built-in base package types, such as I/O buffers, ranges and rects and statuses.
  • From application code's point of view (Wuffs is for writing libraries not applications), this directory also contains helper functions for working with those base types, such as constructing an I/O buffer from a pointer and a length, that aren't relevant to Wuffs-the-language code.
  • This directory also contains some functionality (e.g. pixel conversion and string conversion) that, in the future, could possibly be Wuffs packages under std. For optimal performance, they sometimes require programming language features (e.g. function-pointer typed variables, SIMD acceleration) that are not yet available in Wuffs-the-language (or were not available at the time they were added). In the short term, it was more practical to implement them in carefully hand-written C/C++, in this directory. In the long term, they could migrate out of base to be under std, but any base API removal would require a Wuffs version number bump.

Making Changes

After editing source code in this directory, to see those changes when generating the C/C++ form of Wuffs' standard library:

go install github.com/google/wuffs/cmd/wuffs-c && wuffs gen base

This should modify the wuffs-unsupported-snapshot.c file.