From d598c88fb3ff590c14ce7dd62d9bbb90e672213c Mon Sep 17 00:00:00 2001 From: Bimba Shrestha Date: Fri, 3 Apr 2020 13:31:47 -0700 Subject: [PATCH 1/2] adding fclose before return --- contrib/diagnose_corruption/check_flipped_bits.c | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/diagnose_corruption/check_flipped_bits.c b/contrib/diagnose_corruption/check_flipped_bits.c index 78473ea59..ed3db57de 100644 --- a/contrib/diagnose_corruption/check_flipped_bits.c +++ b/contrib/diagnose_corruption/check_flipped_bits.c @@ -105,6 +105,7 @@ static char* readFile(const char* filename, size_t* size) { bytes_read = fread(buf, 1, *size, f); if (bytes_read != *size) { fprintf(stderr, "failed to read whole file\n"); + fclose(f); free(buf); return NULL; } From 1d267dc5d661479e760b6e60bada16aa576ff944 Mon Sep 17 00:00:00 2001 From: Bimba Shrestha Date: Fri, 3 Apr 2020 13:39:02 -0700 Subject: [PATCH 2/2] returning on null check --- contrib/diagnose_corruption/check_flipped_bits.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/contrib/diagnose_corruption/check_flipped_bits.c b/contrib/diagnose_corruption/check_flipped_bits.c index ed3db57de..cc40ab84b 100644 --- a/contrib/diagnose_corruption/check_flipped_bits.c +++ b/contrib/diagnose_corruption/check_flipped_bits.c @@ -100,6 +100,8 @@ static char* readFile(const char* filename, size_t* size) { buf = malloc(*size); if (buf == NULL) { fprintf(stderr, "malloc failed\n"); + fclose(f); + return NULL; } bytes_read = fread(buf, 1, *size, f);