removed sprintf usage from zstdcli.c

some static analyzers flag this standard C90 function as unsafe.
This commit is contained in:
Yann Collet
2024-02-24 23:03:40 -08:00
parent 5c5c1b0d90
commit 4d2bf7f0f2
+6 -5
View File
@@ -318,7 +318,7 @@ static void usageAdvanced(const char* programName)
static void badUsage(const char* programName, const char* parameter) static void badUsage(const char* programName, const char* parameter)
{ {
DISPLAYLEVEL(1, "Incorrect parameter: %s\n", parameter); DISPLAYLEVEL(1, "Incorrect parameter: %s \n", parameter);
if (g_displayLevel >= 2) usage(stderr, programName); if (g_displayLevel >= 2) usage(stderr, programName);
} }
@@ -1148,7 +1148,6 @@ int main(int argCount, const char* argv[])
argument++; argument++;
while (argument[0]!=0) { while (argument[0]!=0) {
char shortArgument[3];
#ifndef ZSTD_NOCOMPRESS #ifndef ZSTD_NOCOMPRESS
/* compression Level */ /* compression Level */
@@ -1281,9 +1280,11 @@ int main(int argCount, const char* argv[])
/* unknown command */ /* unknown command */
default : default :
sprintf(shortArgument, "-%c", argument[0]); { char shortArgument[3] = {'-', 0, 0};
badUsage(programName, shortArgument); shortArgument[1] = argument[0];
CLEAN_RETURN(1); badUsage(programName, shortArgument);
CLEAN_RETURN(1);
}
} }
} }
continue; continue;