From 0c86d2346781c4ec21042087dfe86c78dcce51af Mon Sep 17 00:00:00 2001 From: Nick Terrell Date: Tue, 19 Feb 2019 15:49:48 -0800 Subject: [PATCH 1/2] [Windows] Move public headers to include/ --- lib/dll/example/build_package.bat | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/dll/example/build_package.bat b/lib/dll/example/build_package.bat index cae0a15cb..8baabc7b2 100644 --- a/lib/dll/example/build_package.bat +++ b/lib/dll/example/build_package.bat @@ -6,14 +6,15 @@ COPY programs\datagen.h bin\example\ COPY programs\util.h bin\example\ COPY programs\platform.h bin\example\ COPY lib\common\mem.h bin\example\ -COPY lib\common\zstd_errors.h bin\example\ COPY lib\common\zstd_internal.h bin\example\ COPY lib\common\error_private.h bin\example\ COPY lib\common\xxhash.h bin\example\ -COPY lib\zstd.h bin\include\ COPY lib\libzstd.a bin\static\libzstd_static.lib COPY lib\dll\libzstd.* bin\dll\ COPY lib\dll\example\Makefile bin\example\ COPY lib\dll\example\fullbench-dll.* bin\example\ COPY lib\dll\example\README.md bin\ +COPY lib\zstd.h bin\include\ +COPY lib\common\zstd_errors.h bin\include\ +COPY lib\dictBuilder\zdict.h bin\include\ COPY programs\zstd.exe bin\zstd.exe From 9f9630f4550c104a0b16fbddce2944f3005f9e92 Mon Sep 17 00:00:00 2001 From: Nick Terrell Date: Tue, 19 Feb 2019 16:14:02 -0800 Subject: [PATCH 2/2] [Windows] Don't use a .def file --- lib/Makefile | 3 +- lib/dll/libzstd.def | 87 --------------------------------------------- 2 files changed, 1 insertion(+), 89 deletions(-) delete mode 100644 lib/dll/libzstd.def diff --git a/lib/Makefile b/lib/Makefile index 6a912a657..f9955ba4f 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -151,8 +151,7 @@ ifneq (,$(filter Windows%,$(OS))) LIBZSTD = dll\libzstd.dll $(LIBZSTD): $(ZSTD_FILES) @echo compiling dynamic library $(LIBVER) - @$(CC) $(FLAGS) -DZSTD_DLL_EXPORT=1 -shared $^ -o $@ - dlltool -D $@ -d dll\libzstd.def -l dll\libzstd.lib + $(CC) $(FLAGS) -DZSTD_DLL_EXPORT=1 -Wl,--out-implib,dll\libzstd.lib -shared $^ -o $@ else diff --git a/lib/dll/libzstd.def b/lib/dll/libzstd.def deleted file mode 100644 index 668c4b1c2..000000000 --- a/lib/dll/libzstd.def +++ /dev/null @@ -1,87 +0,0 @@ -LIBRARY libzstd.dll -EXPORTS - ZDICT_getDictID - ZDICT_getErrorName - ZDICT_isError - ZDICT_trainFromBuffer - ZSTD_CStreamInSize - ZSTD_CStreamOutSize - ZSTD_DStreamInSize - ZSTD_DStreamOutSize - ZSTD_adjustCParams - ZSTD_checkCParams - ZSTD_compress - ZSTD_compressBegin - ZSTD_compressBegin_advanced - ZSTD_compressBegin_usingDict - ZSTD_compressBlock - ZSTD_compressBound - ZSTD_compressCCtx - ZSTD_compressContinue - ZSTD_compressEnd - ZSTD_compressStream - ZSTD_compress_advanced - ZSTD_compress_usingCDict - ZSTD_compress_usingDict - ZSTD_copyCCtx - ZSTD_copyDCtx - ZSTD_createCCtx - ZSTD_createCCtx_advanced - ZSTD_createCDict - ZSTD_createCDict_advanced - ZSTD_createCStream - ZSTD_createCStream_advanced - ZSTD_createDCtx - ZSTD_createDCtx_advanced - ZSTD_createDDict - ZSTD_createDStream - ZSTD_createDStream_advanced - ZSTD_decompress - ZSTD_decompressBegin - ZSTD_decompressBegin_usingDict - ZSTD_decompressBlock - ZSTD_decompressContinue - ZSTD_decompressDCtx - ZSTD_decompressStream - ZSTD_decompress_usingDDict - ZSTD_decompress_usingDict - ZSTD_endStream - ZSTD_estimateCCtxSize - ZSTD_estimateDCtxSize - ZSTD_flushStream - ZSTD_freeCCtx - ZSTD_freeCDict - ZSTD_freeCStream - ZSTD_freeDCtx - ZSTD_freeDDict - ZSTD_freeDStream - ZSTD_getBlockSizeMax - ZSTD_getCParams - ZSTD_getDecompressedSize - ZSTD_findDecompressedSize - ZSTD_getFrameContentSize - ZSTD_getErrorName - ZSTD_getFrameParams - ZSTD_getParams - ZSTD_initCStream - ZSTD_initCStream_advanced - ZSTD_initCStream_usingCDict - ZSTD_initCStream_usingDict - ZSTD_initDStream - ZSTD_initDStream_usingDDict - ZSTD_initDStream_usingDict - ZSTD_insertBlock - ZSTD_isError - ZSTD_isFrame - ZSTD_maxCLevel - ZSTD_nextInputType - ZSTD_nextSrcSizeToDecompress - ZSTD_resetCStream - ZSTD_resetDStream - ZSTD_sizeof_CCtx - ZSTD_sizeof_CDict - ZSTD_sizeof_CStream - ZSTD_sizeof_DCtx - ZSTD_sizeof_DDict - ZSTD_sizeof_DStream - ZSTD_versionNumber