Typo and grammar fixes
This commit is contained in:
+3
-3
@@ -45,7 +45,7 @@ optional arguments:
|
||||
-h, --help show this help message and exit
|
||||
--directory DIRECTORY
|
||||
directory with files to benchmark
|
||||
--levels LEVELS levels to test eg ('1,2,3')
|
||||
--levels LEVELS levels to test e.g. ('1,2,3')
|
||||
--iterations ITERATIONS
|
||||
number of benchmark iterations to run
|
||||
--emails EMAILS email addresses of people who will be alerted upon
|
||||
@@ -70,7 +70,7 @@ After `sleepTime` (an optional parameter, default 300 seconds) seconds the scrip
|
||||
If a new commit is found it is compiled and a speed benchmark for this commit is performed.
|
||||
The results of the speed benchmark are compared to the previous results.
|
||||
If compression or decompression speed for one of zstd levels is lower than `lowerLimit` (an optional parameter, default 0.98) the speed benchmark is restarted.
|
||||
If second results are also lower than `lowerLimit` the warning e-mail is send to recipients from the list (the `emails` parameter).
|
||||
If second results are also lower than `lowerLimit` the warning e-mail is sent to recipients from the list (the `emails` parameter).
|
||||
|
||||
Additional remarks:
|
||||
- To be sure that speed results are accurate the script should be run on a "stable" target system with no other jobs running in parallel
|
||||
@@ -168,7 +168,7 @@ Full list of arguments
|
||||
can use all --zstd parameter names and 'cParams' as a shorthand for all parameters used in ZSTD_compressionParameters
|
||||
(Default: display all params available)
|
||||
-P# : generated sample compressibility (when no file is provided)
|
||||
-t# : Caps runtime of operation in seconds (default : 99999 seconds (about 27 hours ))
|
||||
-t# : Caps runtime of operation in seconds (default: 99999 seconds (about 27 hours))
|
||||
-v : Prints Benchmarking output
|
||||
-D : Next argument dictionary file
|
||||
-s : Benchmark all files separately
|
||||
|
||||
@@ -291,7 +291,7 @@ if __name__ == "__main__":
|
||||
parser = argparse.ArgumentParser()
|
||||
|
||||
parser.add_argument("--directory", help="directory with files to benchmark", default="golden-compression")
|
||||
parser.add_argument("--levels", help="levels to test eg ('1,2,3')", default="1")
|
||||
parser.add_argument("--levels", help="levels to test e.g. ('1,2,3')", default="1")
|
||||
parser.add_argument("--iterations", help="number of benchmark iterations to run", default="1")
|
||||
parser.add_argument("--emails", help="email addresses of people who will be alerted upon regression. Only for continuous mode", default=None)
|
||||
parser.add_argument("--frequency", help="specifies the number of seconds to wait before each successive check for new PRs in continuous mode", default=DEFAULT_MAX_API_CALL_FREQUENCY_SEC)
|
||||
|
||||
+1
-1
@@ -636,7 +636,7 @@ def regression(args):
|
||||
try:
|
||||
description = """
|
||||
Runs one or more regression tests.
|
||||
The fuzzer should have been built with with
|
||||
The fuzzer should have been built with
|
||||
LIB_FUZZING_ENGINE='libregression.a'.
|
||||
Takes input from CORPORA.
|
||||
"""
|
||||
|
||||
@@ -294,7 +294,7 @@ int LLVMFuzzerTestOneInput(const uint8_t* src, size_t size)
|
||||
FUZZ_ASSERT(dictBuffer);
|
||||
dictBuffer = generatePseudoRandomString(dictBuffer, dictSize);
|
||||
}
|
||||
/* Generate window log first so we dont generate offsets too large */
|
||||
/* Generate window log first so we don't generate offsets too large */
|
||||
wLog = FUZZ_dataProducer_uint32Range(producer, ZSTD_WINDOWLOG_MIN, ZSTD_WINDOWLOG_MAX_32);
|
||||
cLevel = FUZZ_dataProducer_int32Range(producer, -3, 22);
|
||||
mode = (ZSTD_sequenceFormat_e)FUZZ_dataProducer_int32Range(producer, 0, 1);
|
||||
|
||||
@@ -9,7 +9,7 @@
|
||||
*/
|
||||
|
||||
/**
|
||||
* This fuzz target attempts to comprss the fuzzed data with the simple
|
||||
* This fuzz target attempts to compress the fuzzed data with the simple
|
||||
* compression function with an output buffer that may be too small to
|
||||
* ensure that the compressor never crashes.
|
||||
*/
|
||||
|
||||
+7
-7
@@ -1063,7 +1063,7 @@ static int basicUnitTests(U32 const seed, double compressibility)
|
||||
void* recon = (void*)malloc(size);
|
||||
|
||||
size_t refPrefixCompressedSize = 0;
|
||||
size_t refPrefixLdmComrpessedSize = 0;
|
||||
size_t refPrefixLdmCompressedSize = 0;
|
||||
size_t reconSize = 0;
|
||||
|
||||
ZSTD_CCtx* const cctx = ZSTD_createCCtx();
|
||||
@@ -1093,20 +1093,20 @@ static int basicUnitTests(U32 const seed, double compressibility)
|
||||
/* compress on level 1 using refPrefix and ldm */
|
||||
ZSTD_CCtx_refPrefix(cctx, dict, size);;
|
||||
CHECK_Z(ZSTD_CCtx_setParameter(cctx, ZSTD_c_enableLongDistanceMatching, 1))
|
||||
refPrefixLdmComrpessedSize = ZSTD_compress2(cctx, dst, dstSize, src, size);
|
||||
assert(!ZSTD_isError(refPrefixLdmComrpessedSize));
|
||||
refPrefixLdmCompressedSize = ZSTD_compress2(cctx, dst, dstSize, src, size);
|
||||
assert(!ZSTD_isError(refPrefixLdmCompressedSize));
|
||||
|
||||
/* test round trip refPrefix + ldm*/
|
||||
ZSTD_DCtx_refPrefix(dctx, dict, size);
|
||||
reconSize = ZSTD_decompressDCtx(dctx, recon, size, dst, refPrefixLdmComrpessedSize);
|
||||
reconSize = ZSTD_decompressDCtx(dctx, recon, size, dst, refPrefixLdmCompressedSize);
|
||||
assert(!ZSTD_isError(reconSize));
|
||||
assert(reconSize == size);
|
||||
assert(!memcmp(recon, src, size));
|
||||
|
||||
/* make sure that refPrefixCompressedSize is significantly greater */
|
||||
assert(refPrefixCompressedSize > 10 * refPrefixLdmComrpessedSize);
|
||||
/* make sure the ldm comrpessed size is less than 1% of original */
|
||||
assert((double)refPrefixLdmComrpessedSize / (double)size < 0.01);
|
||||
assert(refPrefixCompressedSize > 10 * refPrefixLdmCompressedSize);
|
||||
/* make sure the ldm compressed size is less than 1% of original */
|
||||
assert((double)refPrefixLdmCompressedSize / (double)size < 0.01);
|
||||
|
||||
ZSTD_freeDCtx(dctx);
|
||||
ZSTD_freeCCtx(cctx);
|
||||
|
||||
+1
-1
@@ -555,7 +555,7 @@ static int feasible(const BMK_benchResult_t results, const constraint_t target)
|
||||
}
|
||||
|
||||
/* hill climbing value for part 1 */
|
||||
/* Scoring here is a linear reward for all set constraints normalized between 0 to 1
|
||||
/* Scoring here is a linear reward for all set constraints normalized between 0 and 1
|
||||
* (with 0 at 0 and 1 being fully fulfilling the constraint), summed with a logarithmic
|
||||
* bonus to exceeding the constraint value. We also give linear ratio for compression ratio.
|
||||
* The constant factors are experimental.
|
||||
|
||||
Reference in New Issue
Block a user