ddidderr/zstd-rs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #4487 from neiljohari/adhoc/dictionary-file-counting

Browse Source 
make DiB_fileStats skip invalid files (fileSize <= 0) to prevent negative totals and bogus allocation
This commit is contained in:
Yann Collet
2025-09-19 21:42:06 -08:00
committed by GitHub
parent d190b38863 236e44f00f
commit e6e5a95c15
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
programs/dibio.c
+9 -2
View File
@@ -280,8 +280,15 @@ static fileStats DiB_fileStats(const char** fileNamesTable, int nbFiles, size_t
for (n=0; n<nbFiles; n++) { for (n=0; n<nbFiles; n++) {
S64 const fileSize = DiB_getFileSize(fileNamesTable[n]); S64 const fileSize = DiB_getFileSize(fileNamesTable[n]);
/* TODO: is there a minimum sample size? What if the file is 1-byte? */ /* TODO: is there a minimum sample size? What if the file is 1-byte? */
if (fileSize == 0) { /* Skip empty or invalid files */
DISPLAYLEVEL(3, "Sample file '%s' has zero size, skipping...\n", fileNamesTable[n]); if (fileSize <= 0) {
if (fileSize < 0) {
DISPLAYLEVEL(3, "Sample file '%s' is unreadable or stat failed, skipping...\n",
fileNamesTable[n]);
} else {
DISPLAYLEVEL(3, "Sample file '%s' has zero size, skipping...\n",
fileNamesTable[n]);
}
continue; continue;
} }