ddidderr/zstd-rs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #3166 from facebook/warning_clockt

Browse Source 
display a warning message when using C90 clock_t
This commit is contained in:
Yann Collet
2022-06-19 14:45:49 -07:00
committed by GitHub
parent b33ef91694 574ecbb0fc
commit f15dd6420c
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
programs/benchzstd.c
+8 -1
View File
@@ -13,7 +13,7 @@
* Tuning parameters * Tuning parameters
****************************************/ ****************************************/
#ifndef BMK_TIMETEST_DEFAULT_S /* default minimum time per test */ #ifndef BMK_TIMETEST_DEFAULT_S /* default minimum time per test */
#define BMK_TIMETEST_DEFAULT_S 3 # define BMK_TIMETEST_DEFAULT_S 3
#endif #endif
@@ -387,6 +387,13 @@ BMK_benchMemAdvancedNoAlloc(
RDG_genBuffer(compressedBuffer, maxCompressedSize, 0.10, 0.50, 1); RDG_genBuffer(compressedBuffer, maxCompressedSize, 0.10, 0.50, 1);
} }
#if defined(UTIL_TIME_USES_C90_CLOCK)
if (adv->nbWorkers > 1) {
OUTPUTLEVEL(2, "Warning : time measurements restricted to C90 clock_t. \n")
OUTPUTLEVEL(2, "Warning : using C90 clock_t leads to incorrect measurements in multithreading mode. \n")
}
#endif
/* Bench */ /* Bench */
{ U64 const crcOrig = (adv->mode == BMK_decodeOnly) ? 0 : XXH64(srcBuffer, srcSize, 0); { U64 const crcOrig = (adv->mode == BMK_decodeOnly) ? 0 : XXH64(srcBuffer, srcSize, 0);
# define NB_MARKS 4 # define NB_MARKS 4
programs/timefn.h
+1
View File
@@ -65,6 +65,7 @@ extern "C" {
#else /* relies on standard C90 (note : clock_t measurements can be wrong when using multi-threading) */ #else /* relies on standard C90 (note : clock_t measurements can be wrong when using multi-threading) */
#define UTIL_TIME_USES_C90_CLOCK
typedef clock_t UTIL_time_t; typedef clock_t UTIL_time_t;
#define UTIL_TIME_INITIALIZER 0 #define UTIL_TIME_INITIALIZER 0