ddidderr/zstd-rs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
9,713 Commits 17 Branches 77 Tags
1c04514b31a44dcf44724ffbb1dc658aee39cd0b
Commit Graph
9713 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Nick TerrellandGitHub 2f03c1996f Merge pull request #3013 from WojciechMula/simplify-asm 
Simplify HUF_decompress4X2_usingDTable_internal_bmi2_asm_loop
 2022-01-21 11:13:40 -08:00
Felix HandteandGitHub 4a35912b3b Merge pull request #3018 from felixhandte/gh-action-release-artifacts-trigger-fix 
Trigger Release Artifact Generation on Publish
 2022-01-20 21:08:59 -05:00
Yann ColletandGitHub 71921e596f Merge pull request #2983 from facebook/minLitPricev2 
[opt] minor compression ratio improvement
 2022-01-20 16:02:31 -08:00
W. Felix Handte fa9cb4510a Trigger Release Artifact Generation on Publish 
We previously triggered release artifact generation on release creation. We
sometimes observed that the action failed to run. I hypothesized that we were
hitting rate limiting or something. I just stumbled across [this documentat-
ion](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release), which says:

> Note: Workflows are not triggered for the `created`, `edited`, or `deleted`
> activity types for draft releases. When you create your release through the
> GitHub browser UI, your release may automatically be saved as a draft.

This must have been what was happening. This commit therefore changes the
trigger to the `published` activity. This should be more reliable.

This does have the unfortunate side effect that artifacts won't be generated
or attached until *after* the release has been published, which is what I was
trying to avoid by using the `created` activity. Oh well.
 2022-01-20 17:36:28 -05:00
Felix HandteandGitHub 330c97d2bf Merge pull request #3015 from felixhandte/enable-cet-test-illegal-instruction 
Add GitHub Action Checking that Zstd Runs Successfully Under CET
 2022-01-20 16:18:42 -05:00
Elliot GorokhovskyandGitHub a8f1aa2f6d Merge pull request #3016 from embg/macro_lint 
Minor lint fix
 2022-01-20 13:05:02 -07:00
Felix HandteandGitHub c7e8315d88 Merge pull request #2994 from hjl-tools/hjl/cet-report/dev 
x86: Append -z cet-report=error to LDFLAGS
 2022-01-20 14:58:13 -05:00
Elliot Gorokhovsky f936dd89cb Minor lint fix 2022-01-20 11:54:43 -07:00
H.J. Lu d6fcdd123c x86: Append -z cet-report=error to LDFLAGS 
Append -z cet-report=error to LDFLAGS if -fcf-protection is enabled by
default in compiler to catch the missing Intel CET marker:

compiling multi-threaded dynamic library 1.5.1
/usr/local/bin/ld: obj/conf_f408b4c825de923ffc88f7f21b6884b1/dynamic/huf_decompress_amd64.o: error: missing IBT and SHSTK properties
collect2: error: ld returned 1 exit status
...
LINK obj/conf_dbc0b41e36c44111bb0bb918e093d7c1/zstd
/usr/local/bin/ld: obj/conf_dbc0b41e36c44111bb0bb918e093d7c1/huf_decompress_amd64.o: error: missing IBT and SHSTK properties
collect2: error: ld returned 1 exit status
 2022-01-20 08:32:01 -08:00
W. Felix Handte 7cf80cb94c Add GitHub Action Checking that Zstd Runs Successfully Under CET 2022-01-20 11:25:52 -05:00
Felix HandteandGitHub 4dfc4eca9a Merge pull request #2992 from hjl-tools/hjl/cet/dev 
x86-64: Enable Intel CET
 2022-01-20 11:24:47 -05:00
Carl Woffenden 3f181b6192 More descriptive exclusion error; updated docs and copyright 2022-01-20 14:50:31 +01:00
Wojciech Muła e74ca7979e Simplify HUF_decompress4X2_usingDTable_internal_bmi2_asm_loop 
Get rid of three divisions. The original expression was:

    opmin := min((oend0 - op0) / 10, (oend1 - op1) / 10, (oend2 - op2) / 10, (oend3 - op3) / 10)
    r15   := min(r15, opmin)

The division by 10 can be moved outside the `min`:

    opmin := min(oend0 - op0, oend1 - op1, oend2 - op2, oend3 - op3)
    r15   := min(r15, opmin/10)
 2022-01-19 18:38:46 +01:00
Carl Woffenden dc983e7d68 Typo (and missing commit) 2022-01-19 18:05:35 +01:00
Elliot GorokhovskyandGitHub 40bc9ee6c4 Merge pull request #2999 from embg/ci_instructions_update 
Update CI documentation
 2022-01-19 10:03:07 -07:00
Elliot Gorokhovsky 8250faa01b Update CI documentation 2022-01-19 09:58:31 -07:00
Carl Woffenden 786263ea85 Suggestion from code review 2022-01-19 17:48:10 +01:00
Carl WoffendenGitHubAlexandre Bury
 		566ebce347 Python style change 
Co-authored-by: Alexandre Bury <alexandre.bury@gmail.com>
 2022-01-19 17:33:20 +01:00
Carl Woffenden 5fd6ddaf8b Fixed bugs found in other projects 
When testing amalgamating other projects it was found: invalid Unicode errors were tripping Python's text IO, and the header search order appears differs from the shell version.
 2022-01-19 16:56:03 +01:00
Carl Woffenden dd7d29a19c Updated README 2022-01-19 15:57:33 +01:00
Carl Woffenden 7d90f0b520 Test and tidy 
Made the Python more Python-like. Added notes and general tidy. Tested exclusions and building with various options. Tested all scripts.
 2022-01-19 11:32:53 +01:00
Nick TerrellandGitHub ef1eafded3 Merge pull request #3009 from terrelln/asm-flags 
[build][asm] Pass ASFLAGS to the assembler instead of CFLAGS
 2022-01-18 15:48:11 -08:00
Nick TerrellandGitHub 3369a106eb Merge pull request #2998 from floppym/issue2997 
Avoid updating timestamps when the destination is stdout
 2022-01-18 15:14:06 -08:00
Nick Terrell 8ea3d57de4 [build][asm] Pass ASFLAGS to the assembler instead of CFLAGS 
* Add `-Wa,--noexecstack` to both `ASFLAGS` and `CFLAGS`
* Pass `ASFLAGS` to `.S` compilation instead of `CFLAGS`

Fixes #3006.
 2022-01-18 15:11:29 -08:00
Carl Woffenden 8f1e51f99f Feature parity with original shell script; needs further testing 2022-01-18 19:07:18 +01:00
Elliot GorokhovskyandGitHub fe8fefb28d Merge pull request #3000 from embg/mt_memory_readability 
Documentation and minor refactor to clarify MT memory management
 2022-01-18 10:18:01 -07:00
Elliot Gorokhovsky 9b6dfedf0c Documentation and minor refactor to clarify MT memory management. 2022-01-18 09:43:05 -07:00
Carl Woffenden 829ac2e9ce Work-in-progress; annotated types, added docs, parsed and resolved excluded files 2022-01-18 11:43:01 +01:00
Carl Woffenden 7e50d1e8c1 Using faster Python script to amalgamate 2022-01-17 18:59:54 +01:00
hjl-toolsandGitHub ff92884a89 Merge branch 'facebook:dev' into hjl/cet/dev 2022-01-16 10:07:32 -08:00
Mike Gilbert 57a86d9ec6 Avoid updating timestamps when the destination is stdout 
Fixes: 9cd6c1ff4d
Fixes: https://github.com/facebook/zstd/issues/2997
 2022-01-13 16:47:18 -05:00
Felix HandteandGitHub f4a552a3fa Merge pull request #2987 from felixhandte/prepare-v1.5.2 
Prepare v1.5.2
 2022-01-11 17:47:39 -05:00
H.J. Lu 51ab182bd4 x86-64: Enable Intel CET 
Intel Control-flow Enforcement Technology (CET):

https://en.wikipedia.org/wiki/Control-flow_integrity#Intel_Control-flow_Enforcement_Technology

requires that on Linux, all linker input files are marked as CET enabled
in .note.gnu.property section.  For high-level language source codes,
.note.gnu.property section is added by compiler with the -fcf-protection
option.  For assembly sources, include <cet.h> to add .note.gnu.property
section.
 2022-01-11 13:19:16 -08:00
Felix HandteandGitHub e113c0ca49 Merge pull request #2993 from hjl-tools/hjl/asm/dev 
x86-64: Hide internal assembly functions
 2022-01-11 14:31:51 -05:00
Felix HandteandGitHub 4dfaf0003f Merge pull request #2957 from hmaarrfk/fix_cmake_msvc 
Fixup MSVC source file inclusion for cmake builds
 2022-01-11 13:25:16 -05:00
Yann ColletandGitHub 05e884f288 Merge pull request #2956 from sunwire/fix-tar-test-cases 
Fix tar test cases
 2022-01-11 10:16:34 -08:00
Yann ColletandGitHub 78633272a0 Merge pull request #2982 from terrelln/decompress-progress-0 
Fix stderr progress logging for decompression
 2022-01-11 10:15:15 -08:00
H.J. Lu 568c69a4eb x86-64: Hide internal assembly functions 
Hide x86-64 internal assembly functions. Before

$ nm -D lib/libzstd.so.1 | grep usingDTable_internal_bmi2_asm_loop
00000000000c23c0 T _HUF_decompress4X1_usingDTable_internal_bmi2_asm_loop
00000000000c23c0 T HUF_decompress4X1_usingDTable_internal_bmi2_asm_loop
00000000000c283d T _HUF_decompress4X2_usingDTable_internal_bmi2_asm_loop
00000000000c283d T HUF_decompress4X2_usingDTable_internal_bmi2_asm_loop
$

After

$ nm -D lib/libzstd.so.1 | grep usingDTable_internal_bmi2_asm_loop
$

This fixes issue #2990.
 2022-01-11 10:12:24 -08:00
W. Felix Handte 144879a7cd Update Changelog 2022-01-10 12:48:40 -05:00
Yonatan Komornik df5013b463 ZSTD CLI: Use buffered output for improved performance 2022-01-07 17:10:13 -08:00
Nick Terrell 308a11b8e8 Fix stderr progress logging for decompression 
When decompressing with `-q` and an output file, the progress bar was mistakenly printed. This is a minimal fix, with a larger refactor to be stacked on top of it.

Fixes #2967.
 2022-01-07 15:09:56 -08:00
Yann Collet 5595aec629 updated regression results 2022-01-07 15:08:06 -08:00
Yann Collet ca0135c2fd new Formulation 
presumes faster
 2022-01-07 14:37:53 -08:00
Yann Collet 9e1b4828e5 enforce a minimum price of 1 bit per literal in the optimal parser 2022-01-07 13:53:48 -08:00
W. Felix Handte e1323744b6 Update Docs 2022-01-07 14:14:26 -05:00
W. Felix Handte 46ad9377e8 Bump Version Number to 1.5.2 2022-01-07 14:14:26 -05:00
Nick TerrellandGitHub 5f2c3d9720 Merge pull request #2981 from terrelln/asm-license 
[license] Fix license header of huf_decompress_amd64.S
 2022-01-07 11:06:30 -08:00
Nick Terrell c7b03c217c [license] Fix license header of huf_decompress_amd64.S 
* Add the license header for `huf_decompress_amd64.S`
* Add `.S` files to the `test-license.py` test
 2022-01-07 09:35:27 -08:00
Nick TerrellandGitHub 0677b26b6d Merge pull request #2980 from terrelln/opt-oss-fuzz-fix 
[opt] Fix oss-fuzz bug in optimal parser
 2022-01-07 09:27:09 -08:00
Felix HandteandGitHub 844c53ed75 Merge pull request #2977 from felixhandte/fix-2950 
Remove Dependencies to Allow the Zstd Binary to Dynamically Link to the Library
 2022-01-07 12:10:46 -05:00