ddidderr/zstd-rs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
11,485 Commits 17 Branches 77 Tags
7b94de78ff2c3634cd7ef32f0e16f4722c03578f
Commit Graph
11485 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
W. Felix Handte 11aba9b316 make man 2022-12-22 14:13:24 -05:00
W. Felix Handte 382026f096 Man Page Tweaks, Edits, Formatting Fixes 
This started as an application of the edits suggested in #3201 and expanded
from there.
 2022-12-22 14:13:17 -05:00
Nick Terrell 7fe7a166c2 [cli-tests] Add tests that use --trace-file-stat 
Basic tests for (de)compressing in the following modes:
* file to file
* file to stdout
* stdin to file
* stdin to stdout

These are basic tests, and aren't testing more advanced scenarios, but
it adds the groundwork for more complex tests as needed.

Fixes #3010.
 2022-12-21 18:32:12 -08:00
Nick Terrell 4b40e405d3 [tests] Remove deprecated function from longmatch.c test 
Thanks to @eli-schwartz for pointing it out!

We should maybe consider adding a helper function for applying
`ZSTD_parameters` and `ZSTD_compressionParameters` to a context.
That would aid the transition to the new API in situations like this.
 2022-12-21 17:52:10 -08:00
Nick TerrellandNick Terrell 40a7188130 Fix make clangbuild & add CI 
Fix the errors for:
* `-Wdocumentation`
* `-Wconversion` except `-Wsign-conversion`
 2022-12-21 17:31:04 -08:00
Nick TerrellandNick Terrell 31a703ec13 [cmake] Add noexecstack to compiler/linker flags 2022-12-21 17:30:14 -08:00
Nick Terrell 7df6e25b85 [cli-tests] Add --set-exact-output to update the expected output 
`./run.py --set-exact-output` will update `stdout.expect` and
`stderr.expect` to match the expected output. This doesn't apply to
outputs which use `.glob` or `.ignore`.
 2022-12-21 17:21:09 -08:00
Nick Terrell b6e8112261 [util] Add traces enabled by --trace-file-stat 
Print traces to stderr when --trace-file-stat is passed.
We trace all functions that read and write file metadata.
 2022-12-21 17:19:34 -08:00
Yann ColletandGitHub 7607b96ed9 Merge pull request #3385 from jonpalmisc/improve_help 
Improve help/usage (`-h`, `-H`) formatting
 2022-12-21 10:56:09 -08:00
Felix HandteandGitHub 0694f1435d Merge pull request #3386 from felixhandte/pin-other-action-commit-hashes 
Pin Remaining Action Dependencies (Except OSS-Fuzz)
 2022-12-21 11:24:23 -05:00
Jon Palmisciano 125bcde17c Update tests to expect new CLI help output 2022-12-20 20:13:00 -05:00
Jon Palmisciano 9c93dd71cd Clean up welcome message 2022-12-20 20:13:00 -05:00
Jon Palmisciano 678335c4f3 Rewrite help output to improve readability 2022-12-20 20:12:59 -05:00
W. Felix Handte 150aa23ef4 Pin Remaining Action Dependencies (Except OSS-Fuzz) 
The one that isn't pinned is the OSS-Fuzz builder and runner. They don't
offer tagged releases. I could pin to the current master commit, but I'm not
sure how desirable that is.
 2022-12-20 17:10:01 -05:00
Felix HandteandGitHub 0790e86c56 Merge pull request #3384 from felixhandte/pin-checkout-action-commit-hash 
Pin actions/checkout Dependency to Specific Commit Hash
 2022-12-20 16:08:03 -05:00
Nick TerrellandNick Terrell 651a381060 [build][cmake] Fix cmake with custom assembler 
Tell CMake to explicitly compile our assembly as C code, because we
require it is compiled by a C compiler, and it is only enabled for
clang/gcc.

Fixes #3193.
 2022-12-20 13:02:21 -08:00
Danielle Rozenblit c26f348dc8 fix CI errors 2022-12-20 12:43:46 -08:00
Danielle Rozenblit 2def93bf10 Merge branch 'optimal-huff-depth-speed' of github.com:daniellerozenblit/zstd into optimal-huff-depth-speed 2022-12-20 12:28:07 -08:00
Danielle Rozenblit 482689b995 huf log speed optimization: unidirectional scan of logs + break when regressing 2022-12-20 12:27:38 -08:00
W. Felix Handte e3f2c8b11c Pin actions/checkout Dependency to Specific Commit Hash 
It's a bit silly, because if we can't trust GitHub, what are we doing here?
But OSSF complains about it, so let's fix it.
 2022-12-20 14:53:12 -05:00
Felix HandteandGitHub ea199876e2 Merge pull request #3378 from facebook/dependabot/github_actions/github/codeql-action-2.1.37 
Bump github/codeql-action from 1.0.26 to 2.1.37
 2022-12-20 14:17:33 -05:00
Felix HandteandGitHub 5f0543a508 Merge pull request #3377 from facebook/dependabot/github_actions/ossf/scorecard-action-2.1.0 
Bump ossf/scorecard-action from 2.0.6 to 2.1.0
 2022-12-20 14:16:10 -05:00
Felix HandteandGitHub 3a7e2eec21 Merge pull request #3340 from facebook/dependabot/github_actions/actions/upload-artifact-3 
Bump actions/upload-artifact from 1 to 3
 2022-12-20 14:15:43 -05:00
Nick TerrellandNick Terrell e4018c4e7f [docs] Clarify dictionary loading documentation 
Reinforce that loading a new dictionary clears the current dictionary.
Except for the multiple-ddict mode.
 2022-12-20 11:10:49 -08:00
Felix HandteandGitHub f302ad8811 Merge pull request #3173 from felixhandte/update-copyright-company 
Update Copyright Comments
 2022-12-20 13:51:01 -05:00
W. Felix Handte 5d693cc38c Coalesce Almost All Copyright Notices to Standard Phrasing 
```
for f in $(find . \( -path ./.git -o -path ./tests/fuzz/corpora -o -path ./tests/regression/data-cache -o -path ./tests/regression/cache \) -prune -o -type f); do sed -i '/Copyright .* \(Yann Collet\)\|\(Meta Platforms\)/ s/Copyright .*/Copyright (c) Meta Platforms, Inc. and affiliates./' $f; done

git checkout HEAD -- build/VS2010/libzstd-dll/libzstd-dll.rc build/VS2010/zstd/zstd.rc tests/test-license.py contrib/linux-kernel/test/include/linux/xxhash.h examples/streaming_compression_thread_pool.c lib/legacy/zstd_v0*.c lib/legacy/zstd_v0*.h
nano ./programs/windres/zstd.rc
nano ./build/VS2010/zstd/zstd.rc
nano ./build/VS2010/libzstd-dll/libzstd-dll.rc
```
 2022-12-20 12:52:34 -05:00
W. Felix Handte 7f12f24cf4 Rewrite Copyright Date Ranges from -present to -2022 
Apparently it's better. Somehow.

```
for f in $(find . \( -path ./.git -o -path ./tests/fuzz/corpora -o -path ./tests/regression/data-cache -o -path ./tests/regression/cache \) -prune -o -type f); do echo $f; sed -i 's/\-present/-2022/' $f; done

g co HEAD -- build/meson/
```
 2022-12-20 12:44:56 -05:00
W. Felix Handte 4c999cf968 Update test-license.py 2022-12-20 12:43:16 -05:00
W. Felix Handte 36d5c2f326 Update Copyright Year ('2021' -> 'present') 
```
for f in $(find . \( -path ./.git -o -path ./tests/fuzz/corpora -o -path ./tests/regression/data-cache -o -path ./tests/regression/cache \) -prune -o -type f);
do
  sed -i 's/\-2021/-present/' $f;
done

g co HEAD -- .github/workflows/dev-short-tests.yml # fix bad match
```
 2022-12-20 12:42:50 -05:00
W. Felix Handte 8927f985ff Update Copyright Headers 'Facebook' -> 'Meta Platforms' 
```
for f in $(find . \( -path ./.git -o -path ./tests/fuzz/corpora \) -prune -o -type f);
do
  sed -i 's/Facebook, Inc\./Meta Platforms, Inc. and affiliates./' $f;
done
```
 2022-12-20 12:37:57 -05:00
W. Felix Handte a05cca6208 Manually Update VS Code Copyright Definitions 2022-12-20 12:36:06 -05:00
Yann ColletandGitHub 6a90c0f6fb Merge pull request #3289 from nmoinvaz/cmake/playtest-win 
Don't attempt playTests.sh cmake test if running on Windows.
 2022-12-19 16:39:38 -08:00
Yonatan KomornikandGitHub a8add436ce Merge pull request #3364 from yoniko/fix-windows-mt-thread-resize-bug 
Windows MT layer bug fixes
 2022-12-19 15:54:01 -08:00
Yonatan Komornik 26f1bf7d70 CR fixes 2022-12-19 15:13:43 -08:00
Nick TerrellandNick Terrell e9797b5dc5 [pzstd] Fixes for Windows build 
* Add `Portability.h` to fix min/max issues.
* Fix conversion warnings
* Assert that windowLog <= 23, which is currently always the case.
  This could be loosened, but we aren't looking to add new functionality.

Fixes on top of PR #3375 by @eli-schwartz, which added Windows CI for contrib & programs.
 2022-12-19 14:09:43 -08:00
Eli SchwartzandNick Terrell 67cd24b25b CI: build contrib directory on meson-windows 2022-12-19 14:09:43 -08:00
Eli SchwartzandNick Terrell 3cee69a1cc CI: build programs on meson-windows too 2022-12-19 14:09:43 -08:00
Yann ColletandGitHub 9073fe00cc Merge pull request #3376 from facebook/split2 
Block splitter : minor reformatting
 2022-12-19 13:00:27 -08:00
dependabot[bot]andGitHub 79a00f8dcf Bump github/codeql-action from 1.0.26 to 2.1.37 
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1.0.26 to 2.1.37.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/5f532563584d71fdef14ee64d17bafb34f751ce5...959cbb7472c4d4ad70cdfe6f4976053fe48ab394)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-12-19 05:07:15 +00:00
dependabot[bot]andGitHub 65545969d5 Bump ossf/scorecard-action from 2.0.6 to 2.1.0 
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.0.6 to 2.1.0.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](https://github.com/ossf/scorecard-action/compare/99c53751e09b9529366343771cc321ec74e9bd3d...937ffa90d79c7d720498178154ad4c7ba1e4ad8c)

---
updated-dependencies:
- dependency-name: ossf/scorecard-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-12-19 05:07:09 +00:00
Yann Collet 832c1a6a1c minor reformatting 
and minor reliability and maintenance changes
 2022-12-18 11:26:57 -08:00
Yonatan Komornik aaa38b29bb meson: zstreamtests should now pass on Windows 2022-12-17 13:38:02 -08:00
Yonatan Komornik ec42c92aaa Fix race condition in the Windows thread / pthread translation layer 
When spawning a Windows thread we have small worker wrapper function that translates
between the interfaces of Windows and POSIX threads.
This wrapper is given a pointer that might get stale before the worker starts running,
resulting in UB and crashes.
This commit adds synchronization so that we know the wrapper has finished reading the data
it needs before we allow the main thread to resume execution.
 2022-12-17 13:38:02 -08:00
Yonatan Komornik 500f02eb66 Fixes two bugs in the Windows thread / pthread translation layer 
1. If threads are resized the threads' `ZSTD_pthread_t` might move
while the worker still holds a pointer into it (see more details in #3120).
2. The join operation was waiting for a thread and then return its `thread.arg`
as a return value, but since the `ZSTD_pthread_t thread` was passed by value it
would have a stale `arg` that wouldn't match the thread's actual return value.

This fix changes the `ZSTD_pthread_join` API and removes support for returning
a value. This means that we are diverging from the `pthread_join` API and this
is no longer just an alias.
In the future, if needed, we could return a Windows thread's return value using
`GetExitCodeThread`, but as this path wouldn't be excised in any case, it's
preferable to not add it right now.
 2022-12-17 13:38:02 -08:00
Yonatan KomornikandGitHub fba704f8bb Merge pull request #3374 from yoniko/fix-meson-ci-dependancy 
Fix Meson-Windows CI test by pulling a more recent version msvc-dev-cmd
 2022-12-17 13:36:56 -08:00
Yonatan Komornik 3867c41552 meson: Fix Windows CI test by pulling a more recent version msvc-dev-cmd 2022-12-17 10:33:49 -08:00
Yonatan KomornikandGitHub ce61cb836d Merge pull request #3120 from eli-schwartz/meson-fixup 
Meson test fixups
 2022-12-16 18:28:54 -08:00
Yann ColletandGitHub 3a484efb3e Merge pull request #3373 from facebook/decompressBound 
decompressBound tests and fix
 2022-12-16 16:55:30 -08:00
Yann Collet 2f4238e47a make ZSTD_DECOMPRESSBOUND() compatible with input size 0 
for environments with stringent compilation warnings.
 2022-12-16 16:05:39 -08:00
Yann Collet ea24b88667 decompressBound() tests 
fixed an overflow in an intermediate result on 32-bit platform.
Checked that the new test catch this bug in 32-bit mode.
 2022-12-16 15:43:26 -08:00