Yann Collet and GitHub
823b32ce43
Merge pull request #3749 from facebook/dependabot/github_actions/actions/checkout-4.0.0
...
Bump actions/checkout from 3.5.3 to 4.0.0
2023-09-12 13:58:08 -07:00
Yann Collet
607933a2ff
minor simplification for dependency generation
...
also : fix zstd-nomt exclusion and test
2023-09-12 13:46:03 -07:00
Yann Collet
f4dbfce79c
define LIB_SRCDIR and LIB_BINDIR
2023-09-12 13:46:03 -07:00
Yann Collet
feaa8ac50d
renamed STATLIB into STATICLIB
...
for improved clarity
2023-09-12 13:46:03 -07:00
Yann Collet
4edfaa93b7
default targets of lib/ and programs/ have different names
...
avoid risks on overlapping in case of include
2023-09-12 13:46:03 -07:00
Yann Collet
b69d06a810
add include guards
...
alleviate risks of double inclusion (typically via transitive includes)
2023-09-12 13:46:03 -07:00
Yann Collet and GitHub
1ec201c7b9
Merge pull request #3745 from klausholstjacobsen/qnx-support
...
Added qnx in the posix test section of platform.h
2023-09-12 13:43:59 -07:00
Yann Collet and GitHub
f2bc34d9b4
Merge pull request #3750 from facebook/dependabot/github_actions/actions/upload-artifact-3.1.3
...
Bump actions/upload-artifact from 3.1.2 to 3.1.3
2023-09-12 13:43:00 -07:00
Paul Menzel
d55ebb5718
[pzstd]: Fix DESTDIR handling to allow setting BINDIR
...
Currently, setting `BINDIR` and `DESTDIR` separately is not possible, so
the command below fails, as BINDIR is set explicitly:
$ make -j80 install PREFIX=/usr EPREFIX=/usr BINDIR=/usr/bin SBINDIR=/usr/sbin LIBEXECDIR=/usr/libexec SYSCONFDIR=/etc SHAREDSTATEDIR=/var LOCALST ATEDIR=/var LIBDIR=/usr/lib INCLUDEDIR=/usr/include DATAROOTDIR=/usr/share DATADIR=/usr/share INFODIR=/usr/share/info LOCALEDIR=/usr/share/locale MAND IR=/usr/share/man DOCDIR=/usr/share/doc/zstd DESTDIR=/dev/shm/bee-pmenzel/zstd/zstd-1.5.5-0/image -C contrib/pzstd DESTDIR=/dev/shm/bee-pmenzel/zstd/zstd-1.5.5-0/image
make: Entering directory
'/dev/shm/bee-pmenzel/zstd/zstd-1.5.5-0/source/contrib/pzstd' CFLAGS=" -I../../lib -I../../lib/common -I../../programs -I. -DNDEBUG -O3 -Wall -Wextra -Wno-deprecated-declarations " LDFLAGS=" -O3 -Wall -Wextra -pedantic " make -C ../../lib libzstd.a
make[1]: Entering directory '/dev/shm/bee-pmenzel/zstd/zstd-1.5.5-0/source/lib'
make[1]: Leaving directory '/dev/shm/bee-pmenzel/zstd/zstd-1.5.5-0/source/lib'
g++ main.o ../../programs/util.o Options.o Pzstd.o SkippableFrame.o ../../lib/libzstd.a -O3 -Wall -Wextra -pedantic -pthread -o pzstd
install -d -m 755 /usr/bin/
install -m 755 pzstd /usr/bin/pzstd
install: cannot create regular file '/usr/bin/pzstd': Permission denied
make: *** [Makefile:116: install] Error 1
So, do not prefix `BINDIR` with `DESTDIR`, and adapt all paths for
installation. This is more common, and, for example, `programs/Makefile`
does the same.
Fixes: 8b4e84249b ("[pzstd] Fix Makefile")
2023-09-12 19:15:25 +02:00
dependabot[bot] and GitHub
d8b25cbf68
Bump actions/upload-artifact from 3.1.2 to 3.1.3
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 3.1.2 to 3.1.3.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](https://github.com/actions/upload-artifact/compare/0b7f8abb1508181956e8e162db84b466c27e18ce...a8a3f3ad30e3422c9c7b888a15615d19a852ae32 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-11 05:09:05 +00:00
dependabot[bot] and GitHub
e0e309f27c
Bump actions/checkout from 3.5.3 to 4.0.0
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.5.3 to 4.0.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/c85c95e3d7251135ab7dc9ce3241c5835cc595a9...3df4ab11eba7bda6032a0b82a6bb43b11571feac )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-11 05:09:02 +00:00
Yann Collet and GitHub
01dbbdf560
Merge pull request #3739 from JohanMabille/cmake
...
Fixed zstd cmake shared build on windows
2023-09-10 06:32:24 -07:00
Yann Collet and GitHub
1de57bb271
Merge pull request #3733 from ldv-alt/zdictlib_fix_prototype_mismatch
...
zdictlib: fix prototype mismatch
2023-09-10 06:31:52 -07:00
klausholstjacobsen
839c7939e8
Added qnx in the posix test section of platform.h
2023-09-03 11:40:53 +02:00
Johan Mabille
253873220f
Fixed zstd cmake shared build on windows
2023-08-27 16:51:24 +02:00
Nick Terrell and Nick Terrell
396ef5b434
Fix & refactor Huffman repeat tables for dictionaries
...
The Huffman repeat mode checker assumed that the CTable was zeroed in the region `[maxSymbolValue + 1, 256)`.
This assumption didn't hold for tables built in the dictionaries, because it didn't go through the same codepath.
Since this code was originally written, we added a header to the CTable that specifies the `tableLog`.
Add `maxSymbolValue` to that header, and check that the table's `maxSymbolValue` is at least the block's `maxSymbolValue`.
This solution is cleaner because we write this header for every CTable we build, so it can't be missed in any code path.
Credit to OSS-Fuzz
2023-08-25 13:21:58 -04:00
Nick Terrell and Nick Terrell
c27fa39904
Work around nullptr-with-nonzero-offset warning
...
See comment.
2023-08-25 13:20:59 -04:00
Dmitry V. Levin
ecb86d8286
zdictlib: fix prototype mismatch
...
Fix the following warnings reported by the compiler when
ZDICTLIB_STATIC_API is not defined to ZDICTLIB_API:
lib/dictBuilder/cover.c:1122:21: warning: redeclaration of 'ZDICT_optimizeTrainFromBuffer_cover' with different visibility (old visibility
preserved)
lib/dictBuilder/cover.c:736:21: warning: redeclaration of 'ZDICT_trainFromBuffer_cover' with different visibility (old visibility
+preserved)
lib/dictBuilder/fastcover.c:549:1: warning: redeclaration of 'ZDICT_trainFromBuffer_fastCover' with different visibility (old visibility
preserved)
lib/dictBuilder/fastcover.c:618:1: warning: redeclaration of 'ZDICT_optimizeTrainFromBuffer_fastCover' with different visibility (old
visibility preserved)
2023-08-23 08:00:00 +00:00
Yann Collet and GitHub
0fcb28c5d2
Merge pull request #3720 from QBos07/cygwin-msys2-support
...
Updated Makefiles for full MSYS2 and Cygwin installation and testing …
2023-08-22 16:29:34 -07:00
Yann Collet and GitHub
59af58762a
Merge pull request #3728 from 0o001/dev
...
fix: ZSTD_BUILD_DECOMPRESSION message
2023-08-22 13:33:47 -07:00
Nick Terrell and Nick Terrell
bd02c9be6e
No longer reject dictionaries with literals maxSymbolValue < 255
...
We already have logic in our Huffman encoder to validate Huffman tables with missing symbols.
We use this for higher compression levels to re-use the previous blocks statistics, or when the dictionaries table has zero-weighted symbols.
This check was leftover as an oversight from before we added validation for Huffman tables.
I validated that the `dictionary_loader` fuzzer has coverage of every line in the `ZSTD_loadCEntropy()` function to validate that it is correctly testing this function.
2023-08-22 13:22:35 -04:00
Yann Collet and GitHub
9662fe1683
Merge pull request #3726 from facebook/fullbench_dctx
...
added ZSTD_decompressDCtx() benchmark option to fullbench
2023-08-21 12:35:51 -07:00
Felix Handte and GitHub
edb6e8f427
Merge pull request #3730 from facebook/dependabot/github_actions/github/codeql-action-2.21.4
...
Bump github/codeql-action from 2.20.3 to 2.21.4
2023-08-21 09:47:26 -07:00
dependabot[bot] and GitHub
db0ae65436
Bump github/codeql-action from 2.20.3 to 2.21.4
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 2.20.3 to 2.21.4.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](https://github.com/github/codeql-action/compare/46ed16ded91731b2df79a2893d3aea8e9f03b5c4...a09933a12a80f87b87005513f0abb1494c27a716 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-21 05:51:56 +00:00
Mustafa UZUN
a02d81f944
fix: ZSTD_BUILD_DECOMPRESSION message
2023-08-19 15:44:53 +03:00
Yann Collet
a07d7c4e29
added ZSTD_decompressDCtx() benchmark option to fullbench
...
useful to compare the difference between ZSTD_decompress
and ZSTD_decompressDCtx().
2023-08-16 10:43:39 -07:00
Felix Handte and GitHub
3298a08076
Merge pull request #3725 from felixhandte/msan-unpoison-cwksp-on-free
...
Unpoison Workspace Memory Before Custom-Free
2023-08-16 10:18:31 -07:00
W. Felix Handte
9987d2f594
Unpoison Workspace Memory Before Freeing to Custom Free
...
MSAN is hooked into the system malloc, but when the user provides a custom
allocator, it may not provide the same cleansing behavior. So if we leave
memory poisoned and return it to the user's allocator, where it is re-used
elsewhere, our poisoning can blow up in some other context.
2023-08-16 12:09:12 -04:00
W. Felix Handte
5f5bdc1e5d
Easy: Move Helper Functions Up
2023-08-16 12:08:52 -04:00
Nick Terrell and Nick Terrell
969e54f26e
Improve dual license wording in README
...
We are licensed under BSD or GPLv2. It is clear in our headers, but not in the README.
Fixes #3717
2023-08-14 12:44:04 -04:00
Quentin Boswank
78dbba76b8
Updated Makefiles for full MSYS2 and Cygwin installation and testing support.
...
They are Linux-like environments under Windows and have all the tools needed to support staged installation and testing.
Beware: this only affects the make build system.
2023-08-13 19:44:15 +02:00
Yann Collet and GitHub
d857369028
Merge pull request #3712 from alexsifivetw/fix_typo
...
Fixed typo
2023-08-02 11:11:31 -07:00
jysh1214 and alexsifivetw
e99d554903
Fixed typo
2023-08-02 11:29:35 +08:00
Yann Collet and GitHub
eb9f881eb8
Merge pull request #3701 from nikohoffren/grammar-fix
...
Fix typographical error in README.md
2023-07-31 03:25:17 -07:00
Yann Collet and GitHub
65dbb0b77b
Merge pull request #3704 from void0red/dev
...
fileio_asyncio: handle malloc fails in AIO_ReadPool_create
2023-07-29 18:16:14 -07:00
void0red and GitHub
4d267f3d4f
fileio_asyncio: handle malloc fails in AIO_ReadPool_create
2023-07-21 12:17:03 +08:00
Gianfranco Costamagna and Nick Terrell
de6b46dfc8
Update fileio.c: fix build failure with enabled LTO
...
For some reasons when LTO is enabled, the compiler complains about statbuf variable not being correctly initialized, even though the variable has an assert != NULL just few lines below (FIO_getDictFileStat)
This is the fixed build failure:
x86_64-linux-gnu-gcc -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -fdebug-prefix-map=/<<PKGBUILDDIR>>=/usr/src/libzstd-1.5.5+dfsg2-1 -Wall -Wextra -Wcast-qual -Wcast-align -Wshadow -Wstrict-aliasing=1 -Wswitch-enum -Wdeclaration-after-statement -Wstrict-prototypes -Wundef -Wpointer-arith -Wvla -Wformat=2 -Winit-self -Wfloat-equal -Wwrite-strings -Wredundant-decls -Wmissing-prototypes -Wc++-compat -g -Werror -Wa,--noexecstack -Wdate-time -D_FORTIFY_SOURCE=2 -DXXH_NAMESPACE=ZSTD_ -DDEBUGLEVEL=1 -DZSTD_LEGACY_SUPPORT=5 -DZSTD_MULTITHREAD -DZSTD_GZCOMPRESS -DZSTD_GZDECOMPRESS -DZSTD_LZMACOMPRESS -DZSTD_LZMADECOMPRESS -DZSTD_LZ4COMPRESS -DZSTD_LZ4DECOMPRESS -DZSTD_LEGACY_SUPPORT=5 -c -MT obj/conf_086c46a51a716b674719b8acb8484eb8/zstdcli_trace.o -MMD -MP -MF obj/conf_086c46a51a716b674719b8acb8484eb8/zstdcli_trace.d -o obj/conf_086c46a51a716b674719b8acb8484eb8/zstdcli_trace.o zstdcli_trace.c
In function ‘UTIL_isRegularFileStat’,
inlined from ‘UTIL_getFileSizeStat’ at util.c:524:10,
inlined from ‘FIO_createDResources’ at fileio.c:2230:30:
util.c:209:12: error: ‘statbuf.st_mode’ may be used uninitialized [-Werror=maybe-uninitialized]
209 | return S_ISREG(statbuf->st_mode) != 0;
| ^
fileio.c: In function ‘FIO_createDResources’:
fileio.c:2223:12: note: ‘statbuf’ declared here
2223 | stat_t statbuf;
| ^
lto1: all warnings being treated as errors
2023-07-20 19:00:13 -04:00
Jacob Greenfield and Nick Terrell
55ff3e4e17
Save one byte on the frame epilogue
2023-07-20 18:59:44 -04:00
Yann Collet and GitHub
ef59cc39cd
Merge pull request #3665 from gjasny/fix-asm-for-xcode
...
Fix Intel Xcode builds with assembly
2023-07-20 01:48:39 -07:00
Niko Hoffrén
a1b9a5ad0e
Fix typographical error in README.md
2023-07-19 21:49:43 +03:00
Elliot Gorokhovsky and GitHub
ccd494860a
Merge pull request #3697 from facebook/dependabot/github_actions/github/codeql-action-2.20.3
...
Bump github/codeql-action from 2.20.1 to 2.20.3
2023-07-11 13:37:20 -07:00
dependabot[bot] and GitHub
065ea9274f
Bump github/codeql-action from 2.20.1 to 2.20.3
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 2.20.1 to 2.20.3.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](https://github.com/github/codeql-action/compare/f6e388ebf0efc915c6c5b165b019ee61a6746a38...46ed16ded91731b2df79a2893d3aea8e9f03b5c4 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-10 05:37:59 +00:00
Yann Collet and GitHub
118200f7b9
Merge pull request #3677 from facebook/detectOverflow
...
Changed the decoding loop to detect more invalid cases of corruption sooner
2023-07-05 00:59:08 -07:00
Yann Collet and GitHub
25822342be
Merge pull request #3688 from nidhijaju/hide-asm-apple
...
Hide ASM symbols on Apple platforms
2023-06-29 19:40:37 -07:00
Elliot Gorokhovsky and GitHub
68aa9a4ea3
Merge pull request #3689 from facebook/dependabot/github_actions/github/codeql-action-2.20.1
...
Bump github/codeql-action from 2.3.2 to 2.20.1
2023-06-27 18:05:52 -07:00
Elliot Gorokhovsky and GitHub
8090c90491
Merge pull request #3690 from facebook/dependabot/github_actions/ossf/scorecard-action-2.2.0
...
Bump ossf/scorecard-action from 2.1.3 to 2.2.0
2023-06-27 18:05:32 -07:00
Elliot Gorokhovsky and GitHub
52bbf1be54
Merge pull request #3686 from embg/ldm_error
...
Clean up a false error message in the LDM debug log
2023-06-26 13:43:20 -04:00
dependabot[bot] and GitHub
2c97f5dbed
Bump ossf/scorecard-action from 2.1.3 to 2.2.0
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 2.1.3 to 2.2.0.
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](https://github.com/ossf/scorecard-action/compare/80e868c13c90f172d68d1f4501dee99e2479f7af...08b4669551908b1024bb425080c797723083c031 )
---
updated-dependencies:
- dependency-name: ossf/scorecard-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-26 05:59:43 +00:00
dependabot[bot] and GitHub
1a6278c82d
Bump github/codeql-action from 2.3.2 to 2.20.1
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 2.3.2 to 2.20.1.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](https://github.com/github/codeql-action/compare/f3feb00acb00f31a6f60280e6ace9ca31d91c76a...f6e388ebf0efc915c6c5b165b019ee61a6746a38 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-26 05:59:38 +00:00
Nidhi Jaju
b1a30e2b4a
hide asm functions on apple platforms
2023-06-26 00:07:30 +00:00