rustics/dns
2
0
Fork 0
Code Issues 8 Pull Requests Projects 1 Releases Wiki Activity

(clippy) some small clippy fixes #28

Merged
mice_on_drugs merged 1 commits from clippy_fixes into master 2022-06-05 14:58:37 +02:00
Conversation 1 Commits 1 Files Changed 1 +10 -10
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/proto.rs
View File

@ -332,7 +332,7 @@ mod tests {
let invalid_rcodes = [11, 12, 13, 14, 15]; let invalid_rcodes = [11, 12, 13, 14, 15];
for rcode in invalid_rcodes { for rcode in invalid_rcodes {
dns_query[3] = (rcode as u8) << 0; dns_query[3] = rcode;
let parse_result = DNSHeader::from_udp_datagram(&dns_query); let parse_result = DNSHeader::from_udp_datagram(&dns_query);
@ -368,7 +368,7 @@ mod tests {
]; ];
for (rcode, parsed_rcode) in valid_rcodes { for (rcode, parsed_rcode) in valid_rcodes {
dns_query[3] = rcode << 0; dns_query[3] = rcode;
let parse_result = DNSHeader::from_udp_datagram(&dns_query); let parse_result = DNSHeader::from_udp_datagram(&dns_query);
assert_eq!( assert_eq!(
parse_result?.response_code, parsed_rcode, parse_result?.response_code, parsed_rcode,
@ -525,7 +525,7 @@ mod tests {
0xff, 0x00, 0x04, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0x00, 0x04, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
]; ];
let parse_result = DNSHeader::from_udp_datagram(&dns_query); let parse_result = DNSHeader::from_udp_datagram(&dns_query);
assert_eq!(parse_result?.authorative_answer, true); assert!(parse_result?.authorative_answer);
Ok(()) Ok(())
} }
@ -535,7 +535,7 @@ mod tests {
0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
]; ];
let parse_result = DNSHeader::from_udp_datagram(&dns_query); let parse_result = DNSHeader::from_udp_datagram(&dns_query);
assert_eq!(parse_result?.authorative_answer, false); assert!(!parse_result?.authorative_answer);
Ok(()) Ok(())
} }
} }
@ -549,7 +549,7 @@ mod tests {
0xff, 0x00, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0x00, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
]; ];
let parse_result = DNSHeader::from_udp_datagram(&dns_query); let parse_result = DNSHeader::from_udp_datagram(&dns_query);
assert_eq!(parse_result?.truncated, true); assert!(parse_result?.truncated);
Ok(()) Ok(())
} }
@ -559,7 +559,7 @@ mod tests {
0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
]; ];
let parse_result = DNSHeader::from_udp_datagram(&dns_query); let parse_result = DNSHeader::from_udp_datagram(&dns_query);
assert_eq!(parse_result?.truncated, false); assert!(!parse_result?.truncated);
Ok(()) Ok(())
} }
} }
@ -573,7 +573,7 @@ mod tests {
0xff, 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
]; ];
let parse_result = DNSHeader::from_udp_datagram(&dns_query); let parse_result = DNSHeader::from_udp_datagram(&dns_query);
assert_eq!(parse_result?.recursion_desired, true); assert!(parse_result?.recursion_desired);
Ok(()) Ok(())
} }
@ -583,7 +583,7 @@ mod tests {
0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
]; ];
let parse_result = DNSHeader::from_udp_datagram(&dns_query); let parse_result = DNSHeader::from_udp_datagram(&dns_query);
assert_eq!(parse_result?.recursion_desired, false); assert!(!parse_result?.recursion_desired);
Ok(()) Ok(())
} }
} }
@ -597,7 +597,7 @@ mod tests {
0xff, 0x00, 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0x00, 0x00, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
]; ];
let parse_result = DNSHeader::from_udp_datagram(&dns_query); let parse_result = DNSHeader::from_udp_datagram(&dns_query);
assert_eq!(parse_result?.recursion_available, true); assert!(parse_result?.recursion_available);
Ok(()) Ok(())
} }
@ -607,7 +607,7 @@ mod tests {
0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
]; ];
let parse_result = DNSHeader::from_udp_datagram(&dns_query); let parse_result = DNSHeader::from_udp_datagram(&dns_query);
assert_eq!(parse_result?.recursion_available, false); assert!(!parse_result?.recursion_available);
Ok(()) Ok(())
} }
} }