[release] expose-dir-via-http v1.3.1

[code] small improvements suggested by Grok 3
- differentiate between "not a directory" and a real error while reading the path - don't clone the PathBuf, instead use Arc
2025-02-20 19:05:12 +01:00 · 2025-02-20 19:04:53 +01:00 · 2025-02-20 18:27:24 +01:00 · 2025-02-20 18:27:22 +01:00 · 2025-02-20 18:27:17 +01:00
3 changed files with 27 additions and 25 deletions
--- a/Cargo.lock
+++ b/Cargo.lock
@ -413,9 +413,9 @@ checksum = "baf1de4339761588bc0619e3cbc0120ee582ebb74b53b4efbf79117bd2da40fd"

 [[package]]
 name = "clap"
-version = "4.5.29"
+version = "4.5.30"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "8acebd8ad879283633b343856142139f2da2317c96b05b4dd6181c61e2480184"
+checksum = "92b7b18d71fad5313a1e320fa9897994228ce274b60faa4d694fe0ea89cd9e6d"
 dependencies = [
 "clap_builder",
 "clap_derive",
@ -423,9 +423,9 @@ dependencies = [

 [[package]]
 name = "clap_builder"
-version = "4.5.29"
+version = "4.5.30"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "f6ba32cbda51c7e1dfd49acc1457ba1a7dec5b64fe360e828acb13ca8dc9c2f9"
+checksum = "a35db2071778a7344791a4fb4f95308b5673d219dee3ae348b86642574ecc90c"
 dependencies = [
 "anstream",
 "anstyle",
@ -562,7 +562,7 @@ checksum = "877a4ace8713b0bcf2a4e7eec82529c029f1d0619886d18145fea96c3ffe5c0f"

 [[package]]
 name = "expose-dir-via-http"
-version = "1.2.1"
+version = "1.3.1"
 dependencies = [
 "actix-files",
 "actix-web",
@ -1197,18 +1197,18 @@ checksum = "f79dfe2d285b0488816f30e700a7438c5a73d816b5b7d3ac72fbc48b0d185e03"

 [[package]]
 name = "serde"
-version = "1.0.217"
+version = "1.0.218"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "02fc4265df13d6fa1d00ecff087228cc0a2b5f3c0e87e258d8b94a156e984c70"
+checksum = "e8dfc9d19bdbf6d17e22319da49161d5d0108e4188e8b680aef6299eed22df60"
 dependencies = [
 "serde_derive",
 ]

 [[package]]
 name = "serde_derive"
-version = "1.0.217"
+version = "1.0.218"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "5a9bf7cf98d04a2b28aead066b7496853d4779c9cc183c440dbac457641e19a0"
+checksum = "f09503e191f4e797cb8aac08e9a4a4695c5edf6a2e70e376d961ddd5c969f82b"
 dependencies = [
 "proc-macro2",
 "quote",
@ -1217,9 +1217,9 @@ dependencies = [

 [[package]]
 name = "serde_json"
-version = "1.0.138"
+version = "1.0.139"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "d434192e7da787e94a6ea7e9670b26a036d0ca41e0b7efb2676dd32bae872949"
+checksum = "44f86c3acccc9c65b153fe1b85a3be07fe5515274ec9f0653b4a0875731c72a6"
 dependencies = [
 "itoa",
 "memchr",
@ -1417,9 +1417,9 @@ dependencies = [

 [[package]]
 name = "typenum"
-version = "1.17.0"
+version = "1.18.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "42ff0bf0c66b8238c6f3b578df37d0b7848e55df8577b3f74f92a69acceeb825"
+checksum = "1dccffe3ce07af9386bfd29e80c0ab1a8205a2fc34e4bcd40364df902cfa8f3f"

 [[package]]
 name = "unicase"
@ -1429,9 +1429,9 @@ checksum = "75b844d17643ee918803943289730bec8aac480150456169e647ed0b576ba539"

 [[package]]
 name = "unicode-ident"
-version = "1.0.16"
+version = "1.0.17"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "a210d160f08b701c8721ba1c726c11662f877ea6b7094007e1ca9a1041945034"
+checksum = "00e2473a93778eb0bad35909dff6a10d28e63f792f16ed15e404fca9d5eeedbe"

 [[package]]
 name = "url"
--- a/Cargo.toml
+++ b/Cargo.toml
@ -1,7 +1,7 @@
 [package]
 name = "expose-dir-via-http"
-version = "1.2.1"
-edition = "2021"
+version = "1.3.1"
+edition = "2024"

 [lints.rust]
 unsafe_code = "forbid"
--- a/src/main.rs
+++ b/src/main.rs
@ -2,11 +2,12 @@ use std::{
    net::{IpAddr, SocketAddr},
    num::NonZeroUsize,
    path::PathBuf,
+    sync::Arc,
    thread::available_parallelism,
 };

 use actix_web::{App, HttpServer};
-use clap::{crate_name, crate_version, Parser};
+use clap::{Parser, crate_name, crate_version};

 #[derive(Parser, Debug)]
 #[clap(name = crate_name!(), version = crate_version!())]
@ -25,11 +26,11 @@ struct Args {
 }

 fn parse_valid_dir(dir: &str) -> Result<PathBuf, String> {
-    let path = std::path::Path::new(dir);
-    if path.is_dir() {
-        Ok(path.to_path_buf())
-    } else {
-        Err(format!("{} is not a valid directory", path.display()))
+    let path = PathBuf::from(dir);
+    match std::fs::metadata(&path) {
+        Ok(metadata) if metadata.is_dir() => Ok(path),
+        Ok(_) => Err(format!("{} is not a directory", path.display())),
+        Err(e) => Err(format!("Error accessing {}: {}", path.display(), e)),
    }
 }

@ -37,7 +38,7 @@ fn parse_valid_dir(dir: &str) -> Result<PathBuf, String> {
 async fn main() -> std::io::Result<()> {
    let args = Args::parse();

-    let dir = args.dir;
+    let dir = Arc::new(args.dir);
    let sock = SocketAddr::new(args.ip, args.port);

    println!(
@ -46,8 +47,9 @@ async fn main() -> std::io::Result<()> {
    );

    HttpServer::new(move || {
+        let dir = dir.clone();
        App::new().service(
-            actix_files::Files::new("/", dir.clone())
+            actix_files::Files::new("/", dir.as_ref())
                .show_files_listing()
                .prefer_utf8(true),
        )
Author	SHA1	Message	Date
ddidderr	8b94b630be	[release] expose-dir-via-http v1.3.1	2025-02-20 19:05:12 +01:00
ddidderr	e35b0c9fd9	[code] small improvements suggested by Grok 3 - differentiate between "not a directory" and a real error while reading the path - don't clone the PathBuf, instead use Arc	2025-02-20 19:04:53 +01:00
ddidderr	b5a2c750c5	[release] expose-dir-via-http v1.3.0	2025-02-20 18:27:24 +01:00
ddidderr	c7b0ca62f6	[deps] cargo update Updating clap_builder v4.5.29 -> v4.5.30 Updating clap v4.5.29 -> v4.5.30 Updating serde_derive v1.0.217 -> v1.0.218 Updating serde_json v1.0.138 -> v1.0.139 Updating serde v1.0.217 -> v1.0.218 Updating typenum v1.17.0 -> v1.18.0 Updating unicode-ident v1.0.16 -> v1.0.17	2025-02-20 18:27:22 +01:00
ddidderr	34457d1cc1	[rust] edition 2024	2025-02-20 18:27:17 +01:00