0 Fork 0

Files

T

ddidderr 3068e3a389 fix(config): port Zig 0.15.2 basename (not 0.16) for theme names

The first basename port followed Zig 0.16's ComponentIterator-based
implementation (the system std); Ghostty 1.3.1 builds with 0.15.2. The
theme-name check now ports 0.15.2's basenamePosix/basenameWindows: a ':'
at byte 1 ends the drive designator for any first byte, so '1:theme'
yields 'theme'. Tests use the 0.15.2 cases.

2026-10-12 14:59:07 +02:00

3.1 KiB

Raw Blame History

Z16: RV13 P3 fixes

1. auto-update-channel

Config::finalize now defaults the field from ghostty_build_info::RELEASE_CHANNEL (Zig: build_config.release_channel); ghostty-config gained the dep. Tests: default follows the build channel, explicit value kept. +show-config for this tip build prints tip like /usr/bin/ghostty.

2. async-backend

ghostty_os::xev (new): libxev Dynamic selection: Backend, candidates (Linux: io_uring, epoll; others single), backend() (process global, default = last candidate = epoll), available (io_uring: IoUring::new(256) like libxev, plus we require EXT_ARG and POLL_ADD/POLL_REMOVE probes), detect(), prefer().
ghostty-core global init: detect (warn on failure) and libxev default backend=.. info log (global.zig). +version prints the real backend instead of n/a.
GTK Application::startup calls startup_xev -> apply_async_backend (application.zig startupXev): auto no-op, else prefer, logs libxev manual backend= / libxev manual backend failed, using default=.
ghostty_termio::reactor (new): Reactor = Epoll (persistent epoll, registrations diffed per wait), IoUring (io-uring crate: one-shot POLL_ADD per interest, POLL_REMOVE on drop, EXT_ARG timeout; unsafe only for SQ push with SAFETY comment) or Poll (poll(2), used where libxev has one fixed backend, i.e. macOS kqueue). Thread::new() uses xev::backend(); Thread::with_backend for tests. The IO loop and the post-failure drain loop run on it.
Not changed: the renderer and search threads use crossbeam channels (not fd loops), and the pty reader is a dedicated blocking thread (as in Zig), so there is nothing to select there.
Tests: reactor unit tests (timeout, level trigger, drop/re-add, cross-thread wake, fd reuse) per backend; tests/exec_integration now runs the whole 21-test suite 3x (poll, epoll, io_uring; io_uring skips with a SKIP message if unavailable). In this sandbox io_uring IS available and was exercised. (Fixed a test-only pid-file collision between suites.)

3. Windows zig_error

/usr/lib/zig/std is 0.16; the real 0.15.2 std is at target/zig-0.15.2/.../lib/std. The table follows 0.15.2 windows.OpenFile's NTSTATUS arms (verified), translated to Win32 codes (see the doc table in os/zig_error.rs): sharing violation, access denied, user-mapped-file -> AccessDenied; invalid name -> BadPathName; BAD_NETPATH/BAD_NET_NAME -> NetworkNotFound; NOT_READY -> NoDevice; PIPE_BUSY -> PipeBusy; ALREADY_EXISTS -> PathAlreadyExists; ERROR_DIRECTORY -> NotDir; 206 -> NameTooLong. Removed CreateProcess-only entries (FileBusy, InvalidName, InvalidExe, SystemResources, NoSpaceLeft) which file opens never produce (Unexpected). Table is a host-independent fn so it is tested on Linux. (FILE_IS_A_DIRECTORY -> IsDir is unobservable: Win32 reports it as ERROR_ACCESS_DENIED.)

4. basename

config/theme.rs: exact port of 0.15.2 basenamePosix/basenameWindows (a : at byte index 1 ends the drive designator for any first byte, so 1:theme -> theme). Tests include the 0.15.2 testBasenameWindows cases. (An earlier draft ported 0.16's ComponentIterator version; replaced.)

3.1 KiB Raw Blame History