0 Fork 0

Files

T

ddidderr a8d0d624da test(windows): run the Windows code under Wine; theme preview parity

Windows was previously only compile-checked. With Wine 11 (staging)
and mingw available, scripts/windows-wine-test.sh (`just
test-windows-wine`) builds expat/FreeType/fontconfig for mingw under
target/wine-deps and runs the test suites of ghostty-vt, unicode,
datastruct, input, os, config, terminal, crash, termio and cli under
Wine (~2,700 tests). New termio/tests/exec_windows.rs drives real
cmd.exe children over ConPTY through Termio (output, exit codes,
typing, 120 KiB writes, stop, start failure). Fixes found: Windows
paths from fs::canonicalize leaked the \\?\ prefix (new
ghostty_os::path::realpath strips it like Zig); ghostty-font compiles
hb-ft for bundled HarfBuzz on Windows; ~25 tests had Unix assumptions.
Wine limitations are ignored with reasons (ResizePseudoConsole stub,
no POSIX rename over existing files) - docs/rewrite/notes/windows-wine.md.

+list-themes preview parity (former KNOWN_DIFFERENCES rows 5-9): the
search box ports vaxis TextInput (word navigation and editing bindings,
grapheme-wise editing), ASCII-only case folding, light initial colors
until terminal reports arrive (no COLORFGBG), and load errors end the
preview with exit 1; PTY tests compare with /usr/bin/ghostty.

Test Plan:
- just test-windows-wine
- cargo test -p ghostty-cli --test list_themes_pty
- cargo test --workspace --no-fail-fast (3601 passed)

2026-10-12 17:23:24 +02:00

1.2 KiB

Raw Blame History

Known differences (left by the stopping criterion)

All previously listed differences (rows 5-10: theme-search word navigation, grapheme backspace, ASCII-only case folding, initial preview colors, load_file error propagation, subprocess cleanup wait) have been fixed; see notes/final-P3.md (row 10 is registered as a deviant fix in DEVIANT_FIXES.md). No known differences are currently recorded here.

Not verifiable on this machine

Native Apple execution: Metal, IOSurface, CoreText, Apple input APIs, Mach handling and Apple packaging (compile-checked only, just check-macos).
Native Windows (real Windows console host, Windows-only APIs Wine stubs: ResizePseudoConsole is a Wine stub, POSIX-semantics rename over an existing file is unsupported by Wine). The Windows code paths are otherwise run under Wine (just test-windows-wine, see notes/windows-wine.md): ConPTY, CreateProcessW, pipes, the IO thread and cmd.exe children are runtime-tested; just check-windows stays the clippy gate.
Native FreeBSD execution (cross cargo check only, if the target could be added).
Live portal / D-Bus integration.
Real-browser rendering (wasm is checked with Node only).
Native io_uring execution; Swift code was excluded.

1.2 KiB Raw Blame History

Known differences (left by the stopping criterion)

Not verifiable on this machine

1.2 KiB

Raw Blame History