Files

T

fix: remove staging chunks after completed uploads

Successful completion moved the assembled file into data/complete but left the
upload staging directory behind, including all chunk files. Remove the upload's
staging directory only after the final file has been renamed into place so
incomplete and failed uploads remain resumable.

A repeat complete request for that old upload id now returns 404 because the
temporary upload record has been retired with its chunks.

Test Plan:
- just check

Refs: none

2026-05-30 17:59:21 +02:00

2.3 KiB

Raw Blame History

Test Scenarios

Keep this file as the reusable verification checklist while implementing PLAN.md.

Automated

just check
- Runs formatting, all Rust tests, and clippy.
- Current coverage:
  - GET / serves the static browser page.
  - GET /healthz reports ok.
  - POST /api/uploads creates meta.json and chunk directories.
  - POST /api/uploads rejects an empty file name.
  - PUT /api/uploads/:id/chunks/:index stores validated chunk files.
  - PUT /api/uploads/:id/chunks/:index rejects wrong-size chunks.
  - PUT /api/uploads/:id/chunks/:index rejects out-of-range indexes.
  - PUT /api/uploads/:id/chunks/:index accepts duplicate chunks.
  - GET /api/uploads/:id reports completed chunks from disk.
  - POST /api/uploads/:id/complete assembles verified chunks and removes staging data.
  - POST /api/uploads/:id/complete rejects incomplete uploads.
  - POST /api/uploads/:id/complete rejects corrupt chunk files.
  - static/app.js passes node --check.
just nginx-smoke
- Runs upl behind nginx in Docker.
- Uploads a 17 MiB file through nginx.
- Restarts the Rust backend mid-upload, resumes through nginx, completes, and compares SHA-256 hashes.

Manual

These scenarios come from PLAN.md and remain useful for real browser and deployment retests.

Upload a small file in one pass.
Upload a file larger than one chunk.
Kill the browser tab mid-upload and resume.
Restart the Rust server mid-upload and resume.
Interrupt the network and resume.
Pause from the browser controls and resume.
Reload the page and resume from the pending upload list.
In a browser with the File System Access API, resume without reselecting the file after granting read permission.
In a browser without the File System Access API, resume after reselecting the same file.
Retry a duplicate chunk and confirm it is accepted idempotently.
Attempt an invalid chunk index and confirm it is rejected.
Attempt a wrong-size non-final chunk and confirm it is rejected.
Install deploy/nginx/upl.conf.example on the deployment host, add the real TLS certificate and access-control settings, and repeat the resume scenarios through the public nginx URL.
Complete an upload and compare the final file with the source file:

sha256sum source-file data/complete/uploaded-file

2.3 KiB Raw Blame History

Test Scenarios

Automated

Manual

2.3 KiB

Raw Blame History