Remove some PUFFS_USE_NO_OP_PERFORMANCE_HACKS.

They don't seem to actually help the benchmark numbers in a robust way.
This commit is contained in:
Nigel Tao committed 2017-11-02 18:23:03 +11:00
1 parent e5db8233fc
commit 0a7382cfac
3 files changed
+2 -38

No files matched your search

+2 -2
View File
@@ -20,6 +20,8 @@ package cgen
//
// TODO: investigate; delete these hacks (without regressing performance).
// TODO: delete this file.
type nophKey struct {
gCurrFunkCName string
genMethod string
@@ -58,5 +60,3 @@ if (a_src.private_impl.no_op_performance_hacks) {
#endif
`,
}
// puffs_gif__decoder__decode_id
-18
View File
@@ -101,15 +101,6 @@ func (g *gen) writeLoadDerivedVar(b *buffer, name t.ID, typ *a.TypeExpr, header
b.printf("%srptr_%s = %s%s.buf->ptr + %s%s.buf->ri;",
bPrefix, nameStr, aPrefix, nameStr, aPrefix, nameStr)
b.printf("uint64_t len = %s%s.buf->wi - %s%s.buf->ri;", aPrefix, nameStr, aPrefix, nameStr)
if s := noOpPerformanceHacks[nophKey{
gCurrFunkCName: g.currFunk.cName,
genMethod: "writeLoadDerivedVar",
headerFooter: header,
}]; s != "" {
b.writes(s)
}
b.printf("%srend_%s = %srptr_%s + len;", bPrefix, nameStr, bPrefix, nameStr)
b.printf("if (%s%s.private_impl.limit && (%srend_%s > %s%s.private_impl.limit)) {"+
" %srend_%s = %s%s.private_impl.limit; }",
@@ -161,15 +152,6 @@ func (g *gen) writeSaveDerivedVar(b *buffer, name t.ID, typ *a.TypeExpr, footer
b.printf("size_t n = %srptr_%s - (%s%s.buf->ptr + %s%s.buf->ri);",
bPrefix, nameStr, aPrefix, nameStr, aPrefix, nameStr)
b.printf("%s%s.buf->ri += n;", aPrefix, nameStr)
if s := noOpPerformanceHacks[nophKey{
gCurrFunkCName: g.currFunk.cName,
genMethod: "writeSaveDerivedVar",
headerFooter: footer,
}]; s != "" {
b.writes(s)
}
if footer {
b.printf("PUFFS_BASE__IGNORE_POTENTIALLY_UNUSED_VARIABLE(%srend_%s);", bPrefix, nameStr)
}
-18
View File
@@ -1255,16 +1255,6 @@ puffs_gif__status puffs_gif__decoder__decode_id(puffs_gif__decoder* self,
if (a_src.buf) {
size_t n = b_rptr_src - (a_src.buf->ptr + a_src.buf->ri);
a_src.buf->ri += n;
#ifdef PUFFS_USE_NO_OP_PERFORMANCE_HACKS
if (a_src.private_impl.no_op_performance_hacks) {
puffs_base__paired_nulls* pn =
a_src.private_impl.no_op_performance_hacks->noph0;
while (pn && pn->always_null0) {
*((int*)(pn->always_null0)) = 0;
pn = (puffs_base__paired_nulls*)(pn->always_null1);
}
}
#endif
}
puffs_gif__status t_3 = puffs_gif__lzw_decoder__decode(
&self->private_impl.f_lzw, a_dst, v_r);
@@ -1408,14 +1398,6 @@ puffs_gif__status puffs_gif__lzw_decoder__decode(puffs_gif__lzw_decoder* self,
if (a_src.buf) {
b_rptr_src = a_src.buf->ptr + a_src.buf->ri;
uint64_t len = a_src.buf->wi - a_src.buf->ri;
#ifdef PUFFS_USE_NO_OP_PERFORMANCE_HACKS
if (a_src.private_impl.no_op_performance_hacks) {
if (a_src.private_impl.no_op_performance_hacks->noph1 &&
(len > a_src.private_impl.no_op_performance_hacks->noph1)) {
len = a_src.private_impl.no_op_performance_hacks->noph1;
}
}
#endif
b_rend_src = b_rptr_src + len;
if (a_src.private_impl.limit && (b_rend_src > a_src.private_impl.limit)) {
b_rend_src = a_src.private_impl.limit;