Have tests let the initializers memset to zero

This commit is contained in:
Nigel Tao committed 2019-02-10 14:08:21 +11:00
1 parent 0ab52c6204
commit 37a5ead3b7
7 files changed
+109 -122

No files matched your search

+11 -11
View File
@@ -129,11 +129,11 @@ const char* test_wuffs_adler32_golden() {
int j;
for (j = 0; j < 2; j++) {
wuffs_adler32__hasher checksum = ((wuffs_adler32__hasher){});
status = wuffs_adler32__hasher__check_wuffs_version(
&checksum, sizeof checksum, WUFFS_VERSION);
wuffs_adler32__hasher checksum;
status = wuffs_adler32__hasher__initialize(&checksum, sizeof checksum,
WUFFS_VERSION, 0);
if (status) {
RETURN_FAIL("check_wuffs_version: \"%s\"", status);
RETURN_FAIL("initialize: \"%s\"", status);
}
uint32_t got = 0;
@@ -191,11 +191,11 @@ const char* test_wuffs_adler32_pi() {
int i;
for (i = 0; i < 64; i++) {
wuffs_adler32__hasher checksum = ((wuffs_adler32__hasher){});
const char* status = wuffs_adler32__hasher__check_wuffs_version(
&checksum, sizeof checksum, WUFFS_VERSION);
wuffs_adler32__hasher checksum;
const char* status = wuffs_adler32__hasher__initialize(
&checksum, sizeof checksum, WUFFS_VERSION, 0);
if (status) {
RETURN_FAIL("check_wuffs_version: \"%s\"", status);
RETURN_FAIL("initialize: \"%s\"", status);
}
uint32_t got =
wuffs_adler32__hasher__update(&checksum, ((wuffs_base__slice_u8){
@@ -222,9 +222,9 @@ const char* wuffs_bench_adler32(wuffs_base__io_buffer* dst,
if (rlimit) {
len = wuffs_base__u64__min(len, rlimit);
}
wuffs_adler32__hasher checksum = ((wuffs_adler32__hasher){});
const char* status = wuffs_adler32__hasher__check_wuffs_version(
&checksum, sizeof checksum, WUFFS_VERSION);
wuffs_adler32__hasher checksum;
const char* status = wuffs_adler32__hasher__initialize(
&checksum, sizeof checksum, WUFFS_VERSION, 0);
if (status) {
return status;
}
+11 -11
View File
@@ -129,11 +129,11 @@ const char* test_wuffs_crc32_ieee_golden() {
int j;
for (j = 0; j < 2; j++) {
wuffs_crc32__ieee_hasher checksum = ((wuffs_crc32__ieee_hasher){});
status = wuffs_crc32__ieee_hasher__check_wuffs_version(
&checksum, sizeof checksum, WUFFS_VERSION);
wuffs_crc32__ieee_hasher checksum;
status = wuffs_crc32__ieee_hasher__initialize(&checksum, sizeof checksum,
WUFFS_VERSION, 0);
if (status) {
RETURN_FAIL("check_wuffs_version: \"%s\"", status);
RETURN_FAIL("initialize: \"%s\"", status);
}
uint32_t got = 0;
@@ -212,11 +212,11 @@ const char* do_test_xxxxx_crc32_ieee_pi(bool mimic) {
got ^= 0xFFFFFFFF;
} else {
wuffs_crc32__ieee_hasher checksum = ((wuffs_crc32__ieee_hasher){});
const char* status = wuffs_crc32__ieee_hasher__check_wuffs_version(
&checksum, sizeof checksum, WUFFS_VERSION);
wuffs_crc32__ieee_hasher checksum;
const char* status = wuffs_crc32__ieee_hasher__initialize(
&checksum, sizeof checksum, WUFFS_VERSION, 0);
if (status) {
RETURN_FAIL("check_wuffs_version: \"%s\"", status);
RETURN_FAIL("initialize: \"%s\"", status);
}
got = wuffs_crc32__ieee_hasher__update(&checksum, data);
}
@@ -257,9 +257,9 @@ const char* wuffs_bench_crc32_ieee(wuffs_base__io_buffer* dst,
if (rlimit) {
len = wuffs_base__u64__min(len, rlimit);
}
wuffs_crc32__ieee_hasher checksum = ((wuffs_crc32__ieee_hasher){});
const char* status = wuffs_crc32__ieee_hasher__check_wuffs_version(
&checksum, sizeof checksum, WUFFS_VERSION);
wuffs_crc32__ieee_hasher checksum;
const char* status = wuffs_crc32__ieee_hasher__initialize(
&checksum, sizeof checksum, WUFFS_VERSION, 0);
if (status) {
return status;
}
+20 -20
View File
@@ -139,11 +139,11 @@ const char* wuffs_deflate_decode(wuffs_base__io_buffer* dst,
wuffs_base__io_buffer* src,
uint64_t wlimit,
uint64_t rlimit) {
wuffs_deflate__decoder dec = ((wuffs_deflate__decoder){});
const char* status = wuffs_deflate__decoder__check_wuffs_version(
&dec, sizeof dec, WUFFS_VERSION);
wuffs_deflate__decoder dec;
const char* status =
wuffs_deflate__decoder__initialize(&dec, sizeof dec, WUFFS_VERSION, 0);
if (status) {
RETURN_FAIL("check_wuffs_version: \"%s\"", status);
RETURN_FAIL("initialize: \"%s\"", status);
}
while (true) {
@@ -266,11 +266,11 @@ const char* test_wuffs_deflate_decode_split_src() {
}
got.meta.wi = 0;
wuffs_deflate__decoder dec = ((wuffs_deflate__decoder){});
status = wuffs_deflate__decoder__check_wuffs_version(&dec, sizeof dec,
WUFFS_VERSION);
wuffs_deflate__decoder dec;
status =
wuffs_deflate__decoder__initialize(&dec, sizeof dec, WUFFS_VERSION, 0);
if (status) {
RETURN_FAIL("check_wuffs_version: \"%s\"", status);
RETURN_FAIL("initialize: \"%s\"", status);
}
src.meta.closed = false;
@@ -361,11 +361,11 @@ const char* test_wuffs_deflate_history_full() {
const int full_history_size = 0x8000;
int i;
for (i = -2; i <= +2; i++) {
wuffs_deflate__decoder dec = ((wuffs_deflate__decoder){});
status = wuffs_deflate__decoder__check_wuffs_version(&dec, sizeof dec,
WUFFS_VERSION);
wuffs_deflate__decoder dec;
status =
wuffs_deflate__decoder__initialize(&dec, sizeof dec, WUFFS_VERSION, 0);
if (status) {
RETURN_FAIL("check_wuffs_version: \"%s\"", status);
RETURN_FAIL("initialize: \"%s\"", status);
}
status = do_test_wuffs_deflate_history(
@@ -439,11 +439,11 @@ const char* test_wuffs_deflate_history_partial() {
const char* fragment = "3.14";
const uint32_t fragment_length = 4;
wuffs_deflate__decoder dec = ((wuffs_deflate__decoder){});
status = wuffs_deflate__decoder__check_wuffs_version(&dec, sizeof dec,
WUFFS_VERSION);
wuffs_deflate__decoder dec;
status =
wuffs_deflate__decoder__initialize(&dec, sizeof dec, WUFFS_VERSION, 0);
if (status) {
RETURN_FAIL("check_wuffs_version: \"%s\"", status);
RETURN_FAIL("initialize: \"%s\"", status);
}
status = do_test_wuffs_deflate_history(
@@ -526,11 +526,11 @@ const char* test_wuffs_deflate_table_redirect() {
// 1st is the key in the first level table (9 bits).
// 2nd is the key in the second level table (variable bits).
wuffs_deflate__decoder dec = ((wuffs_deflate__decoder){});
const char* status = wuffs_deflate__decoder__check_wuffs_version(
&dec, sizeof dec, WUFFS_VERSION);
wuffs_deflate__decoder dec;
const char* status =
wuffs_deflate__decoder__initialize(&dec, sizeof dec, WUFFS_VERSION, 0);
if (status) {
RETURN_FAIL("check_wuffs_version: \"%s\"", status);
RETURN_FAIL("initialize: \"%s\"", status);
}
int i;
+43 -54
View File
@@ -84,9 +84,9 @@ const char* test_basic_bad_receiver() {
const char* test_basic_bad_sizeof_receiver() {
CHECK_FOCUS(__func__);
wuffs_gif__decoder dec = ((wuffs_gif__decoder){});
wuffs_gif__decoder dec;
const char* status =
wuffs_gif__decoder__check_wuffs_version(&dec, 0, WUFFS_VERSION);
wuffs_gif__decoder__initialize(&dec, 0, WUFFS_VERSION, 0);
if (status != wuffs_base__error__bad_sizeof_receiver) {
RETURN_FAIL("decode_image_config: got \"%s\", want \"%s\"", status,
wuffs_base__error__bad_sizeof_receiver);
@@ -96,9 +96,9 @@ const char* test_basic_bad_sizeof_receiver() {
const char* test_basic_bad_wuffs_version() {
CHECK_FOCUS(__func__);
wuffs_gif__decoder dec = ((wuffs_gif__decoder){});
const char* status = wuffs_gif__decoder__check_wuffs_version(
&dec, sizeof dec, WUFFS_VERSION ^ 0x123456789ABC);
wuffs_gif__decoder dec;
const char* status = wuffs_gif__decoder__initialize(
&dec, sizeof dec, WUFFS_VERSION ^ 0x123456789ABC, 0);
if (status != wuffs_base__error__bad_wuffs_version) {
RETURN_FAIL("decode_image_config: got \"%s\", want \"%s\"", status,
wuffs_base__error__bad_wuffs_version);
@@ -170,11 +170,11 @@ const char* test_basic_status_used_package() {
const char* test_basic_sub_struct_initializer() {
CHECK_FOCUS(__func__);
wuffs_gif__decoder dec = ((wuffs_gif__decoder){});
wuffs_gif__decoder dec;
const char* status =
wuffs_gif__decoder__check_wuffs_version(&dec, sizeof dec, WUFFS_VERSION);
wuffs_gif__decoder__initialize(&dec, sizeof dec, WUFFS_VERSION, 0);
if (status) {
RETURN_FAIL("check_wuffs_version: \"%s\"", status);
RETURN_FAIL("initialize: \"%s\"", status);
}
if (dec.private_impl.magic != WUFFS_BASE__MAGIC) {
RETURN_FAIL("outer magic: got %" PRIu32 ", want %" PRIu32 "",
@@ -192,9 +192,9 @@ const char* test_basic_sub_struct_initializer() {
const char* wuffs_gif_decode(wuffs_base__io_buffer* dst,
wuffs_base__pixel_format pixfmt,
wuffs_base__io_buffer* src) {
wuffs_gif__decoder dec = ((wuffs_gif__decoder){});
wuffs_gif__decoder dec;
const char* status =
wuffs_gif__decoder__check_wuffs_version(&dec, sizeof dec, WUFFS_VERSION);
wuffs_gif__decoder__initialize(&dec, sizeof dec, WUFFS_VERSION, 0);
if (status) {
return status;
}
@@ -259,11 +259,10 @@ const char* do_test_wuffs_gif_decode(const char* filename,
return status;
}
wuffs_gif__decoder dec = ((wuffs_gif__decoder){});
status =
wuffs_gif__decoder__check_wuffs_version(&dec, sizeof dec, WUFFS_VERSION);
wuffs_gif__decoder dec;
status = wuffs_gif__decoder__initialize(&dec, sizeof dec, WUFFS_VERSION, 0);
if (status) {
RETURN_FAIL("check_wuffs_version: \"%s\"", status);
RETURN_FAIL("initialize: \"%s\"", status);
}
wuffs_base__frame_config fc = ((wuffs_base__frame_config){});
@@ -474,11 +473,10 @@ const char* test_wuffs_gif_call_interleaved() {
return status;
}
wuffs_gif__decoder dec = ((wuffs_gif__decoder){});
status =
wuffs_gif__decoder__check_wuffs_version(&dec, sizeof dec, WUFFS_VERSION);
wuffs_gif__decoder dec;
status = wuffs_gif__decoder__initialize(&dec, sizeof dec, WUFFS_VERSION, 0);
if (status) {
RETURN_FAIL("check_wuffs_version: \"%s\"", status);
RETURN_FAIL("initialize: \"%s\"", status);
}
{
@@ -521,11 +519,10 @@ const char* test_wuffs_gif_call_sequence() {
return status;
}
wuffs_gif__decoder dec = ((wuffs_gif__decoder){});
status =
wuffs_gif__decoder__check_wuffs_version(&dec, sizeof dec, WUFFS_VERSION);
wuffs_gif__decoder dec;
status = wuffs_gif__decoder__initialize(&dec, sizeof dec, WUFFS_VERSION, 0);
if (status) {
RETURN_FAIL("check_wuffs_version: \"%s\"", status);
RETURN_FAIL("initialize: \"%s\"", status);
}
wuffs_base__io_reader src_reader = wuffs_base__io_buffer__reader(&src);
@@ -557,11 +554,10 @@ const char* do_test_wuffs_gif_decode_animated(
return status;
}
wuffs_gif__decoder dec = ((wuffs_gif__decoder){});
status =
wuffs_gif__decoder__check_wuffs_version(&dec, sizeof dec, WUFFS_VERSION);
wuffs_gif__decoder dec;
status = wuffs_gif__decoder__initialize(&dec, sizeof dec, WUFFS_VERSION, 0);
if (status) {
RETURN_FAIL("check_wuffs_version: \"%s\"", status);
RETURN_FAIL("initialize: \"%s\"", status);
}
wuffs_base__image_config ic = ((wuffs_base__image_config){});
@@ -681,11 +677,10 @@ const char* test_wuffs_gif_decode_frame_out_of_bounds() {
return status;
}
wuffs_gif__decoder dec = ((wuffs_gif__decoder){});
status =
wuffs_gif__decoder__check_wuffs_version(&dec, sizeof dec, WUFFS_VERSION);
wuffs_gif__decoder dec;
status = wuffs_gif__decoder__initialize(&dec, sizeof dec, WUFFS_VERSION, 0);
if (status) {
RETURN_FAIL("check_wuffs_version: \"%s\"", status);
RETURN_FAIL("initialize: \"%s\"", status);
}
wuffs_base__image_config ic = ((wuffs_base__image_config){});
wuffs_base__io_reader src_reader = wuffs_base__io_buffer__reader(&src);
@@ -861,11 +856,10 @@ const char* test_wuffs_gif_decode_input_is_a_png() {
return status;
}
wuffs_gif__decoder dec = ((wuffs_gif__decoder){});
status =
wuffs_gif__decoder__check_wuffs_version(&dec, sizeof dec, WUFFS_VERSION);
wuffs_gif__decoder dec;
status = wuffs_gif__decoder__initialize(&dec, sizeof dec, WUFFS_VERSION, 0);
if (status) {
RETURN_FAIL("check_wuffs_version: \"%s\"", status);
RETURN_FAIL("initialize: \"%s\"", status);
}
wuffs_base__image_config ic = ((wuffs_base__image_config){});
wuffs_base__io_reader src_reader = wuffs_base__io_buffer__reader(&src);
@@ -896,11 +890,10 @@ const char* test_wuffs_gif_decode_missing_two_src_bytes() {
}
src.meta.wi -= 2;
wuffs_gif__decoder dec = ((wuffs_gif__decoder){});
status =
wuffs_gif__decoder__check_wuffs_version(&dec, sizeof dec, WUFFS_VERSION);
wuffs_gif__decoder dec;
status = wuffs_gif__decoder__initialize(&dec, sizeof dec, WUFFS_VERSION, 0);
if (status) {
RETURN_FAIL("check_wuffs_version: \"%s\"", status);
RETURN_FAIL("initialize: \"%s\"", status);
}
wuffs_base__image_config ic = ((wuffs_base__image_config){});
@@ -944,11 +937,10 @@ const char* test_wuffs_gif_decode_multiple_loop_counts() {
return status;
}
wuffs_gif__decoder dec = ((wuffs_gif__decoder){});
status =
wuffs_gif__decoder__check_wuffs_version(&dec, sizeof dec, WUFFS_VERSION);
wuffs_gif__decoder dec;
status = wuffs_gif__decoder__initialize(&dec, sizeof dec, WUFFS_VERSION, 0);
if (status) {
RETURN_FAIL("check_wuffs_version: \"%s\"", status);
RETURN_FAIL("initialize: \"%s\"", status);
}
wuffs_base__image_config ic = ((wuffs_base__image_config){});
wuffs_base__io_reader src_reader = wuffs_base__io_buffer__reader(&src);
@@ -1011,11 +1003,10 @@ const char* test_wuffs_gif_frame_dirty_rect() {
return status;
}
wuffs_gif__decoder dec = ((wuffs_gif__decoder){});
status =
wuffs_gif__decoder__check_wuffs_version(&dec, sizeof dec, WUFFS_VERSION);
wuffs_gif__decoder dec;
status = wuffs_gif__decoder__initialize(&dec, sizeof dec, WUFFS_VERSION, 0);
if (status) {
RETURN_FAIL("check_wuffs_version: \"%s\"", status);
RETURN_FAIL("initialize: \"%s\"", status);
}
wuffs_base__image_config ic = ((wuffs_base__image_config){});
@@ -1075,11 +1066,10 @@ const char* do_test_wuffs_gif_num_decoded(bool frame_config) {
return status;
}
wuffs_gif__decoder dec = ((wuffs_gif__decoder){});
status =
wuffs_gif__decoder__check_wuffs_version(&dec, sizeof dec, WUFFS_VERSION);
wuffs_gif__decoder dec;
status = wuffs_gif__decoder__initialize(&dec, sizeof dec, WUFFS_VERSION, 0);
if (status) {
RETURN_FAIL("check_wuffs_version: \"%s\"", status);
RETURN_FAIL("initialize: \"%s\"", status);
}
wuffs_base__io_reader src_reader = wuffs_base__io_buffer__reader(&src);
@@ -1156,11 +1146,10 @@ const char* do_test_wuffs_gif_io_position(bool chunked) {
return status;
}
wuffs_gif__decoder dec = ((wuffs_gif__decoder){});
status =
wuffs_gif__decoder__check_wuffs_version(&dec, sizeof dec, WUFFS_VERSION);
wuffs_gif__decoder dec;
status = wuffs_gif__decoder__initialize(&dec, sizeof dec, WUFFS_VERSION, 0);
if (status) {
RETURN_FAIL("check_wuffs_version: \"%s\"", status);
RETURN_FAIL("initialize: \"%s\"", status);
}
wuffs_base__io_reader src_reader = wuffs_base__io_buffer__reader(&src);
+6 -6
View File
@@ -87,9 +87,9 @@ const char* wuffs_gzip_decode(wuffs_base__io_buffer* dst,
wuffs_base__io_buffer* src,
uint64_t wlimit,
uint64_t rlimit) {
wuffs_gzip__decoder dec = ((wuffs_gzip__decoder){});
wuffs_gzip__decoder dec;
const char* status =
wuffs_gzip__decoder__check_wuffs_version(&dec, sizeof dec, WUFFS_VERSION);
wuffs_gzip__decoder__initialize(&dec, sizeof dec, WUFFS_VERSION, 0);
if (status) {
return status;
}
@@ -139,11 +139,11 @@ const char* do_test_wuffs_gzip_checksum(bool ignore_checksum,
int end_limit;
for (end_limit = 0; end_limit < 10; end_limit++) {
wuffs_gzip__decoder dec = ((wuffs_gzip__decoder){});
status = wuffs_gzip__decoder__check_wuffs_version(&dec, sizeof dec,
WUFFS_VERSION);
wuffs_gzip__decoder dec;
status =
wuffs_gzip__decoder__initialize(&dec, sizeof dec, WUFFS_VERSION, 0);
if (status) {
RETURN_FAIL("check_wuffs_version: \"%s\"", status);
RETURN_FAIL("initialize: \"%s\"", status);
}
wuffs_gzip__decoder__set_ignore_checksum(&dec, ignore_checksum);
got.meta.wi = 0;
+12 -14
View File
@@ -107,11 +107,10 @@ const char* do_test_wuffs_lzw_decode(const char* src_filename,
(int)(want_size));
}
wuffs_lzw__decoder dec = ((wuffs_lzw__decoder){});
status =
wuffs_lzw__decoder__check_wuffs_version(&dec, sizeof dec, WUFFS_VERSION);
wuffs_lzw__decoder dec;
status = wuffs_lzw__decoder__initialize(&dec, sizeof dec, WUFFS_VERSION, 0);
if (status) {
RETURN_FAIL("check_wuffs_version: \"%s\"", status);
RETURN_FAIL("initialize: \"%s\"", status);
}
wuffs_lzw__decoder__set_literal_width(&dec, literal_width);
int num_iters = 0;
@@ -224,11 +223,11 @@ const char* test_wuffs_lzw_decode_output_bad() {
src.data.ptr[2] = 0x43;
src.data.ptr[3] = 0xFF;
wuffs_lzw__decoder dec = ((wuffs_lzw__decoder){});
wuffs_lzw__decoder dec;
const char* status =
wuffs_lzw__decoder__check_wuffs_version(&dec, sizeof dec, WUFFS_VERSION);
wuffs_lzw__decoder__initialize(&dec, sizeof dec, WUFFS_VERSION, 0);
if (status) {
RETURN_FAIL("check_wuffs_version: \"%s\"", status);
RETURN_FAIL("initialize: \"%s\"", status);
}
wuffs_lzw__decoder__set_literal_width(&dec, 7);
@@ -268,11 +267,11 @@ const char* test_wuffs_lzw_decode_output_empty() {
src.data.ptr[0] = 0x01;
src.data.ptr[1] = 0x01;
wuffs_lzw__decoder dec = ((wuffs_lzw__decoder){});
wuffs_lzw__decoder dec;
const char* status =
wuffs_lzw__decoder__check_wuffs_version(&dec, sizeof dec, WUFFS_VERSION);
wuffs_lzw__decoder__initialize(&dec, sizeof dec, WUFFS_VERSION, 0);
if (status) {
RETURN_FAIL("check_wuffs_version: \"%s\"", status);
RETURN_FAIL("initialize: \"%s\"", status);
}
wuffs_lzw__decoder__set_literal_width(&dec, 8);
@@ -325,11 +324,10 @@ const char* do_bench_wuffs_lzw_decode(const char* filename,
for (i = 0; i < iters; i++) {
got.meta.wi = 0;
src.meta.ri = 1; // Skip the literal width.
wuffs_lzw__decoder dec = ((wuffs_lzw__decoder){});
status = wuffs_lzw__decoder__check_wuffs_version(&dec, sizeof dec,
WUFFS_VERSION);
wuffs_lzw__decoder dec;
status = wuffs_lzw__decoder__initialize(&dec, sizeof dec, WUFFS_VERSION, 0);
if (status) {
RETURN_FAIL("check_wuffs_version: \"%s\"", status);
RETURN_FAIL("initialize: \"%s\"", status);
}
status = wuffs_lzw__decoder__decode_io_writer(&dec, got_writer, src_reader,
global_work_slice);
+6 -6
View File
@@ -87,9 +87,9 @@ const char* wuffs_zlib_decode(wuffs_base__io_buffer* dst,
wuffs_base__io_buffer* src,
uint64_t wlimit,
uint64_t rlimit) {
wuffs_zlib__decoder dec = ((wuffs_zlib__decoder){});
wuffs_zlib__decoder dec;
const char* status =
wuffs_zlib__decoder__check_wuffs_version(&dec, sizeof dec, WUFFS_VERSION);
wuffs_zlib__decoder__initialize(&dec, sizeof dec, WUFFS_VERSION, 0);
if (status) {
return status;
}
@@ -138,11 +138,11 @@ const char* do_test_wuffs_zlib_checksum(bool ignore_checksum,
int end_limit;
for (end_limit = 0; end_limit < 10; end_limit++) {
wuffs_zlib__decoder dec = ((wuffs_zlib__decoder){});
status = wuffs_zlib__decoder__check_wuffs_version(&dec, sizeof dec,
WUFFS_VERSION);
wuffs_zlib__decoder dec;
status =
wuffs_zlib__decoder__initialize(&dec, sizeof dec, WUFFS_VERSION, 0);
if (status) {
RETURN_FAIL("check_wuffs_version: \"%s\"", status);
RETURN_FAIL("initialize: \"%s\"", status);
}
wuffs_zlib__decoder__set_ignore_checksum(&dec, ignore_checksum);
got.meta.wi = 0;