Don't add "lhs == rhs" as a fact if impure.

This commit is contained in:
Nigel Tao committed 2017-06-22 13:57:50 +10:00
1 parent cc3c214f1e
commit 657560d22b
2 files changed
+7 -3

No files matched your search

+2
View File
@@ -202,6 +202,7 @@ const MaxExprDepth = 255
type Expr Node
func (n *Expr) Node() *Node { return (*Node)(n) }
func (n *Expr) Pure() bool { return n.flags&FlagsImpure == 0 }
func (n *Expr) Impure() bool { return n.flags&FlagsImpure != 0 }
func (n *Expr) Suspendible() bool { return n.flags&FlagsSuspendible != 0 }
func (n *Expr) CallImpure() bool { return n.flags&FlagsCallImpure != 0 }
@@ -542,6 +543,7 @@ const MaxBodyDepth = 255
type Func Node
func (n *Func) Node() *Node { return (*Node)(n) }
func (n *Func) Pure() bool { return n.flags&FlagsImpure == 0 }
func (n *Func) Impure() bool { return n.flags&FlagsImpure != 0 }
func (n *Func) Suspendible() bool { return n.flags&FlagsSuspendible != 0 }
func (n *Func) Public() bool { return n.flags&FlagsPublic != 0 }
+5 -3
View File
@@ -273,9 +273,11 @@ func (q *checker) bcheckAssignment(lhs *a.Expr, op t.ID, rhs *a.Expr) error {
return x
})
o := a.NewExpr(a.FlagsTypeChecked, t.IDXBinaryEqEq, 0, lhs.Node(), nil, rhs.Node(), nil)
o.SetMType(lhs.MType())
q.facts.appendFact(o)
if lhs.Pure() && rhs.Pure() {
o := a.NewExpr(a.FlagsTypeChecked, t.IDXBinaryEqEq, 0, lhs.Node(), nil, rhs.Node(), nil)
o.SetMType(lhs.MType())
q.facts.appendFact(o)
}
} else {
// Update any facts involving lhs.
q.facts.update(func(x *a.Expr) *a.Expr {