mirror of
https://github.com/ddidderr/wuffs.git
synced 2026-11-18 00:32:11 +01:00
base: skip bulk load/save on short slice length
This is about semantics (being easier to reason about if transforming between u32 and u8 and the u8 slice length is short and not a multiple of 4). It's not an optimization per se, but for the record, it does have significant performance impact: name old speed new speed delta wuffs_jpeg_decode_19k_8bpp/clang11 369MB/s ± 0% 376MB/s ± 0% +1.97% (p=0.008 n=5+5) wuffs_jpeg_decode_30k_24bpp_progressive/clang11 309MB/s ± 0% 338MB/s ± 0% +9.29% (p=0.008 n=5+5) wuffs_jpeg_decode_30k_24bpp_sequential/clang11 1.00GB/s ± 0% 1.01GB/s ± 0% +1.31% (p=0.008 n=5+5) wuffs_jpeg_decode_77k_24bpp/clang11 827MB/s ± 0% 841MB/s ± 0% +1.76% (p=0.008 n=5+5) wuffs_jpeg_decode_552k_24bpp_420/clang11 897MB/s ± 0% 913MB/s ± 0% +1.86% (p=0.008 n=5+5) wuffs_jpeg_decode_552k_24bpp_444/clang11 1.10GB/s ± 0% 1.11GB/s ± 0% +0.11% (p=0.024 n=5+5) wuffs_jpeg_decode_4002k_24bpp/clang11 900MB/s ± 0% 920MB/s ± 0% +2.20% (p=0.008 n=5+5) wuffs_jpeg_decode_19k_8bpp/gcc10 369MB/s ± 0% 349MB/s ± 0% -5.45% (p=0.008 n=5+5) wuffs_jpeg_decode_30k_24bpp_progressive/gcc10 283MB/s ± 0% 328MB/s ± 0% +15.76% (p=0.008 n=5+5) wuffs_jpeg_decode_30k_24bpp_sequential/gcc10 945MB/s ± 0% 925MB/s ± 0% -2.12% (p=0.008 n=5+5) wuffs_jpeg_decode_77k_24bpp/gcc10 769MB/s ± 0% 732MB/s ± 0% -4.88% (p=0.008 n=5+5) wuffs_jpeg_decode_552k_24bpp_420/gcc10 842MB/s ± 0% 798MB/s ± 0% -5.25% (p=0.008 n=5+5) wuffs_jpeg_decode_552k_24bpp_444/gcc10 1.01GB/s ± 0% 0.96GB/s ± 0% -4.77% (p=0.008 n=5+5) wuffs_jpeg_decode_4002k_24bpp/gcc10 848MB/s ± 0% 806MB/s ± 0% -4.96% (p=0.008 n=5+5)
This commit is contained in:
1 parent
14a8bd0feb
commit
748e44fe71
2 files changed
+4
-16
No files matched your search
@@ -221,10 +221,7 @@ static inline wuffs_base__empty_struct //
|
||||
wuffs_base__bulk_load_host_endian(void* ptr,
|
||||
size_t len,
|
||||
wuffs_base__slice_u8 src) {
|
||||
if (len > src.len) {
|
||||
len = src.len;
|
||||
}
|
||||
if (len) {
|
||||
if (len && (len <= src.len)) {
|
||||
memmove(ptr, src.ptr, len);
|
||||
}
|
||||
return wuffs_base__make_empty_struct();
|
||||
@@ -242,10 +239,7 @@ static inline wuffs_base__empty_struct //
|
||||
wuffs_base__bulk_save_host_endian(void* ptr,
|
||||
size_t len,
|
||||
wuffs_base__slice_u8 dst) {
|
||||
if (len > dst.len) {
|
||||
len = dst.len;
|
||||
}
|
||||
if (len) {
|
||||
if (len && (len <= dst.len)) {
|
||||
memmove(dst.ptr, ptr, len);
|
||||
}
|
||||
return wuffs_base__make_empty_struct();
|
||||
|
||||
@@ -12787,10 +12787,7 @@ static inline wuffs_base__empty_struct //
|
||||
wuffs_base__bulk_load_host_endian(void* ptr,
|
||||
size_t len,
|
||||
wuffs_base__slice_u8 src) {
|
||||
if (len > src.len) {
|
||||
len = src.len;
|
||||
}
|
||||
if (len) {
|
||||
if (len && (len <= src.len)) {
|
||||
memmove(ptr, src.ptr, len);
|
||||
}
|
||||
return wuffs_base__make_empty_struct();
|
||||
@@ -12808,10 +12805,7 @@ static inline wuffs_base__empty_struct //
|
||||
wuffs_base__bulk_save_host_endian(void* ptr,
|
||||
size_t len,
|
||||
wuffs_base__slice_u8 dst) {
|
||||
if (len > dst.len) {
|
||||
len = dst.len;
|
||||
}
|
||||
if (len) {
|
||||
if (len && (len <= dst.len)) {
|
||||
memmove(dst.ptr, ptr, len);
|
||||
}
|
||||
return wuffs_base__make_empty_struct();
|
||||
|
||||
Reference in new issue
Block a user