Simplify the gen.writeBuiltinQuestionCall caller

This commit is contained in:
Nigel Tao committed 2018-12-27 17:06:59 +11:00
1 parent 1b3f800416
commit 796c8ccc30
2 files changed
+3 -7

No files matched your search

+1 -1
View File
@@ -539,7 +539,7 @@ func (g *gen) writeArgs(b *buffer, args []*a.Node, depth uint32) error {
func (g *gen) writeBuiltinQuestionCall(b *buffer, n *a.Expr, depth uint32) error {
// TODO: also handle (or reject??) being on the RHS of an =? operator.
if n.Operator() != t.IDOpenParen {
if (n.Operator() != t.IDOpenParen) || (!n.Effect().Coroutine()) {
return errNoSuchBuiltin
}
method := n.LHS().AsExpr()
+2 -6
View File
@@ -111,12 +111,8 @@ func (g *gen) writeStatementAssign(b *buffer, op t.ID, lhs *a.Expr, rhs *a.Expr,
}
func (g *gen) writeStatementAssign0(b *buffer, op t.ID, lhs *a.Expr, rhs *a.Expr) error {
if rhs.Effect().Coroutine() {
if err := g.writeBuiltinQuestionCall(b, rhs, 0); err == nil {
return nil
} else if err != errNoSuchBuiltin {
return err
}
if err := g.writeBuiltinQuestionCall(b, rhs, 0); err != errNoSuchBuiltin {
return err
}
if (lhs == nil) || rhs.Effect().Coroutine() {