Temporary code to continue this.lzw.decode calls.

This is a hard-coded, short term fix so that GIF decoding works
end-to-end. The long term fix is to have some principled way of
responding to non-fatal status codes such as "short read".
This commit is contained in:
Nigel Tao committed 2017-06-23 15:46:08 +10:00
1 parent 8ad82f5e1f
commit 8fe438d0b4
3 files changed
+4 -4

No files matched your search

+2 -1
View File
@@ -1214,7 +1214,8 @@ func (g *gen) writeCallSuspendibles(n *a.Expr, depth uint32) error {
} else if isDecode(g.tm, n) {
g.printf("status = puffs_%s_lzw_decoder_decode(&self->private_impl.f_lzw, %sdst, %s%s);\n",
g.pkgName, aPrefix, vPrefix, n.Args()[1].Arg().Value().String(g.tm))
g.writes("if (status) { return status; }\n")
// TODO: be principled with "if (status&1)" vs "if (status)".
g.writes("if (status&1) { return status; }\n")
return nil
} else {
+1 -1
View File
@@ -787,7 +787,7 @@ puffs_gif_status puffs_gif_decoder_decode_id(puffs_gif_decoder* self,
PUFFS_COROUTINE_STATE(4);
status = puffs_gif_lzw_decoder_decode(&self->private_impl.f_lzw, a_dst,
v_lzw_src);
if (status) {
if (status & 1) {
return status;
}
}
+1 -2
View File
@@ -347,8 +347,7 @@ void test_gif_decode_input_is_a_gif() {
test_gif_decode_input_is_a_xxx("../../testdata/bricks-dither.gif",
"../../testdata/bricks-dither.palette",
"../../testdata/bricks-dither.indexes",
// TODO: puffs_gif_status_ok);
puffs_gif_status_short_read);
puffs_gif_status_ok);
}
void test_gif_decode_input_is_a_png() {