Inline bcheckAssignment1

This commit is contained in:
Nigel Tao committed 2018-07-07 18:18:15 +10:00
1 parent e0cbd2a69e
commit dcaa2bb085
1 file changed
+4 -8
+4 -8
View File
@@ -348,7 +348,10 @@ func (q *checker) bcheckAssert(n *a.Assert) error {
}
func (q *checker) bcheckAssignment(lhs *a.Expr, op t.ID, rhs *a.Expr) error {
if err := q.bcheckAssignment1(lhs, op, rhs); err != nil {
if _, err := q.bcheckExpr(lhs, 0); err != nil {
return err
}
if err := q.bcheckAssignment2(lhs, lhs.MType(), op, rhs); err != nil {
return err
}
// TODO: check lhs and rhs are pure expressions.
@@ -415,13 +418,6 @@ func (q *checker) bcheckAssignment(lhs *a.Expr, op t.ID, rhs *a.Expr) error {
return nil
}
func (q *checker) bcheckAssignment1(lhs *a.Expr, op t.ID, rhs *a.Expr) error {
if _, err := q.bcheckExpr(lhs, 0); err != nil {
return err
}
return q.bcheckAssignment2(lhs, lhs.MType(), op, rhs)
}
func (q *checker) bcheckAssignment2(lhs *a.Expr, lTyp *a.TypeExpr, op t.ID, rhs *a.Expr) error {
if lhs == nil && op != t.IDEq {
return fmt.Errorf("check: internal error: missing LHS for op key 0x%02X", op)