Delete obsolete set_literal_width special case

This commit is contained in:
Nigel Tao committed 2018-05-12 15:55:53 +10:00
1 parent a8767f285b
commit eb377b9684
2 files changed
-35

No files matched your search

-15
View File
@@ -816,21 +816,6 @@ func (q *checker) bcheckExprOther(n *a.Expr, depth uint32) (*big.Int, *big.Int,
if _, _, err := q.bcheckExpr(lhs, depth); err != nil {
return nil, nil, err
}
// TODO: delete this hack that only matches "foo.set_literal_width(etc)".
if isThatMethod(q.tm, n, q.tm.ByName("set_literal_width"), 1) {
a := n.Args()[0].Arg().Value()
aMin, aMax, err := q.bcheckExpr(a, depth)
if err != nil {
return nil, nil, err
}
if aMin.Cmp(big.NewInt(2)) < 0 || aMax.Cmp(big.NewInt(8)) > 0 {
return nil, nil, fmt.Errorf("check: %q not in range [2..8]", a.Str(q.tm))
}
// TODO: should return be break?
return nil, nil, nil
}
if err := q.bcheckExprCall(n, depth); err != nil {
return nil, nil, err
}
-20
View File
@@ -614,26 +614,6 @@ func (q *checker) tcheckExprCall(n *a.Expr, depth uint32) error {
return nil
}
// isThatMethod matches foo.methodName(etc) where etc has nArgs elements.
func isThatMethod(tm *t.Map, n *a.Expr, methodName t.ID, nArgs int) bool {
if k := n.Operator(); k != t.IDOpenParen && k != t.IDTry {
return false
}
if len(n.Args()) != nArgs {
return false
}
n = n.LHS().Expr()
if n.Operator() != t.IDDot || n.Ident() != methodName {
return false
}
n = n.LHS().Expr()
if n.Operator() == t.IDDot &&
(n.Ident() == tm.ByName("src") || n.Ident() == tm.ByName("dst")) {
return false
}
return true
}
func (q *checker) tcheckDot(n *a.Expr, depth uint32) error {
lhs := n.LHS().Expr()
if err := q.tcheckExpr(lhs, depth); err != nil {