Commit Graph
117 Commits
Author SHA1 Message Date
Nigel Tao ef5fc86f8a Allow "if true" and "if false" 2019-01-06 20:28:33 +11:00
Nigel Tao 1ea32b3745 Remove the !? effect, leaving only ! and !?? 2018-12-29 13:36:38 +11:00
Nigel Tao a80962d502 Make deflate's decode_huffman_fast ! not !?
name                             old speed     new speed     delta

wuffs_deflate_decode_1k/clang    138MB/s ± 0%  139MB/s ± 0%  +0.75%  (p=0.008 n=5+5)
wuffs_deflate_decode_10k/clang   233MB/s ± 0%  226MB/s ± 0%  -2.83%  (p=0.008 n=5+5)
wuffs_deflate_decode_100k/clang  273MB/s ± 0%  259MB/s ± 1%  -5.20%  (p=0.008 n=5+5)

wuffs_deflate_decode_1k/gcc      158MB/s ± 1%  157MB/s ± 0%    ~     (p=0.151 n=5+5)
wuffs_deflate_decode_10k/gcc     266MB/s ± 1%  261MB/s ± 0%  -1.95%  (p=0.008 n=5+5)
wuffs_deflate_decode_100k/gcc    314MB/s ± 0%  316MB/s ± 0%  +0.48%  (p=0.032 n=5+5)
2018-12-28 18:59:30 +11:00
Nigel Tao 3ba450ba55 Make gif's decoder.copy_to_image_buffer ! not !? 2018-12-28 17:32:48 +11:00
Nigel Tao 20c474b32a Add a genlinenum flag 2018-12-28 16:26:21 +11:00
Nigel Tao c9e6ee6fb3 Fold Expr statements into Assign statements 2018-12-27 17:36:08 +11:00
Nigel Tao 796c8ccc30 Simplify the gen.writeBuiltinQuestionCall caller 2018-12-27 17:06:59 +11:00
Nigel Tao 1b3f800416 Move some CSP's closer to the suspending call 2018-12-27 16:59:15 +11:00
Nigel Tao 28366f744f Drop duplicate CoroSuspPoint for io_reader.skip 2018-12-27 16:47:37 +11:00
Nigel Tao eddeebeb37 Get "t0" temporary vars out of cgen's writeExpr 2018-12-27 16:27:30 +11:00
Nigel Tao 67acce83c7 Factor writeStatementAssign into two methods 2018-12-27 16:12:01 +11:00
Nigel Tao efc4d9eee0 Clean up gen.writeStatementAssign a bit more 2018-12-27 15:56:06 +11:00
Nigel Tao 5248d26db6 Inline gen.writeQuestionCall 2018-12-27 15:28:00 +11:00
Nigel Tao 65936e40e4 Clean up some writeStatementAssign args 2018-12-27 13:20:48 +11:00
Nigel Tao e811b2dd75 Remove obsolete writeStatementAssign lhsIdent arg 2018-12-27 13:11:19 +11:00
Nigel Tao b10098a7f2 Clean up gen.writeStatementAssign a little bit 2018-12-27 11:56:56 +11:00
Nigel Tao 983cebd893 Have cgen zero-initialize all local variables 2018-12-27 11:54:33 +11:00
Nigel Tao 6dc68950c0 Drop the "= RHS" out of "var x T = RHS" 2018-12-27 11:29:47 +11:00
Nigel Tao d552f88738 Make Iterate contain Assign's not Var's 2018-12-27 10:35:27 +11:00
Nigel Tao 155f544c6b Move writeReadUXX to the file where it's called 2018-12-23 09:14:50 +11:00
Nigel Tao 6d2bb77bb7 Add a data:etc argument to io_bind 2018-12-09 09:53:46 +11:00
Nigel Tao badbdfc487 Tweak io_bind syntax 2018-12-09 09:13:29 +11:00
Nigel Tao e992921dce Add an io_limit keyword 2018-12-09 09:03:21 +11:00
Nigel Tao 3f3772e74b Merge cgen's writeStatement{Assign,Expr} 2018-12-08 09:45:23 +11:00
Nigel Tao d256df0fe3 Refactor cgen of question-calls 2018-12-02 10:20:43 +11:00
Nigel Tao b162747934 Remove cgen's obsolete replacementPolicy concept 2018-12-01 22:41:41 +11:00
Nigel Tao 8f1240f20e Mark cgen's replaceNothing as unused 2018-12-01 22:36:32 +11:00
Nigel Tao 2936b586cf Refactor cgen's writeStatement{Assign,Var} 2018-12-01 22:14:49 +11:00
Nigel Tao 09f857dc47 Re-number some cgen temporary variables 2018-12-01 20:30:28 +11:00
Nigel Tao 743b48f9dc Rename a cgen temporary variable 2018-12-01 20:28:40 +11:00
Nigel Tao 5cae1f8c82 Remove the obsolete Effect.RootCause concept 2018-12-01 13:37:33 +11:00
Nigel Tao 9741eada02 Replace "= try foo" with "=? foo" 2018-12-01 13:11:47 +11:00
Nigel Tao 4ff64de78e Mark deflate's decode_huffman_fast as !? not !?? 2018-11-24 20:34:31 +11:00
Nigel Tao ec0fd9649d Don't skip derived I/O vars for !? methods 2018-11-24 17:52:04 +11:00
Nigel Tao cf51406fcf Mark deflate's init_fixed_huffman as !? not !?? 2018-11-24 16:49:52 +11:00
Nigel Tao 312cdc8a0a Mark deflate's init_huff as merely !? not !?? 2018-11-24 16:41:45 +11:00
Nigel Tao 2434f0dee5 Remove some redundant cgen funk fields 2018-11-24 15:25:31 +11:00
Nigel Tao 762b320b5e Make the return value mandatory; add ok 2018-11-24 15:09:28 +11:00
Nigel Tao 875362ea07 Change status "?foo" to just "?foo" 2018-11-24 12:36:42 +11:00
Nigel Tao 4023294ba2 Add a gif.decoder.frame_dirty_rect method 2018-11-17 21:26:53 +11:00
Nigel Tao 3338d6d1bc Write LZW output 8 bytes at a time, not 1
The benchmarks are mixed, but I think it's still a net win.

----
name                                    old speed     new speed     delta

wuffs_gif_decode_1k_bw/clang            258MB/s ± 0%  253MB/s ± 1%    -2.04%  (p=0.008 n=5+5)
wuffs_gif_decode_1k_color/clang         159MB/s ± 0%  116MB/s ± 0%   -26.76%  (p=0.008 n=5+5)
wuffs_gif_decode_10k/clang              167MB/s ± 0%  138MB/s ± 0%   -17.42%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_artificial/clang  205MB/s ± 0%  439MB/s ± 0%  +114.53%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_realistic/clang   151MB/s ± 0%  164MB/s ± 0%    +8.41%  (p=0.008 n=5+5)
wuffs_gif_decode_1000k/clang            155MB/s ± 0%  165MB/s ± 0%    +6.50%  (p=0.008 n=5+5)
wuffs_gif_decode_anim_screencap/clang   255MB/s ± 0%  921MB/s ± 0%  +261.50%  (p=0.008 n=5+5)

wuffs_gif_decode_1k_bw/gcc              316MB/s ± 2%  267MB/s ± 1%   -15.78%  (p=0.008 n=5+5)
wuffs_gif_decode_1k_color/gcc           184MB/s ± 1%  134MB/s ± 0%   -27.57%  (p=0.008 n=5+5)
wuffs_gif_decode_10k/gcc                196MB/s ± 0%  161MB/s ± 0%   -17.50%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_artificial/gcc    287MB/s ± 0%  449MB/s ± 1%   +56.22%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_realistic/gcc     182MB/s ± 0%  182MB/s ± 1%      ~     (p=0.690 n=5+5)
wuffs_gif_decode_1000k/gcc              187MB/s ± 1%  185MB/s ± 1%      ~     (p=0.056 n=5+5)
wuffs_gif_decode_anim_screencap/gcc     397MB/s ± 0%  973MB/s ± 0%  +145.42%  (p=0.008 n=5+5)

wuffs_lzw_decode_20k/clang              170MB/s ± 0%  191MB/s ± 1%   +12.52%  (p=0.008 n=5+5)
wuffs_lzw_decode_100k/clang             242MB/s ± 0%  312MB/s ± 2%   +29.00%  (p=0.008 n=5+5)

wuffs_lzw_decode_20k/gcc                220MB/s ± 0%  227MB/s ± 0%    +3.31%  (p=0.008 n=5+5)
wuffs_lzw_decode_100k/gcc               317MB/s ± 0%  369MB/s ± 1%   +16.53%  (p=0.008 n=5+5)
----

LZW is the compression method used by GIF images. Roughly speaking, LZW
is a sequence of codes, and each code emits either 1 byte (a literal
code) or multiple bytes (a copy code). The speed gain in this commit
comes from, when emitting an N-byte copy code, this now requires N/8
iterations instead of N iterations, as each iteration now writes 8 bytes
instead of 1. Literal codes, both before and after this commit, requires
a single iteration.

Decoding should therefore get faster or slower depending on whether it's
copy-code-heavy or literal-code-heavy respectively. For what it's worth,
copy-code-heavy GIF images also usually compress better.

Running script/extract-giflzw.go (or examining the cached output at
test/data/analysis/giflzw-emission-lengths.txt) on the anim_screencap
(which got faster) and 1k_color (which got slower) cases (also known as
gifplayer-muybridge.gif and hippopotamus.regular.gif) shows that the
proportion of literal codes agrees with that explanation.

----
gifplayer-muybridge.gif (all frames)
 Percent   Count  Emission_Length_Bucket
   12.78   34658           1 (Literal Code)
   14.05   38106           2
   13.25   35937           3
   10.59   28707           4
    7.85   21286           5
    6.08   16481           6
    4.85   13156           7
    3.60    9764           8
    9.34   25318    9 ..  16
    4.89   13257   17 ..  32
    4.78   12954   33 ..  64
    4.72   12806   65 .. 128
    3.02    8190  127 .. 256
    0.20     550  256+

hippopotamus.regular.gif (all frames)
 Percent   Count  Emission_Length_Bucket
   82.66     672           1 (Literal Code)
   13.04     106           2
    2.83      23           3
    0.86       7           4
    0.37       3           5
    0.25       2           6
    0.00       0           7
    0.00       0           8
    0.00       0    9 ..  16
    0.00       0   17 ..  32
    0.00       0   33 ..  64
    0.00       0   65 .. 128
    0.00       0  127 .. 256
    0.00       0  256+
----

The new algorithm also adds more CPU and RAM overhead, regardless of
whether the input GIF image's LZW data is copy-code-heavy or
literal-code-heavy. For example, the suffix table grows by 8x, from 4KiB
to 32 KiB.

The gifplayer-muybridge.gif image is also larger (472 x 298) and the
hippopotamus.regular.gif image is also smaller (36 x 28). Higher fixed
costs may have larger (negative) relative effects on decoding smaller
images.

To repeat, I think it's still a net win.

An upcoming commit will update the std/lzw/README.md file to provide
more detail on the algorithm.

Thanks to Tushar Khandelwal for the idea.
2018-10-21 14:48:40 +11:00
Nigel Tao 9c04249bfe Add warnings as another status code category 2018-08-26 23:22:45 +10:00
Nigel Tao eec0fce647 Change error "?foo" to status "?foo" 2018-08-12 21:31:56 +10:00
Nigel Tao b840c80040 Make the status type a const char*, not a struct 2018-08-12 16:05:14 +10:00
Nigel Tao 2a32a86a6c Make the status type a struct, not an int32_t 2018-08-11 13:27:29 +10:00
Nigel Tao 9c0b2d2f5c Rename ioptr_etc cgen variables 2018-08-11 08:32:49 +10:00
Nigel Tao f2ee78aa2a Remove short_read_src cgen code path 2018-08-04 09:45:35 +10:00
Nigel Tao df19bcdb03 Require if and while conditions to be effect-free 2018-07-29 14:20:15 +10:00
Nigel Tao 5cca9471ec Have cgen look for !?? methods not ? methods 2018-07-29 14:01:57 +10:00
Nigel Tao 0a47966e72 Introduce finer-grained effects 2018-07-29 13:40:49 +10:00