Commit Graph
3526 Commits
Author SHA1 Message Date
Nigel Tao 4dfd70928b std: add "get_quirk(key: u32) u64" 2023-07-16 12:04:09 +10:00
Nigel Tao 84d1aa0d79 cmd/wuffs: show cmdArgs when "wuffs gen" fails 2023-07-16 11:44:08 +10:00
Nigel Tao 8954281a4e pixconv: allow decoding to PIXEL_FORMAT__RGB
"wuffs genlib" binary size changes:
 77936 clang-static/wuffs-base-pixconv.o  # Before = 1.00x
 79792 clang-static/wuffs-base-pixconv.o  # After  = 1.02x
173784 gcc-static/wuffs-base-pixconv.o    # Before = 1.00x
177112 gcc-static/wuffs-base-pixconv.o    # After  = 1.02x

Some of the benchmark numbers move around even though they don't use the
new WUFFS_BASE__PIXEL_FORMAT__RGB code paths. It's possibly just a code
alignment coincidence per https://news.ycombinator.com/item?id=23633583

name                                                       old speed      new speed      delta

wuffs_jpeg_decode_19k_8bpp/clang11                          249MB/s ± 0%   251MB/s ± 0%   +0.76%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11             222MB/s ± 0%   225MB/s ± 0%   +1.16%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11              405MB/s ± 0%   406MB/s ± 0%     ~     (p=1.000 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11                         357MB/s ± 0%   356MB/s ± 0%   -0.24%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11                    370MB/s ± 0%   372MB/s ± 0%   +0.46%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11                    504MB/s ± 0%   508MB/s ± 0%   +0.83%  (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11                       375MB/s ± 0%   374MB/s ± 0%     ~     (p=0.095 n=5+5)

wuffs_jpeg_decode_19k_8bpp/gcc10                            258MB/s ± 0%   254MB/s ± 0%   -1.68%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10               267MB/s ± 0%   240MB/s ± 0%   -9.95%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10                537MB/s ± 0%   537MB/s ± 0%     ~     (p=0.556 n=4+5)
wuffs_jpeg_decode_77k_24bpp/gcc10                           458MB/s ± 0%   453MB/s ± 0%   -1.18%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10                      482MB/s ± 0%   478MB/s ± 0%   -0.78%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10                      508MB/s ± 0%   511MB/s ± 0%   +0.49%  (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10                         489MB/s ± 0%   484MB/s ± 0%   -1.11%  (p=0.016 n=4+5)

wuffs_png_decode_image_19k_8bpp/clang11                     269MB/s ± 0%   275MB/s ± 0%   +2.25%  (p=0.008 n=5+5)
wuffs_png_decode_image_40k_24bpp/clang11                    328MB/s ± 0%   328MB/s ± 0%     ~     (p=0.841 n=5+5)
wuffs_png_decode_image_77k_8bpp/clang11                     949MB/s ± 0%   962MB/s ± 0%   +1.29%  (p=0.008 n=5+5)
wuffs_png_decode_image_552k_32bpp_ignore_checksum/clang11   854MB/s ± 0%   859MB/s ± 0%   +0.54%  (p=0.008 n=5+5)
wuffs_png_decode_image_552k_32bpp_verify_checksum/clang11   822MB/s ± 0%   826MB/s ± 0%   +0.52%  (p=0.008 n=5+5)
wuffs_png_decode_image_4002k_24bpp/clang11                  331MB/s ± 0%   332MB/s ± 0%   +0.15%  (p=0.008 n=5+5)

wuffs_png_decode_image_19k_8bpp/gcc10                       287MB/s ± 0%   277MB/s ± 0%   -3.46%  (p=0.008 n=5+5)
wuffs_png_decode_image_40k_24bpp/gcc10                      341MB/s ± 0%   346MB/s ± 0%   +1.34%  (p=0.008 n=5+5)
wuffs_png_decode_image_77k_8bpp/gcc10                      1.02GB/s ± 0%  1.01GB/s ± 0%   -0.41%  (p=0.008 n=5+5)
wuffs_png_decode_image_552k_32bpp_ignore_checksum/gcc10     939MB/s ± 0%   916MB/s ± 0%   -2.50%  (p=0.008 n=5+5)
wuffs_png_decode_image_552k_32bpp_verify_checksum/gcc10     895MB/s ± 0%   874MB/s ± 0%   -2.41%  (p=0.008 n=5+5)
wuffs_png_decode_image_4002k_24bpp/gcc10                    352MB/s ± 0%   350MB/s ± 0%   -0.44%  (p=0.008 n=5+5)

Updates #131
2023-07-16 11:17:45 +10:00
Nigel Tao 129d8008a2 doc: add more "decode an image" docs/comments 2023-07-15 13:26:45 +10:00
Nigel Tao 2644620770 check: allow p[i] if p has type "ptr array[N] T" 2023-06-29 18:15:08 +10:00
Nigel Tao b97560b292 cgen: emit "do { etc } while (0);" for some loops 2023-06-28 22:58:07 +10:00
Nigel Tao 99cc599f92 example/toy-aux-image: comment on config macros 2023-06-28 14:11:38 +10:00
Nigel Tao dd29401137 std/jpeg: re-format generated IDCT code 2023-06-28 13:49:55 +10:00
Nigel Tao 97c4e85e0e std/jpeg: add more-SIMD-like IDCT algorithm
This adds commented-out code that is equivalent to the existing IDCT
algorithm. It's slower as is (and hence commented out) but it is closer
to a follow-up commit's SIMD-optimized algorithm.
2023-06-28 13:45:25 +10:00
Nigel Tao 49f50cca91 std/jpeg: cap the implicit-zero bitstream padding
Updates https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=59966

name                                             old speed     new speed     delta

wuffs_jpeg_decode_19k_8bpp/clang11               241MB/s ± 0%  237MB/s ± 0%  -1.57%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11  213MB/s ± 0%  212MB/s ± 0%  -0.43%  (p=0.016 n=5+4)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11   387MB/s ± 0%  386MB/s ± 0%  -0.08%  (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11              341MB/s ± 0%  340MB/s ± 0%  -0.50%  (p=0.016 n=4+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11         356MB/s ± 0%  353MB/s ± 0%  -0.89%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11         484MB/s ± 0%  480MB/s ± 0%  -0.96%  (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11            364MB/s ± 0%  360MB/s ± 0%  -1.12%  (p=0.008 n=5+5)

wuffs_jpeg_decode_19k_8bpp/gcc10                 244MB/s ± 0%  247MB/s ± 0%  +0.88%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10    254MB/s ± 0%  254MB/s ± 0%  -0.20%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10     508MB/s ± 0%  512MB/s ± 0%  +0.61%  (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10                434MB/s ± 0%  436MB/s ± 0%  +0.39%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10           456MB/s ± 0%  458MB/s ± 0%  +0.41%  (p=0.016 n=4+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10           481MB/s ± 0%  483MB/s ± 0%  +0.49%  (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10              463MB/s ± 0%  466MB/s ± 0%  +0.57%  (p=0.016 n=4+5)
2023-06-23 21:38:01 +10:00
Nigel Tao 66ef485efa cgen: emit "break/continue" not "goto", part 3
A selection of benchmarks below. Some are up, some are down.

name                                                                old speed      new speed      delta

wuffs_bzip2_decode_10k/clang11                                      59.5MB/s ± 0%  59.1MB/s ± 0%   -0.72%  (p=0.008 n=5+5)
wuffs_bzip2_decode_100k/clang11                                     49.6MB/s ± 1%  47.4MB/s ± 0%   -4.48%  (p=0.008 n=5+5)

wuffs_bzip2_decode_10k/gcc10                                        59.0MB/s ± 0%  59.8MB/s ± 0%   +1.40%  (p=0.008 n=5+5)
wuffs_bzip2_decode_100k/gcc10                                       49.8MB/s ± 2%  53.0MB/s ± 0%   +6.51%  (p=0.008 n=5+5)

wuffs_deflate_decode_1k_full_init/clang11                            184MB/s ± 0%   182MB/s ± 0%   -1.06%  (p=0.008 n=5+5)
wuffs_deflate_decode_1k_part_init/clang11                            213MB/s ± 0%   211MB/s ± 0%   -0.65%  (p=0.008 n=5+5)
wuffs_deflate_decode_10k_full_init/clang11                           399MB/s ± 0%   409MB/s ± 0%   +2.68%  (p=0.008 n=5+5)
wuffs_deflate_decode_10k_part_init/clang11                           409MB/s ± 0%   421MB/s ± 0%   +2.96%  (p=0.008 n=5+5)
wuffs_deflate_decode_100k_just_one_read/clang11                      518MB/s ± 0%   517MB/s ± 0%     ~     (p=0.095 n=5+5)
wuffs_deflate_decode_100k_many_big_reads/clang11                     322MB/s ± 0%   319MB/s ± 0%   -0.93%  (p=0.008 n=5+5)

wuffs_deflate_decode_1k_full_init/gcc10                              173MB/s ± 0%   175MB/s ± 0%   +1.07%  (p=0.008 n=5+5)
wuffs_deflate_decode_1k_part_init/gcc10                              205MB/s ± 0%   208MB/s ± 0%   +1.26%  (p=0.008 n=5+5)
wuffs_deflate_decode_10k_full_init/gcc10                             408MB/s ± 0%   396MB/s ± 0%   -2.94%  (p=0.008 n=5+5)
wuffs_deflate_decode_10k_part_init/gcc10                             421MB/s ± 0%   408MB/s ± 0%   -2.88%  (p=0.008 n=5+5)
wuffs_deflate_decode_100k_just_one_read/gcc10                        542MB/s ± 0%   519MB/s ± 0%   -4.13%  (p=0.008 n=5+5)
wuffs_deflate_decode_100k_many_big_reads/gcc10                       340MB/s ± 0%   327MB/s ± 0%   -3.77%  (p=0.008 n=5+5)

wuffs_json_decode_1k/clang11                                        1.26GB/s ± 0%  1.34GB/s ± 0%   +6.90%  (p=0.008 n=5+5)
wuffs_json_decode_21k_formatted/clang11                              681MB/s ± 0%   684MB/s ± 0%   +0.47%  (p=0.008 n=5+5)
wuffs_json_decode_26k_compact/clang11                               1.00GB/s ± 0%  1.14GB/s ± 0%  +14.26%  (p=0.008 n=5+5)
wuffs_json_decode_217k_stringy/clang11                               786MB/s ± 0%   907MB/s ± 0%  +15.40%  (p=0.008 n=5+5)

wuffs_json_decode_1k/gcc10                                          1.20GB/s ± 0%  1.22GB/s ± 0%   +1.41%  (p=0.008 n=5+5)
wuffs_json_decode_21k_formatted/gcc10                                681MB/s ± 0%   719MB/s ± 0%   +5.59%  (p=0.008 n=5+5)
wuffs_json_decode_26k_compact/gcc10                                  957MB/s ± 0%   976MB/s ± 0%   +1.94%  (p=0.008 n=5+5)
wuffs_json_decode_217k_stringy/gcc10                                 773MB/s ± 0%   781MB/s ± 0%   +1.01%  (p=0.008 n=5+5)

wuffs_png_decode_image_19k_8bpp/clang11                              256MB/s ± 0%   256MB/s ± 0%     ~     (p=0.421 n=5+5)
wuffs_png_decode_image_40k_24bpp/clang11                             311MB/s ± 0%   313MB/s ± 0%   +0.57%  (p=0.008 n=5+5)
wuffs_png_decode_image_77k_8bpp/clang11                              907MB/s ± 0%   904MB/s ± 0%   -0.28%  (p=0.008 n=5+5)
wuffs_png_decode_image_552k_32bpp_ignore_checksum/clang11            821MB/s ± 0%   812MB/s ± 0%   -1.08%  (p=0.008 n=5+5)
wuffs_png_decode_image_552k_32bpp_verify_checksum/clang11            790MB/s ± 0%   782MB/s ± 0%   -0.94%  (p=0.008 n=5+5)
wuffs_png_decode_image_4002k_24bpp/clang11                           315MB/s ± 0%   315MB/s ± 0%   -0.09%  (p=0.008 n=5+5)

wuffs_png_decode_image_19k_8bpp/gcc10                                266MB/s ± 0%   273MB/s ± 0%   +2.94%  (p=0.008 n=5+5)
wuffs_png_decode_image_40k_24bpp/gcc10                               329MB/s ± 0%   324MB/s ± 2%   -1.65%  (p=0.008 n=5+5)
wuffs_png_decode_image_77k_8bpp/gcc10                                952MB/s ± 2%   967MB/s ± 0%   +1.57%  (p=0.016 n=5+4)
wuffs_png_decode_image_552k_32bpp_ignore_checksum/gcc10              871MB/s ± 0%   894MB/s ± 0%   +2.59%  (p=0.029 n=4+4)
wuffs_png_decode_image_552k_32bpp_verify_checksum/gcc10              831MB/s ± 0%   851MB/s ± 0%   +2.45%  (p=0.008 n=5+5)
wuffs_png_decode_image_4002k_24bpp/gcc10                             336MB/s ± 0%   335MB/s ± 0%   -0.53%  (p=0.008 n=5+5)
2023-06-23 21:04:24 +10:00
Nigel Tao de55ff7746 cgen: emit "break/continue" not "goto", part 2
name                                             old speed     new speed     delta

wuffs_jpeg_decode_19k_8bpp/clang11               241MB/s ± 0%  241MB/s ± 0%    ~     (p=0.690 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11  213MB/s ± 0%  213MB/s ± 0%    ~     (p=0.690 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11   386MB/s ± 0%  387MB/s ± 0%    ~     (p=0.270 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11              341MB/s ± 0%  341MB/s ± 0%    ~     (p=0.556 n=5+4)
wuffs_jpeg_decode_552k_24bpp_420/clang11         356MB/s ± 0%  356MB/s ± 0%    ~     (p=0.310 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11         484MB/s ± 0%  484MB/s ± 0%    ~     (p=0.095 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11            362MB/s ± 0%  364MB/s ± 0%    ~     (p=0.095 n=5+5)

wuffs_jpeg_decode_19k_8bpp/gcc10                 245MB/s ± 0%  244MB/s ± 0%  -0.19%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10    252MB/s ± 0%  254MB/s ± 0%  +0.76%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10     513MB/s ± 0%  508MB/s ± 0%  -0.88%  (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10                433MB/s ± 0%  434MB/s ± 0%  +0.38%  (p=0.016 n=4+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10           458MB/s ± 0%  456MB/s ± 0%  -0.41%  (p=0.029 n=4+4)
wuffs_jpeg_decode_552k_24bpp_444/gcc10           486MB/s ± 0%  481MB/s ± 0%  -1.00%  (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10              465MB/s ± 0%  463MB/s ± 0%  -0.39%  (p=0.029 n=4+4)
2023-06-23 18:29:20 +10:00
Nigel Tao f155db4d5c cgen: emit "break/continue" not "goto", part 1
name                                             old speed     new speed     delta

wuffs_jpeg_decode_19k_8bpp/clang11               229MB/s ± 0%  241MB/s ± 0%  +5.29%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11  205MB/s ± 0%  213MB/s ± 0%  +3.89%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11   375MB/s ± 0%  386MB/s ± 0%  +3.01%  (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11              326MB/s ± 0%  341MB/s ± 0%  +4.80%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11         339MB/s ± 0%  356MB/s ± 0%  +5.14%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11         475MB/s ± 0%  484MB/s ± 0%  +2.04%  (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11            343MB/s ± 0%  362MB/s ± 0%  +5.77%  (p=0.008 n=5+5)

wuffs_jpeg_decode_19k_8bpp/gcc10                 245MB/s ± 0%  245MB/s ± 0%  -0.07%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10    254MB/s ± 0%  252MB/s ± 0%  -0.52%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10     514MB/s ± 0%  513MB/s ± 0%    ~     (p=0.151 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10                434MB/s ± 0%  433MB/s ± 0%  -0.35%  (p=0.016 n=5+4)
wuffs_jpeg_decode_552k_24bpp_420/gcc10           459MB/s ± 0%  458MB/s ± 0%  -0.12%  (p=0.016 n=5+4)
wuffs_jpeg_decode_552k_24bpp_444/gcc10           486MB/s ± 0%  486MB/s ± 0%  -0.03%  (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10              467MB/s ± 0%  465MB/s ± 0%  -0.26%  (p=0.016 n=5+4)
2023-06-23 17:46:40 +10:00
Nigel Tao 8d9d6c1292 Performance mystery: load-bearing "no-op continue"
There is no semantic difference in this commit. There's no further code
after the if-else chain in the loop body. Nonetheless, adding a "no-op
continue" impacts performance: bad for clang and good for gcc.

Profiling suggests we spend less than 5% overall in
wuffs_jpeg__decoder__fill_bitstream.

name                                             old speed     new speed     delta

wuffs_jpeg_decode_19k_8bpp/clang11               241MB/s ± 0%  229MB/s ± 0%  -5.02%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11  213MB/s ± 0%  205MB/s ± 0%  -4.13%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11   386MB/s ± 0%  375MB/s ± 0%  -2.88%  (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11              341MB/s ± 0%  326MB/s ± 0%  -4.58%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11         356MB/s ± 0%  339MB/s ± 0%  -4.90%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11         484MB/s ± 0%  475MB/s ± 0%  -1.96%  (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11            364MB/s ± 0%  343MB/s ± 0%  -5.83%  (p=0.008 n=5+5)

wuffs_jpeg_decode_19k_8bpp/gcc10                 234MB/s ± 0%  245MB/s ± 0%  +4.68%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10    245MB/s ± 0%  254MB/s ± 0%  +3.35%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10     500MB/s ± 0%  514MB/s ± 0%  +2.81%  (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10                417MB/s ± 0%  434MB/s ± 0%  +4.18%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10           442MB/s ± 0%  459MB/s ± 0%  +3.76%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10           477MB/s ± 0%  486MB/s ± 0%  +1.99%  (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10              450MB/s ± 0%  467MB/s ± 0%  +3.70%  (p=0.008 n=5+5)

It is a mystery why this happens. Note though that the "continue" in the
Wuffs code becomes a "goto" in the generated C code, because (in the
general case) Wuffs has "labeled continue/break", which can jump out of
a not-inner-most loop, and C99 does not. Wuffs' "generate C code" thus
uses a C "goto". A follow-up commit may try a C "continue" instead.

To reproduce:

----
$ git clone https://github.com/google/wuffs.git
$ cd wuffs
$ gcc --version | head -n 1
gcc (Debian 10.2.1-6) 10.2.1 20210110

$ # Check out this commit.
$ git checkout --quiet THE_HASH_OF_THIS_COMMIT
$ gcc -O3 -Wall -std=c99 test/c/std/jpeg.c -DWUFFS_MIMIC -ljpeg
$ ./a.out -bench -focus=wuffs_jpeg_decode_77k_24bpp | grep MB/s
Benchmarkwuffs_jpeg_decode_77k_24bpp/gcc10	    3000	  176988 ns/op	     433.927 MB/s
Benchmarkwuffs_jpeg_decode_77k_24bpp/gcc10	    3000	  176849 ns/op	     434.268 MB/s
Benchmarkwuffs_jpeg_decode_77k_24bpp/gcc10	    3000	  176800 ns/op	     434.389 MB/s
Benchmarkwuffs_jpeg_decode_77k_24bpp/gcc10	    3000	  176844 ns/op	     434.279 MB/s
Benchmarkwuffs_jpeg_decode_77k_24bpp/gcc10	    3000	  176869 ns/op	     434.218 MB/s

$ # Check out the parent commit.
$ git checkout --quiet THE_HASH_OF_THIS_COMMIT^
$ gcc -O3 -Wall -std=c99 test/c/std/jpeg.c -DWUFFS_MIMIC -ljpeg
$ ./a.out -bench -focus=wuffs_jpeg_decode_77k_24bpp | grep MB/s
Benchmarkwuffs_jpeg_decode_77k_24bpp/gcc10	    3000	  183848 ns/op	     417.734 MB/s
Benchmarkwuffs_jpeg_decode_77k_24bpp/gcc10	    3000	  183870 ns/op	     417.684 MB/s
Benchmarkwuffs_jpeg_decode_77k_24bpp/gcc10	    3000	  183833 ns/op	     417.770 MB/s
Benchmarkwuffs_jpeg_decode_77k_24bpp/gcc10	    3000	  183873 ns/op	     417.679 MB/s
Benchmarkwuffs_jpeg_decode_77k_24bpp/gcc10	    3000	  183843 ns/op	     417.746 MB/s
----
2023-06-23 17:02:14 +10:00
Nigel Tao 40fca0f03d std/jpeg: roll back fill_bitstream inner loop
Commit 723c604a "std/jpeg: tweak decoder.fill_bitstream inner loop"
inadvertently changed "increment wi" behavior in the rare code paths.

name                                             old speed     new speed     delta

wuffs_jpeg_decode_19k_8bpp/clang11               237MB/s ± 0%  241MB/s ± 0%  +1.79%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11  213MB/s ± 0%  213MB/s ± 0%  +0.36%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11   384MB/s ± 0%  386MB/s ± 0%  +0.50%  (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11              338MB/s ± 0%  341MB/s ± 0%  +0.95%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11         353MB/s ± 0%  356MB/s ± 0%  +0.99%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11         481MB/s ± 0%  484MB/s ± 0%  +0.61%  (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11            359MB/s ± 0%  364MB/s ± 0%  +1.40%  (p=0.008 n=5+5)

wuffs_jpeg_decode_19k_8bpp/gcc10                 245MB/s ± 0%  234MB/s ± 0%  -4.45%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10    247MB/s ± 0%  245MB/s ± 0%  -0.59%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10     510MB/s ± 0%  500MB/s ± 0%  -1.94%  (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10                432MB/s ± 0%  417MB/s ± 0%  -3.62%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10           456MB/s ± 0%  442MB/s ± 0%  -3.14%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10           484MB/s ± 0%  477MB/s ± 0%  -1.49%  (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10              465MB/s ± 0%  450MB/s ± 0%  -3.28%  (p=0.008 n=5+5)
2023-06-23 16:29:16 +10:00
Nigel Tao a00150f62f std/jpeg: tweak decode_mcu up-front r.length check
name                                             old speed     new speed     delta

wuffs_jpeg_decode_19k_8bpp/clang11               236MB/s ± 0%  237MB/s ± 0%  +0.11%  (p=0.032 n=4+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11  210MB/s ± 0%  213MB/s ± 0%  +1.20%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11   385MB/s ± 0%  384MB/s ± 0%    ~     (p=0.095 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11              338MB/s ± 0%  338MB/s ± 0%    ~     (p=0.151 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11         353MB/s ± 0%  353MB/s ± 0%    ~     (p=0.548 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11         481MB/s ± 0%  481MB/s ± 0%    ~     (p=0.690 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11            360MB/s ± 0%  359MB/s ± 0%  -0.35%  (p=0.008 n=5+5)

wuffs_jpeg_decode_19k_8bpp/gcc10                 244MB/s ± 0%  245MB/s ± 0%  +0.44%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10    251MB/s ± 0%  247MB/s ± 0%  -1.46%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10     509MB/s ± 0%  510MB/s ± 0%  +0.13%  (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10                431MB/s ± 0%  432MB/s ± 0%  +0.24%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10           455MB/s ± 0%  456MB/s ± 0%  +0.26%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10           481MB/s ± 0%  484MB/s ± 0%  +0.56%  (p=0.016 n=4+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10              463MB/s ± 0%  465MB/s ± 0%  +0.36%  (p=0.008 n=5+5)
2023-06-22 11:37:40 +10:00
Nigel Tao 255516bc21 std/jpeg: comments for "read Huffman LUT earlier"
This commit is the second of two. It just adds comments to the code
added by the previous commit.
2023-06-21 22:51:22 +10:00
Nigel Tao d9c7740ea6 std/jpeg: read Huffman look-up table earlier
This commit is the first of two. It just changes code, and is the
minimal code change that leads to these performance improvements. The
follow-up commit will add comments that will also include a reference to
this one's commit hash. Even later commits may do some more refactoring.

name                                             old speed     new speed     delta

wuffs_jpeg_decode_19k_8bpp/clang11               224MB/s ± 0%  236MB/s ± 0%  +5.38%  (p=0.016 n=5+4)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11  211MB/s ± 0%  210MB/s ± 0%  -0.55%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11   377MB/s ± 0%  385MB/s ± 0%  +1.91%  (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11              328MB/s ± 0%  338MB/s ± 0%  +3.23%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11         341MB/s ± 0%  353MB/s ± 0%  +3.47%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11         472MB/s ± 0%  481MB/s ± 0%  +1.93%  (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11            347MB/s ± 0%  360MB/s ± 0%  +3.70%  (p=0.008 n=5+5)

wuffs_jpeg_decode_19k_8bpp/gcc10                 225MB/s ± 0%  244MB/s ± 0%  +8.27%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10    246MB/s ± 0%  251MB/s ± 0%  +1.67%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10     498MB/s ± 0%  509MB/s ± 0%  +2.18%  (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10                408MB/s ± 0%  431MB/s ± 0%  +5.86%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10           428MB/s ± 0%  455MB/s ± 0%  +6.38%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10           470MB/s ± 0%  481MB/s ± 0%  +2.46%  (p=0.016 n=5+4)
wuffs_jpeg_decode_4002k_24bpp/gcc10              433MB/s ± 0%  463MB/s ± 0%  +7.03%  (p=0.008 n=5+5)
2023-06-21 21:56:54 +10:00
Nigel Tao bedf2bd7c3 lang: let skip_u32_fast imply can_undo_byte 2023-06-20 23:02:01 +10:00
Nigel Tao 723c604a5b std/jpeg: tweak decoder.fill_bitstream inner loop
name                                             old speed     new speed     delta

wuffs_jpeg_decode_19k_8bpp/clang11               229MB/s ± 0%  225MB/s ± 0%  -1.78%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11  212MB/s ± 0%  212MB/s ± 0%    ~     (p=0.421 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11   380MB/s ± 0%  377MB/s ± 0%  -0.56%  (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11              331MB/s ± 0%  328MB/s ± 0%  -1.00%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11         344MB/s ± 0%  341MB/s ± 0%  -0.97%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11         476MB/s ± 0%  473MB/s ± 0%  -0.66%  (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11            350MB/s ± 0%  348MB/s ± 0%  -0.64%  (p=0.008 n=5+5)

wuffs_jpeg_decode_19k_8bpp/gcc10                 215MB/s ± 0%  225MB/s ± 0%  +4.62%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10    246MB/s ± 0%  247MB/s ± 0%  +0.35%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10     485MB/s ± 0%  499MB/s ± 0%  +2.84%  (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10                394MB/s ± 0%  408MB/s ± 0%  +3.63%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10           414MB/s ± 0%  428MB/s ± 0%  +3.30%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10           462MB/s ± 0%  470MB/s ± 0%  +1.81%  (p=0.016 n=4+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10              420MB/s ± 0%  433MB/s ± 0%  +3.13%  (p=0.008 n=5+5)
2023-06-20 22:21:10 +10:00
Nigel Tao 8916f1b6ea lang: add if.likely and if.unlikely 2023-06-20 18:00:48 +10:00
Nigel Tao 1acd74482a std/jpeg: add more EXTEND comments 2023-06-20 17:33:08 +10:00
Nigel Tao 38205517d4 test: fix some errors in "compile C as C++" 2023-06-20 17:25:56 +10:00
Nigel Tao e7df7cafac cgen: add WUFFS_BASE__GENERATED_C_CODE macro
This disables UBSan's "unsigned-integer-overflow" runtime checks.

Updates https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=59966
2023-06-20 17:04:35 +10:00
Nigel Tao 6eb92544bd std/jpeg: tweak decode_mcu z variable assignment
name                                             old speed     new speed     delta

wuffs_jpeg_decode_19k_8bpp/clang11               227MB/s ± 0%  229MB/s ± 0%  +0.93%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11  213MB/s ± 0%  212MB/s ± 0%  -0.50%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11   380MB/s ± 0%  380MB/s ± 0%    ~     (p=1.000 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11              329MB/s ± 0%  331MB/s ± 0%  +0.73%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11         342MB/s ± 0%  344MB/s ± 0%  +0.72%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11         469MB/s ± 0%  476MB/s ± 0%  +1.46%  (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11            348MB/s ± 0%  350MB/s ± 0%  +0.51%  (p=0.008 n=5+5)

wuffs_jpeg_decode_19k_8bpp/gcc10                 213MB/s ± 0%  215MB/s ± 0%  +0.70%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10    246MB/s ± 0%  246MB/s ± 0%    ~     (p=0.095 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10     482MB/s ± 0%  485MB/s ± 0%  +0.61%  (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10                392MB/s ± 0%  394MB/s ± 0%  +0.53%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10           412MB/s ± 0%  414MB/s ± 0%  +0.45%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10           460MB/s ± 0%  462MB/s ± 0%  +0.43%  (p=0.016 n=5+4)
wuffs_jpeg_decode_4002k_24bpp/gcc10              419MB/s ± 0%  420MB/s ± 0%  +0.32%  (p=0.008 n=5+5)
2023-06-19 20:13:01 +10:00
Nigel Tao 48fa7182f4 std/jpeg: tweak UNZIG comments 2023-06-19 13:19:24 +10:00
Nigel Tao 36323abf87 std/jpeg: tighten EXTEND element type s/u32/u16/
I'm not sure of the underlying reason for the gcc benchmark anomaly (the
clang numbers don't change).

name                                             old speed     new speed     delta

wuffs_jpeg_decode_19k_8bpp/clang11               227MB/s ± 0%  227MB/s ± 0%     ~     (p=0.151 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11  209MB/s ± 0%  213MB/s ± 0%   +1.62%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11   379MB/s ± 0%  380MB/s ± 0%   +0.13%  (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11              329MB/s ± 0%  329MB/s ± 0%   +0.06%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11         342MB/s ± 0%  342MB/s ± 0%     ~     (p=0.690 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11         468MB/s ± 0%  469MB/s ± 0%   +0.10%  (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11            348MB/s ± 0%  348MB/s ± 0%   +0.08%  (p=0.016 n=5+5)

wuffs_jpeg_decode_19k_8bpp/gcc10                 213MB/s ± 0%  213MB/s ± 0%     ~     (p=0.151 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10    221MB/s ± 0%  246MB/s ± 0%  +11.51%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10     487MB/s ± 0%  482MB/s ± 0%   -0.98%  (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10                392MB/s ± 0%  392MB/s ± 0%     ~     (p=1.000 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10           413MB/s ± 0%  412MB/s ± 0%     ~     (p=0.190 n=4+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10           459MB/s ± 0%  460MB/s ± 0%   +0.09%  (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10              419MB/s ± 0%  419MB/s ± 0%   +0.04%  (p=0.008 n=5+5)
2023-06-18 21:35:49 +10:00
Nigel Tao e4902dbd45 std/jpeg: tweak "this.mcu_zig_index" vs "var z" 2023-06-18 21:18:41 +10:00
Nigel Tao 9b97c27ec6 std/jpeg: tweak UNZIG array
We'll hopefully claw back the performance in a follow-up commit.

name                                             old speed     new speed     delta

wuffs_jpeg_decode_19k_8bpp/clang11               222MB/s ± 0%  224MB/s ± 0%   +1.11%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11  213MB/s ± 0%  210MB/s ± 0%   -1.53%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11   376MB/s ± 0%  378MB/s ± 0%   +0.37%  (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11              325MB/s ± 0%  328MB/s ± 0%   +0.66%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11         339MB/s ± 0%  340MB/s ± 0%   +0.46%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11         468MB/s ± 0%  469MB/s ± 0%   +0.27%  (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11            344MB/s ± 0%  346MB/s ± 0%   +0.37%  (p=0.008 n=5+5)

wuffs_jpeg_decode_19k_8bpp/gcc10                 212MB/s ± 0%  213MB/s ± 0%   +0.46%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10    246MB/s ± 0%  221MB/s ± 0%   -9.98%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10     484MB/s ± 0%  484MB/s ± 0%     ~     (p=0.056 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10                390MB/s ± 0%  392MB/s ± 0%   +0.47%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10           415MB/s ± 0%  414MB/s ± 0%   -0.17%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10           463MB/s ± 0%  459MB/s ± 0%   -0.78%  (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10              420MB/s ± 0%  419MB/s ± 0%   -0.19%  (p=0.008 n=5+5)
2023-06-18 20:57:50 +10:00
Nigel Tao 19e5cccee3 std/jpeg: add an EXTEND look-up table
name                                             old speed     new speed     delta

wuffs_jpeg_decode_19k_8bpp/clang11               223MB/s ± 0%  222MB/s ± 0%  -0.81%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11  208MB/s ± 0%  213MB/s ± 0%  +2.32%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11   375MB/s ± 0%  376MB/s ± 0%  +0.34%  (p=0.016 n=4+5)
wuffs_jpeg_decode_77k_24bpp/clang11              319MB/s ± 0%  325MB/s ± 0%  +1.92%  (p=0.016 n=4+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11         329MB/s ± 0%  339MB/s ± 0%  +3.00%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11         465MB/s ± 0%  468MB/s ± 0%  +0.65%  (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11            331MB/s ± 0%  344MB/s ± 0%  +4.02%  (p=0.008 n=5+5)

wuffs_jpeg_decode_19k_8bpp/gcc10                 208MB/s ± 0%  212MB/s ± 0%  +1.76%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10    243MB/s ± 0%  246MB/s ± 0%  +1.09%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10     479MB/s ± 0%  484MB/s ± 0%  +1.17%  (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10                385MB/s ± 0%  390MB/s ± 0%  +1.40%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10           407MB/s ± 0%  415MB/s ± 0%  +1.98%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10           457MB/s ± 0%  463MB/s ± 0%  +1.29%  (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10              411MB/s ± 0%  420MB/s ± 0%  +2.06%  (p=0.008 n=5+5)
2023-06-18 18:44:41 +10:00
Nigel Tao 44e745dd0e std/jpeg: optimize EXTEND'ing MCU bits
name                                             old speed     new speed     delta

wuffs_jpeg_decode_19k_8bpp/clang11               224MB/s ± 1%  223MB/s ± 0%     ~     (p=0.190 n=4+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11  206MB/s ± 0%  208MB/s ± 0%   +0.86%  (p=0.016 n=4+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11   374MB/s ± 0%  375MB/s ± 0%   +0.26%  (p=0.016 n=5+4)
wuffs_jpeg_decode_77k_24bpp/clang11              319MB/s ± 0%  319MB/s ± 0%   +0.16%  (p=0.029 n=4+4)
wuffs_jpeg_decode_552k_24bpp_420/clang11         329MB/s ± 0%  329MB/s ± 0%   -0.06%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11         465MB/s ± 0%  465MB/s ± 0%   -0.12%  (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11            332MB/s ± 0%  331MB/s ± 0%   -0.15%  (p=0.008 n=5+5)

wuffs_jpeg_decode_19k_8bpp/gcc10                 176MB/s ± 0%  208MB/s ± 0%  +18.26%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10    246MB/s ± 0%  243MB/s ± 0%   -1.03%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10     472MB/s ± 0%  479MB/s ± 0%   +1.33%  (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10                334MB/s ± 0%  385MB/s ± 0%  +15.33%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10           351MB/s ± 0%  407MB/s ± 0%  +15.74%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10           425MB/s ± 0%  457MB/s ± 0%   +7.38%  (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10              349MB/s ± 0%  411MB/s ± 0%  +17.74%  (p=0.008 n=5+5)
2023-06-18 17:37:23 +10:00
Nigel Tao 143991a301 std/jpeg: check up-front for sufficient AC bits
The micro-benchmarks are mixed for now, but this sets us up to remove an
inner-loop bounds check in a future commit.

name                                             old speed     new speed     delta

wuffs_jpeg_decode_19k_8bpp/clang11               226MB/s ± 0%  224MB/s ± 1%  -1.03%  (p=0.029 n=4+4)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11  210MB/s ± 0%  206MB/s ± 0%  -1.59%  (p=0.029 n=4+4)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11   379MB/s ± 0%  374MB/s ± 0%  -1.25%  (p=0.016 n=4+5)
wuffs_jpeg_decode_77k_24bpp/clang11              326MB/s ± 0%  319MB/s ± 0%  -2.35%  (p=0.029 n=4+4)
wuffs_jpeg_decode_552k_24bpp_420/clang11         338MB/s ± 0%  329MB/s ± 0%  -2.53%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11         468MB/s ± 0%  465MB/s ± 0%  -0.58%  (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11            347MB/s ± 0%  332MB/s ± 0%  -4.41%  (p=0.016 n=4+5)

wuffs_jpeg_decode_19k_8bpp/gcc10                 174MB/s ± 0%  176MB/s ± 0%  +1.18%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10    247MB/s ± 0%  246MB/s ± 0%  -0.55%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10     477MB/s ± 0%  472MB/s ± 0%  -0.90%  (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10                328MB/s ± 0%  334MB/s ± 0%  +1.69%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10           346MB/s ± 0%  351MB/s ± 0%  +1.57%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10           424MB/s ± 0%  425MB/s ± 0%  +0.39%  (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10              350MB/s ± 0%  349MB/s ± 0%  -0.23%  (p=0.008 n=5+5)
2023-06-18 17:37:12 +10:00
Nigel Tao 2ca61b521f test/data: add ridiculously-fast.png 2023-06-17 19:50:47 +10:00
Nigel Tao 5b84fb54d8 script: add RUSTFLAGS to bench-rust-jpeg
Adding "RUSTFLAGS='-C target-cpu=native'" numbers to the previous
commit's numbers:

name                                             speed

// Go 1.21
go_jpeg_decode_19k_8bpp                          46.8MB/s ± 5%
go_jpeg_decode_30k_24bpp_progressive             55.8MB/s ± 5%
go_jpeg_decode_30k_24bpp_sequential              90.5MB/s ± 5%
go_jpeg_decode_77k_24bpp                         75.8MB/s ± 2%
go_jpeg_decode_552k_24bpp_420                    81.1MB/s ± 6%
go_jpeg_decode_552k_24bpp_444                    83.0MB/s ± 5%
go_jpeg_decode_4002k_24bpp                       91.3MB/s ± 4%

// Rust 1.63, default configuration
rust_jpeg_decode_image_19k_8bpp                   153MB/s ± 3%
rust_jpeg_decode_image_30k_24bpp_progressive     51.1MB/s ± 3%
rust_jpeg_decode_image_30k_24bpp_sequential       107MB/s ± 6%
rust_jpeg_decode_image_77k_24bpp                  118MB/s ± 2%
rust_jpeg_decode_image_552k_24bpp_420             183MB/s ± 3%
rust_jpeg_decode_image_552k_24bpp_444             181MB/s ± 4%
rust_jpeg_decode_image_4002k_24bpp                258MB/s ± 3%

// Rust 1.63, RUSTFLAGS='-C target-cpu=native'
rust_jpeg_decode_image_19k_8bpp                   158MB/s ± 1%
rust_jpeg_decode_image_30k_24bpp_progressive     54.4MB/s ± 3%
rust_jpeg_decode_image_30k_24bpp_sequential       137MB/s ± 6%
rust_jpeg_decode_image_77k_24bpp                  130MB/s ± 1%
rust_jpeg_decode_image_552k_24bpp_420             211MB/s ± 7%
rust_jpeg_decode_image_552k_24bpp_444             201MB/s ± 4%
rust_jpeg_decode_image_4002k_24bpp                280MB/s ± 0%

// Wuffs, clang 14.0
wuffs_jpeg_decode_19k_8bpp/clang14                177MB/s ± 0%
wuffs_jpeg_decode_30k_24bpp_progressive/clang14   191MB/s ± 0%
wuffs_jpeg_decode_30k_24bpp_sequential/clang14    339MB/s ± 0%
wuffs_jpeg_decode_77k_24bpp/clang14               286MB/s ± 0%
wuffs_jpeg_decode_552k_24bpp_420/clang14          298MB/s ± 0%
wuffs_jpeg_decode_552k_24bpp_444/clang14          369MB/s ± 0%
wuffs_jpeg_decode_4002k_24bpp/clang14             297MB/s ± 0%

// Wuffs, gcc 12.2
wuffs_jpeg_decode_19k_8bpp/gcc12                  160MB/s ± 0%
wuffs_jpeg_decode_30k_24bpp_progressive/gcc12     208MB/s ± 1%
wuffs_jpeg_decode_30k_24bpp_sequential/gcc12      400MB/s ± 1%
wuffs_jpeg_decode_77k_24bpp/gcc12                 292MB/s ± 0%
wuffs_jpeg_decode_552k_24bpp_420/gcc12            305MB/s ± 0%
wuffs_jpeg_decode_552k_24bpp_444/gcc12            363MB/s ± 1%
wuffs_jpeg_decode_4002k_24bpp/gcc12               305MB/s ± 0%
2023-06-16 09:41:16 +10:00
Nigel Tao 32961a8413 script: add bench-rust-jpeg
This commit only adds Rust code, but it's as good a moment as any to
take a snapshot of how Wuffs' work-in-progress JPEG decoder performance
(which does not use SIMD optimizations yet) compares to Go and Rust.

The numbers in this commit were measured on different hardware (and
different C compiler versions) than other recent Wuffs commits, so the
absolute numbers aren't directly comparable across commits.

name                                             speed

// Go 1.21
go_jpeg_decode_19k_8bpp                          46.8MB/s ± 5%
go_jpeg_decode_30k_24bpp_progressive             55.8MB/s ± 5%
go_jpeg_decode_30k_24bpp_sequential              90.5MB/s ± 5%
go_jpeg_decode_77k_24bpp                         75.8MB/s ± 2%
go_jpeg_decode_552k_24bpp_420                    81.1MB/s ± 6%
go_jpeg_decode_552k_24bpp_444                    83.0MB/s ± 5%
go_jpeg_decode_4002k_24bpp                       91.3MB/s ± 4%

// Rust 1.63
rust_jpeg_decode_image_19k_8bpp                   153MB/s ± 3%
rust_jpeg_decode_image_30k_24bpp_progressive     51.1MB/s ± 3%
rust_jpeg_decode_image_30k_24bpp_sequential       107MB/s ± 6%
rust_jpeg_decode_image_77k_24bpp                  118MB/s ± 2%
rust_jpeg_decode_image_552k_24bpp_420             183MB/s ± 3%
rust_jpeg_decode_image_552k_24bpp_444             181MB/s ± 4%
rust_jpeg_decode_image_4002k_24bpp                258MB/s ± 3%

// Wuffs, clang 14.0
wuffs_jpeg_decode_19k_8bpp/clang14                177MB/s ± 0%
wuffs_jpeg_decode_30k_24bpp_progressive/clang14   191MB/s ± 0%
wuffs_jpeg_decode_30k_24bpp_sequential/clang14    339MB/s ± 0%
wuffs_jpeg_decode_77k_24bpp/clang14               286MB/s ± 0%
wuffs_jpeg_decode_552k_24bpp_420/clang14          298MB/s ± 0%
wuffs_jpeg_decode_552k_24bpp_444/clang14          369MB/s ± 0%
wuffs_jpeg_decode_4002k_24bpp/clang14             297MB/s ± 0%

// Wuffs, gcc 12.2
wuffs_jpeg_decode_19k_8bpp/gcc12                  160MB/s ± 0%
wuffs_jpeg_decode_30k_24bpp_progressive/gcc12     208MB/s ± 1%
wuffs_jpeg_decode_30k_24bpp_sequential/gcc12      400MB/s ± 1%
wuffs_jpeg_decode_77k_24bpp/gcc12                 292MB/s ± 0%
wuffs_jpeg_decode_552k_24bpp_420/gcc12            305MB/s ± 0%
wuffs_jpeg_decode_552k_24bpp_444/gcc12            363MB/s ± 1%
wuffs_jpeg_decode_4002k_24bpp/gcc12               305MB/s ± 0%
2023-06-14 22:55:09 +10:00
Nigel Tao e1df1b2835 script: update print-jpeg-idct-code.go
Its output now once again matches the fragment in
std/jpeg/decode_idct_default.wuffs, which was recently hand-edited in
commit c0d7d7d0 "std/jpeg: remove decode_idct block-selector arg". This
commit's edit should have been part of that previous commit.
2023-06-14 16:12:48 +10:00
Nigel Tao 724aec33df cgen: remove unnecessary parens for ptr-to-array 2023-06-13 22:39:21 +10:00
Nigel Tao 43beae1d3d lang: make "return a slice" return a slice of this 2023-06-13 22:38:29 +10:00
Nigel Tao 66723c6706 lang: make this.foo read-only in a pure function 2023-06-13 22:38:29 +10:00
Nigel Tao dd6a5d5435 std/jpeg: memoize ac_huff_table_fast
name                                             old speed     new speed     delta

wuffs_jpeg_decode_19k_8bpp/clang11               215MB/s ± 0%  226MB/s ± 0%  +5.17%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11  209MB/s ± 0%  210MB/s ± 0%  +0.50%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11   368MB/s ± 0%  380MB/s ± 1%  +3.11%  (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11              313MB/s ± 0%  327MB/s ± 0%  +4.27%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11         326MB/s ± 0%  338MB/s ± 0%  +3.50%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11         462MB/s ± 0%  468MB/s ± 0%  +1.14%  (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11            329MB/s ± 1%  346MB/s ± 0%  +5.39%  (p=0.008 n=5+5)

wuffs_jpeg_decode_19k_8bpp/gcc10                 174MB/s ± 0%  175MB/s ± 0%  +0.55%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10    228MB/s ± 0%  248MB/s ± 0%  +8.49%  (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10     472MB/s ± 0%  478MB/s ± 0%  +1.20%  (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10                327MB/s ± 0%  328MB/s ± 0%  +0.47%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10           344MB/s ± 0%  346MB/s ± 0%  +0.46%  (p=0.016 n=4+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10           422MB/s ± 0%  424MB/s ± 0%  +0.49%  (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10              349MB/s ± 0%  348MB/s ± 0%  -0.24%  (p=0.008 n=5+5)
2023-06-13 22:38:29 +10:00
Nigel Tao 19f56ebfd2 lang: allow "slice_var as ptr array[etc] etc" 2023-06-13 22:38:25 +10:00
Nigel Tao 6411561deb check: add maxPointerBounds and funcBounds 2023-06-13 11:52:16 +10:00
Nigel Tao 8ac22ceab2 cgen: allow "var x : nptr array[etc] etc" 2023-06-13 10:49:37 +10:00
Nigel Tao dfab0d2b3d mimiclib: allow jpeg decoding via stb_image 2023-06-12 17:24:49 +10:00
Nigel Tao 1f0f323414 std/jpeg: memoize Huffman table selectors 2023-06-12 16:23:53 +10:00
Nigel Tao 04344db374 cgen: remove "// ¡ BEGIN set_color_u32_at" 2023-06-11 12:33:36 +10:00
Nigel Tao 7511bda9e5 cgen: refactor patch_pixconv's set_color_u32_at 2023-06-11 12:02:47 +10:00
Nigel Tao 43d9c604a2 cgen: unroll etc__swizzle_ycck for 444
name                                             old speed     new speed     delta

wuffs_jpeg_decode_552k_24bpp_444/clang11         440MB/s ± 0%  459MB/s ± 0%  +4.48%  (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10           393MB/s ± 0%  412MB/s ± 0%  +4.82%  (p=0.008 n=5+5)
2023-06-11 11:23:29 +10:00
Nigel Tao 41fb661626 cgen: make patch_pixconv etc__bgrx__hv11 explicit 2023-06-11 11:20:49 +10:00
Nigel Tao 1b0900ac73 cgen: re-organize patch_pixconv.go generated funcs 2023-06-11 10:47:29 +10:00