Commit Graph
2471 Commits
Author SHA1 Message Date
Nigel Tao dd04d55417 Update dumbindent comparison for clang-format-9 2020-06-05 18:35:05 +10:00
Nigel Tao f45f01f4f3 Update clang-format from v5 to v9 2020-06-05 14:06:56 +10:00
Nigel Tao d48a4eb581 Add dumbindent comment about extern "C" 2020-06-05 13:26:32 +10:00
Nigel Tao 78daf1ca91 Update doc/note/auto-formatting.md for dumbindent 2020-06-05 10:59:27 +10:00
Nigel Tao a0f7059eeb Tweak changelog bullet for C formatting 2020-06-05 10:46:42 +10:00
Nigel Tao 527a9ac984 Spin out an internal/cgen/data directory
Grepping in internal/cgen/*.go will no longer also grep in the generated
data.go file.
2020-06-05 10:36:17 +10:00
Nigel Tao d0dec081a6 Tweak cgen+dumbindent output 2020-06-05 10:22:14 +10:00
Nigel Tao d5d4da0ab6 Add some "// --------" section-break comments 2020-06-05 00:10:31 +10:00
Nigel Tao 8cd39fc1dd Remove -cformatter flag 2020-06-05 00:08:05 +10:00
Nigel Tao 12b0f4c0bc Change the default -cformatter to dumbindent
A follow-up commit will remove the -cformatter flag entirely.

Formatting the generated C code is now a small fraction of where "wuffs
gen" spends its time.

----
$ # Before.
$ time wuffs gen > /dev/null
real	0m0.932s
user	0m0.837s
sys	0m0.187s

$ # After.
$ time wuffs gen > /dev/null
real	0m0.186s
user	0m0.170s
sys	0m0.069s

$ time wuffs gen -cformatter= > /dev/null
real	0m0.184s
user	0m0.170s
sys	0m0.059s
----
2020-06-04 23:59:20 +10:00
Nigel Tao d8cd72798a Add {cmd,lib}/dumbindent 2020-06-04 23:35:11 +10:00
Nigel Tao b2dc84105a Clean up more wuffs-c output (before clang-format) 2020-06-04 23:26:15 +10:00
Nigel Tao 58a48d5a54 Don't run the base package through the C-formatter
----
$ # Before.
$ time wuffs gen > /dev/null
real	0m1.427s
user	0m1.272s
sys	0m0.245s

$ # After.
$ time wuffs gen > /dev/null
real	0m0.953s
user	0m0.864s
sys	0m0.188s
----
2020-06-03 23:31:54 +10:00
Nigel Tao 4402c1c7c0 Clean up more wuffs-c output (before clang-format) 2020-06-03 23:14:55 +10:00
Nigel Tao 3efb204f4e Drop wuffs-c genrelease's exec of the C-formatter
genrelease essentially concatenates the individual packages' generated C
files, which should already be formatted.

----
$ # Before.
$ time wuffs gen > /dev/null
real	0m2.622s
user	0m2.457s
sys	0m0.266s

$ # After.
$ time wuffs gen > /dev/null
real	0m1.433s
user	0m1.335s
sys	0m0.191s
----
2020-06-03 13:46:24 +10:00
Nigel Tao 16c1f3cfd7 Clean up some wuffs-c output (before clang-format) 2020-06-03 13:36:04 +10:00
Nigel Tao ddc8973ef0 Let wuffs-c take a no-op C formatter
Reinforcing the previous commit's (e5cc4a42) observation, over 93% of
compilation time (converting foo.wuffs into foo.c) is spent piping the
generated C code through clang-format.

----
$ time wuffs gen -cformatter=clang-format-5.0 > /dev/null
real	0m2.855s
user	0m2.680s
sys	0m0.286s

$ time wuffs gen -cformatter=                 > /dev/null
real	0m0.175s
user	0m0.172s
sys	0m0.050s
----
2020-06-03 13:21:53 +10:00
Nigel Tao e5cc4a42e4 Measure how much of "wuffs gen" is clang-format
----
$ time wuffs gen
       1 milliseconds generating the C code
     753 milliseconds formatting the C code via "clang-format-5.0"
gen unchanged:  /etcetera/wuffs/gen/c/wuffs-base.c
       0 milliseconds generating the C code
      19 milliseconds formatting the C code via "clang-format-5.0"
gen unchanged:  /etcetera/wuffs/gen/c/wuffs-std-adler32.c
gen unchanged:  /etcetera/wuffs/gen/wuffs/std/adler32.wuffs
       1 milliseconds generating the C code
      61 milliseconds formatting the C code via "clang-format-5.0"
gen unchanged:  /etcetera/wuffs/gen/c/wuffs-std-bmp.c
gen unchanged:  /etcetera/wuffs/gen/wuffs/std/bmp.wuffs
       1 milliseconds generating the C code
      78 milliseconds formatting the C code via "clang-format-5.0"
gen unchanged:  /etcetera/wuffs/gen/c/wuffs-std-crc32.c
gen unchanged:  /etcetera/wuffs/gen/wuffs/std/crc32.wuffs
       2 milliseconds generating the C code
      93 milliseconds formatting the C code via "clang-format-5.0"
gen unchanged:  /etcetera/wuffs/gen/c/wuffs-std-deflate.c
gen unchanged:  /etcetera/wuffs/gen/wuffs/std/deflate.wuffs
       0 milliseconds generating the C code
      34 milliseconds formatting the C code via "clang-format-5.0"
gen unchanged:  /etcetera/wuffs/gen/c/wuffs-std-lzw.c
gen unchanged:  /etcetera/wuffs/gen/wuffs/std/lzw.wuffs
       4 milliseconds generating the C code
     203 milliseconds formatting the C code via "clang-format-5.0"
gen unchanged:  /etcetera/wuffs/gen/c/wuffs-std-gif.c
gen unchanged:  /etcetera/wuffs/gen/wuffs/std/gif.wuffs
       0 milliseconds generating the C code
      33 milliseconds formatting the C code via "clang-format-5.0"
gen unchanged:  /etcetera/wuffs/gen/c/wuffs-std-gzip.c
gen unchanged:  /etcetera/wuffs/gen/wuffs/std/gzip.wuffs
       4 milliseconds generating the C code
     135 milliseconds formatting the C code via "clang-format-5.0"
gen unchanged:  /etcetera/wuffs/gen/c/wuffs-std-json.c
gen unchanged:  /etcetera/wuffs/gen/wuffs/std/json.wuffs
       0 milliseconds generating the C code
      44 milliseconds formatting the C code via "clang-format-5.0"
gen unchanged:  /etcetera/wuffs/gen/c/wuffs-std-wbmp.c
gen unchanged:  /etcetera/wuffs/gen/wuffs/std/wbmp.wuffs
       0 milliseconds generating the C code
      32 milliseconds formatting the C code via "clang-format-5.0"
gen unchanged:  /etcetera/wuffs/gen/c/wuffs-std-zlib.c
gen unchanged:  /etcetera/wuffs/gen/wuffs/std/zlib.wuffs
       3 milliseconds collecting the C code
    1173 milliseconds formatting the C code via "clang-format-5.0"
gen unchanged:  /etcetera/wuffs/release/c/wuffs-unsupported-snapshot.c

real	0m2.849s
user	0m2.674s
sys	0m0.278s
----
2020-06-03 12:30:47 +10:00
Nigel Tao 71528b33dd Rename frame_config.update to frame_config.set 2020-06-03 11:34:57 +10:00
Nigel Tao 6c83516afa Ensure that you cannot return a suspension 2020-06-03 11:08:23 +10:00
Nigel Tao ed9025c8dd Make swizzle_etc_reader sign conversion explicit 2020-06-02 23:29:42 +10:00
Nigel Tao f73fc7721a Replace wuffs_base__make_status(x).repr with x 2020-06-02 23:25:47 +10:00
Nigel Tao de1e274ad2 Remove io_reader.take 2020-06-02 23:08:24 +10:00
Nigel Tao 8b21a7600a Add swizzle_interleaved_from_reader 2020-06-02 23:04:22 +10:00
Nigel Tao d7c9e9bbc9 De-duplicate the wuffs_gif_decode test function 2020-06-01 14:33:19 +10:00
Nigel Tao e6b7c51557 Inline do_bench_gif_decode 2020-06-01 14:23:59 +10:00
Nigel Tao 829519880a Drop unnecessary memcpy in do_bench_image_decode
This doesn't affect the std/bmp or std/gif implementations per se, only
the code that benches them. Prior to this commit, the source file was
first decoded into a pixel buffer and then always copied from the
(2-dimensional) wuffs_base__pixel_buffer to a (1-dimensional)
wuffs_base_io_buffer. That copy is useful for *tests*, which compare
that io_buffer's contents to a known good result (i.e. a separate I/O
buffer filled with the contents of a golden file), but it isn't
necessary for *benches*. Dropping that unnecessary copy reduces the
total time per iteration, and therefore increases the reported speed.

name                                        old speed      new speed       delta

wuffs_bmp_decode_40k/clang5                 2.09GB/s ± 2%   2.48GB/s ± 0%  +18.78%  (p=0.008 n=5+5)

wuffs_bmp_decode_40k/gcc7                   1.73GB/s ± 1%   1.93GB/s ± 0%  +11.54%  (p=0.008 n=5+5)

wuffs_gif_decode_1k_bw/clang5                291MB/s ± 0%    376MB/s ± 1%  +29.14%  (p=0.008 n=5+5)
wuffs_gif_decode_1k_color_full_init/clang5  95.3MB/s ± 1%  103.2MB/s ± 1%   +8.37%  (p=0.008 n=5+5)
wuffs_gif_decode_1k_color_part_init/clang5   117MB/s ± 0%    130MB/s ± 0%  +10.68%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_bgra/clang5             469MB/s ± 0%    489MB/s ± 1%   +4.39%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_indexed/clang5          126MB/s ± 1%    130MB/s ± 1%   +3.50%  (p=0.008 n=5+5)
wuffs_gif_decode_20k/clang5                  152MB/s ± 0%    156MB/s ± 1%   +2.77%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_artificial/clang5      318MB/s ± 0%    329MB/s ± 0%   +3.53%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_realistic/clang5       137MB/s ± 0%    139MB/s ± 0%   +1.40%  (p=0.008 n=5+5)
wuffs_gif_decode_1000k_full_init/clang5      138MB/s ± 0%    140MB/s ± 1%   +1.45%  (p=0.008 n=5+5)
wuffs_gif_decode_1000k_part_init/clang5      139MB/s ± 0%    140MB/s ± 1%   +1.03%  (p=0.008 n=5+5)
wuffs_gif_decode_anim_screencap/clang5       661MB/s ± 0%    747MB/s ± 1%  +13.08%  (p=0.008 n=5+5)

mimic_gif_decode_1k_bw/clang5               92.0MB/s ± 0%   91.9MB/s ± 1%     ~     (p=0.841 n=5+5)
mimic_gif_decode_1k_color/clang5            45.5MB/s ± 0%   45.7MB/s ± 0%   +0.45%  (p=0.032 n=5+4)
mimic_gif_decode_10k_indexed/clang5         53.5MB/s ± 0%   53.7MB/s ± 0%   +0.31%  (p=0.032 n=5+4)
mimic_gif_decode_20k/clang5                 55.5MB/s ± 0%   55.1MB/s ± 2%     ~     (p=0.690 n=5+5)
mimic_gif_decode_100k_artificial/clang5     88.8MB/s ± 0%   89.0MB/s ± 1%     ~     (p=0.151 n=5+5)
mimic_gif_decode_100k_realistic/clang5      53.5MB/s ± 1%   53.7MB/s ± 0%   +0.31%  (p=0.024 n=5+5)
mimic_gif_decode_1000k/clang5               54.6MB/s ± 0%   54.6MB/s ± 1%     ~     (p=0.222 n=5+5)
mimic_gif_decode_anim_screencap/clang5       106MB/s ± 0%    109MB/s ± 0%   +2.59%  (p=0.008 n=5+5)

wuffs_gif_decode_1k_bw/gcc7                  284MB/s ± 0%    356MB/s ± 0%  +25.33%  (p=0.016 n=4+5)
wuffs_gif_decode_1k_color_full_init/gcc7    82.1MB/s ± 0%   95.3MB/s ± 0%  +16.08%  (p=0.008 n=5+5)
wuffs_gif_decode_1k_color_part_init/gcc7    97.5MB/s ± 0%  117.4MB/s ± 0%  +20.39%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_bgra/gcc7               345MB/s ± 0%    396MB/s ± 0%  +14.71%  (p=0.016 n=4+5)
wuffs_gif_decode_10k_indexed/gcc7            104MB/s ± 0%    121MB/s ± 0%  +16.38%  (p=0.008 n=5+5)
wuffs_gif_decode_20k/gcc7                    131MB/s ± 0%    149MB/s ± 0%  +13.55%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_artificial/gcc7        293MB/s ± 0%    321MB/s ± 1%   +9.77%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_realistic/gcc7         116MB/s ± 1%    130MB/s ± 1%  +12.10%  (p=0.008 n=5+5)
wuffs_gif_decode_1000k_full_init/gcc7        117MB/s ± 1%    132MB/s ± 1%  +12.53%  (p=0.008 n=5+5)
wuffs_gif_decode_1000k_part_init/gcc7        117MB/s ± 0%    132MB/s ± 1%  +12.20%  (p=0.008 n=5+5)
wuffs_gif_decode_anim_screencap/gcc7         615MB/s ± 2%    711MB/s ± 2%  +15.53%  (p=0.008 n=5+5)

mimic_gif_decode_1k_bw/gcc7                 91.4MB/s ± 0%   91.7MB/s ± 1%     ~     (p=0.095 n=5+5)
mimic_gif_decode_1k_color/gcc7              46.3MB/s ± 0%   46.2MB/s ± 2%     ~     (p=0.841 n=5+5)
mimic_gif_decode_10k_indexed/gcc7           51.9MB/s ± 1%   51.7MB/s ± 1%     ~     (p=0.310 n=5+5)
mimic_gif_decode_20k/gcc7                   54.2MB/s ± 0%   54.2MB/s ± 1%     ~     (p=0.421 n=5+5)
mimic_gif_decode_100k_artificial/gcc7       88.4MB/s ± 1%   88.7MB/s ± 1%     ~     (p=0.222 n=5+5)
mimic_gif_decode_100k_realistic/gcc7        53.7MB/s ± 0%   53.7MB/s ± 0%     ~     (p=0.206 n=5+5)
mimic_gif_decode_1000k/gcc7                 53.8MB/s ± 2%   54.0MB/s ± 2%     ~     (p=0.690 n=5+5)
mimic_gif_decode_anim_screencap/gcc7         106MB/s ± 0%    109MB/s ± 0%   +2.79%  (p=0.008 n=5+5)
2020-06-01 13:59:50 +10:00
Nigel Tao 4b9b971436 Harmonize do_bench_{gif,image}_decode 2020-06-01 13:27:46 +10:00
Nigel Tao 2784613b49 Add n_bytes_out arg to gif bench functions 2020-06-01 13:14:14 +10:00
Nigel Tao 7a85f67b22 Add std/bmp benchmark 2020-06-01 13:03:03 +10:00
Nigel Tao 54196c4e80 Rename pixel_swizzler.swizzle_interleaved 2020-05-29 16:54:05 +10:00
Nigel Tao 6537a817b7 Roll back the two previous "@I/O redirect" commits
See the previous commit for the rationale.
2020-05-29 11:27:51 +10:00
Nigel Tao 49023afd48 Performance mystery: delete unused string constant
This commit deletes the definition of the `const char*
wuffs_base__note__i_o_redirect` global variable. This variable is not
used anywhere (after the previous commit removed references to it).

Deleting this one line of code (two if you count the declaration, not
just the definition) can have a dramatic effect on seemingly unrelated
performance micro-benchmarks. Some numbers get better (e.g. +5%), some
numbers get worse (e.g. -10%). The same micro-benchmark can get faster
on one C compiler but slower on another.

It is a mystery why this happens. This small, self-contained commit (as
well as the previous one, which set it up) will be immediately followed
by a roll back, but it is committed anyway so that we can refer to these
numbers in the git log. To reproduce:

----
$ git clone https://github.com/google/wuffs.git
$ cd wuffs
$ gcc --version | head -n 1
gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0

$ # Check out the parent commit.
$ git checkout --quiet THE_HASH_OF_THIS_COMMIT^
$ gcc -O3 -Wall -std=c99 test/c/std/json.c -DWUFFS_MIMIC
$ ./a.out -bench -focus=wuffs_json_decode_1k | grep MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1125 ns/op	     756.762 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1131 ns/op	     752.652 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1131 ns/op	     752.785 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1131 ns/op	     752.697 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1132 ns/op	     752.365 MB/s

$ # Check out this commit.
$ git checkout --quiet THE_HASH_OF_THIS_COMMIT
$ gcc -O3 -Wall -std=c99 test/c/std/json.c -DWUFFS_MIMIC
$ ./a.out -bench -focus=wuffs_json_decode_1k | grep MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1200 ns/op	     709.617 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1203 ns/op	     707.651 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1203 ns/op	     707.976 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1233 ns/op	     690.663 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1203 ns/op	     708.153 MB/s

$ # Dropping the "-std=c99" also changes the numbers.

$ # Check out the parent commit.
$ git checkout --quiet THE_HASH_OF_THIS_COMMIT^
$ gcc -O3 -Wall          test/c/std/json.c -DWUFFS_MIMIC
$ ./a.out -bench -focus=wuffs_json_decode_1k | grep MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1229 ns/op	     693.226 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1230 ns/op	     692.254 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1230 ns/op	     692.486 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1234 ns/op	     689.986 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1232 ns/op	     691.480 MB/s

$ # Check out this commit.
$ git checkout --quiet THE_HASH_OF_THIS_COMMIT
$ gcc -O3 -Wall          test/c/std/json.c -DWUFFS_MIMIC
$ ./a.out -bench -focus=wuffs_json_decode_1k | grep MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1129 ns/op	     754.103 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1131 ns/op	     752.849 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1135 ns/op	     750.622 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1150 ns/op	     740.731 MB/s
Benchmarkwuffs_json_decode_1k/gcc7	 1000000	    1135 ns/op	     750.609 MB/s

$ ldd ./a.out
	linux-vdso.so.1 (0x00007ffd9b1f2000)
	libgtk3-nocsd.so.0 => /usr/lib/x86_64-linux-gnu/libgtk3-nocsd.so.0 (0x00007f9b46f60000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f9b46b6f000)
	libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f9b4696b000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f9b4674c000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f9b5b59a000)
$ rm a.out
----

Some more benchmark numbers before/after this commit:

----
name                                                old speed      new speed      delta

wuffs_deflate_decode_1k_full_init/clang5             103MB/s ± 1%   105MB/s ± 1%   +2.25%  (p=0.000 n=9+10)
wuffs_deflate_decode_1k_part_init/clang5             121MB/s ± 0%   122MB/s ± 0%     ~     (p=1.000 n=9+9)
wuffs_deflate_decode_10k_full_init/clang5            148MB/s ± 1%   149MB/s ± 0%     ~     (p=0.059 n=9+8)
wuffs_deflate_decode_10k_part_init/clang5            151MB/s ± 0%   151MB/s ± 0%     ~     (p=0.968 n=9+10)
wuffs_deflate_decode_100k_just_one_read/clang5       172MB/s ± 0%   171MB/s ± 1%   -0.44%  (p=0.001 n=9+9)
wuffs_deflate_decode_100k_many_big_reads/clang5      149MB/s ± 0%   149MB/s ± 1%   -0.56%  (p=0.000 n=10+9)

wuffs_deflate_decode_1k_full_init/gcc7               104MB/s ± 1%   102MB/s ± 1%   -2.45%  (p=0.000 n=9+10)
wuffs_deflate_decode_1k_part_init/gcc7               121MB/s ± 0%   121MB/s ± 0%   +0.46%  (p=0.000 n=9+10)
wuffs_deflate_decode_10k_full_init/gcc7              147MB/s ± 0%   153MB/s ± 0%   +3.75%  (p=0.000 n=8+10)
wuffs_deflate_decode_10k_part_init/gcc7              150MB/s ± 1%   155MB/s ± 0%   +3.98%  (p=0.000 n=9+10)
wuffs_deflate_decode_100k_just_one_read/gcc7         184MB/s ± 0%   194MB/s ± 1%   +5.43%  (p=0.000 n=9+10)
wuffs_deflate_decode_100k_many_big_reads/gcc7        154MB/s ± 0%   158MB/s ± 0%   +2.45%  (p=0.000 n=9+10)

wuffs_gif_decode_1k_bw/clang5                        281MB/s ± 1%   278MB/s ± 1%   -0.92%  (p=0.003 n=10+9)
wuffs_gif_decode_1k_color_full_init/clang5          97.8MB/s ± 1%  93.7MB/s ± 3%   -4.26%  (p=0.000 n=10+10)
wuffs_gif_decode_1k_color_part_init/clang5           117MB/s ± 1%   115MB/s ± 1%   -1.41%  (p=0.000 n=9+10)
wuffs_gif_decode_10k_bgra/clang5                     463MB/s ± 1%   455MB/s ± 1%   -1.68%  (p=0.000 n=10+10)
wuffs_gif_decode_10k_indexed/clang5                  124MB/s ± 1%   121MB/s ± 1%   -2.31%  (p=0.000 n=9+9)
wuffs_gif_decode_20k/clang5                          149MB/s ± 1%   146MB/s ± 1%   -1.95%  (p=0.000 n=10+10)
wuffs_gif_decode_100k_artificial/clang5              313MB/s ± 1%   307MB/s ± 0%   -1.94%  (p=0.000 n=9+7)
wuffs_gif_decode_100k_realistic/clang5               135MB/s ± 1%   133MB/s ± 1%   -1.18%  (p=0.000 n=10+8)
wuffs_gif_decode_1000k_full_init/clang5              136MB/s ± 1%   132MB/s ± 4%   -2.27%  (p=0.023 n=10+10)
wuffs_gif_decode_1000k_part_init/clang5              136MB/s ± 1%   132MB/s ± 3%   -2.96%  (p=0.000 n=9+10)
wuffs_gif_decode_anim_screencap/clang5               644MB/s ± 1%   621MB/s ± 3%   -3.51%  (p=0.000 n=10+10)

wuffs_gif_decode_1k_bw/gcc7                          290MB/s ± 1%   287MB/s ± 1%   -1.18%  (p=0.000 n=10+10)
wuffs_gif_decode_1k_color_full_init/gcc7            91.7MB/s ± 1%  88.2MB/s ± 1%   -3.85%  (p=0.000 n=10+10)
wuffs_gif_decode_1k_color_part_init/gcc7             107MB/s ± 1%   103MB/s ± 1%   -4.12%  (p=0.000 n=9+10)
wuffs_gif_decode_10k_bgra/gcc7                       370MB/s ± 1%   344MB/s ± 1%   -6.98%  (p=0.000 n=10+9)
wuffs_gif_decode_10k_indexed/gcc7                    113MB/s ± 2%   104MB/s ± 1%   -8.31%  (p=0.000 n=10+8)
wuffs_gif_decode_20k/gcc7                            139MB/s ± 1%   127MB/s ± 3%   -8.49%  (p=0.000 n=10+10)
wuffs_gif_decode_100k_artificial/gcc7                299MB/s ± 0%   280MB/s ± 1%   -6.43%  (p=0.000 n=9+8)
wuffs_gif_decode_100k_realistic/gcc7                 123MB/s ± 1%   111MB/s ± 1%  -10.21%  (p=0.000 n=10+8)
wuffs_gif_decode_1000k_full_init/gcc7                124MB/s ± 1%   112MB/s ± 1%   -9.34%  (p=0.000 n=10+8)
wuffs_gif_decode_1000k_part_init/gcc7                125MB/s ± 1%   112MB/s ± 1%  -10.19%  (p=0.000 n=10+9)
wuffs_gif_decode_anim_screencap/gcc7                 622MB/s ± 1%   599MB/s ± 3%   -3.68%  (p=0.000 n=9+10)

wuffs_json_decode_1k/clang5                          628MB/s ± 1%   628MB/s ± 1%     ~     (p=0.842 n=9+10)
wuffs_json_decode_21k_formatted/clang5               331MB/s ± 1%   331MB/s ± 0%     ~     (p=0.720 n=10+9)
wuffs_json_decode_26k_compact/clang5                 521MB/s ± 1%   521MB/s ± 0%     ~     (p=0.549 n=10+9)
wuffs_json_decode_217k_stringy/clang5                432MB/s ± 1%   432MB/s ± 1%     ~     (p=0.780 n=10+9)

wuffs_json_decode_1k/gcc7                            745MB/s ± 0%   703MB/s ± 0%   -5.70%  (p=0.000 n=9+10)
wuffs_json_decode_21k_formatted/gcc7                 418MB/s ± 1%   400MB/s ± 1%   -4.44%  (p=0.000 n=10+8)
wuffs_json_decode_26k_compact/gcc7                   554MB/s ± 1%   511MB/s ± 1%   -7.72%  (p=0.000 n=9+10)
wuffs_json_decode_217k_stringy/gcc7                  452MB/s ± 1%   422MB/s ± 1%   -6.58%  (p=0.000 n=9+10)
----
2020-05-29 11:21:32 +10:00
Nigel Tao 844fc9b5ee Temporarily avoid using base."@I/O redirect"
This commit (and the next) will soon be followed by a rollback.
2020-05-29 09:53:30 +10:00
Nigel Tao 302afb7ce5 Add const to wuffs_base__pixel_swizzler__func arg 2020-05-28 00:07:45 +10:00
Nigel Tao 91dcf8f582 Add io_reader.limited_copy_u32_to_slice 2020-05-27 23:47:10 +10:00
Nigel Tao 5a27e95cb8 Delete superfluous frame_config.duration comment 2020-05-27 23:31:31 +10:00
Nigel Tao 8b70ad0565 Rename skip32 to skip_u32 2020-05-27 23:29:20 +10:00
Nigel Tao 1ed0f89948 Rename copy_n32_etc to limited_copy_u32_etc 2020-05-27 19:55:06 +10:00
Nigel Tao e74fd729a7 Re-organize internal/cgen/base/io-private.h 2020-05-27 17:06:47 +10:00
Nigel Tao 055e944584 Make cgen io_reader pointers' elements const 2020-05-27 14:28:31 +10:00
Nigel Tao dcb81a85bb Prepare to decode BMP embedding a JPEG or PNG 2020-05-27 13:37:54 +10:00
Nigel Tao 1239280ad8 Roll back 'dst_palette into the pixel_swizzler'
See the previous commit for the rationale.
2020-05-26 14:13:28 +10:00
Nigel Tao 2d8ec9ace9 Roll dst_palette into the pixel_swizzler struct
This commit will soon be followed by a rollback, but it is committed
anyway so that we can refer to these numbers in the git log.

name                                        old speed      new speed      delta

wuffs_gif_decode_1k_bw/clang5                286MB/s ± 1%   251MB/s ± 0%  -12.11%  (p=0.000 n=10+9)
wuffs_gif_decode_1k_color_full_init/clang5  96.0MB/s ± 0%  88.9MB/s ± 0%   -7.35%  (p=0.000 n=10+10)
wuffs_gif_decode_1k_color_part_init/clang5   119MB/s ± 0%   108MB/s ± 0%   -9.06%  (p=0.000 n=10+8)
wuffs_gif_decode_10k_bgra/clang5             469MB/s ± 1%   438MB/s ± 0%   -6.50%  (p=0.000 n=10+8)
wuffs_gif_decode_10k_indexed/clang5          125MB/s ± 1%   117MB/s ± 1%   -6.78%  (p=0.000 n=9+9)
wuffs_gif_decode_20k/clang5                  153MB/s ± 0%   139MB/s ± 0%   -9.40%  (p=0.000 n=9+9)
wuffs_gif_decode_100k_artificial/clang5      324MB/s ± 0%   304MB/s ± 0%   -6.22%  (p=0.000 n=10+9)
wuffs_gif_decode_100k_realistic/clang5       139MB/s ± 1%   125MB/s ± 1%   -9.69%  (p=0.000 n=9+10)
wuffs_gif_decode_1000k_full_init/clang5      141MB/s ± 0%   126MB/s ± 0%  -10.40%  (p=0.000 n=10+10)
wuffs_gif_decode_1000k_part_init/clang5      141MB/s ± 1%   126MB/s ± 0%  -10.50%  (p=0.000 n=10+8)
wuffs_gif_decode_anim_screencap/clang5       655MB/s ± 0%   617MB/s ± 1%   -5.91%  (p=0.000 n=9+9)

wuffs_gif_decode_1k_bw/gcc7                  299MB/s ± 0%   295MB/s ± 0%   -1.18%  (p=0.000 n=10+8)
wuffs_gif_decode_1k_color_full_init/gcc7    85.2MB/s ± 1%  88.2MB/s ± 0%   +3.58%  (p=0.000 n=10+10)
wuffs_gif_decode_1k_color_part_init/gcc7     104MB/s ± 0%   103MB/s ± 0%   -0.39%  (p=0.001 n=9+10)
wuffs_gif_decode_10k_bgra/gcc7               349MB/s ± 2%   352MB/s ± 0%   +0.77%  (p=0.000 n=9+10)
wuffs_gif_decode_10k_indexed/gcc7            106MB/s ± 0%   106MB/s ± 2%     ~     (p=0.762 n=8+10)
wuffs_gif_decode_20k/gcc7                    133MB/s ± 0%   133MB/s ± 0%     ~     (p=0.258 n=9+9)
wuffs_gif_decode_100k_artificial/gcc7        302MB/s ± 0%   301MB/s ± 1%   -0.41%  (p=0.035 n=10+10)
wuffs_gif_decode_100k_realistic/gcc7         118MB/s ± 1%   118MB/s ± 1%     ~     (p=0.095 n=9+10)
wuffs_gif_decode_1000k_full_init/gcc7        120MB/s ± 1%   119MB/s ± 0%   -0.34%  (p=0.007 n=10+10)
wuffs_gif_decode_1000k_part_init/gcc7        119MB/s ± 1%   119MB/s ± 1%     ~     (p=0.138 n=10+10)
wuffs_gif_decode_anim_screencap/gcc7         640MB/s ± 0%   640MB/s ± 0%     ~     (p=0.905 n=9+10)
2020-05-26 14:07:30 +10:00
Nigel Tao 3afdd91acb Make wuffs_base__load_etc arg const 2020-05-26 13:57:17 +10:00
Nigel Tao bc546b7383 Move more base funcs to the pixconv sub-module
$ ls -l gen/lib/c/*/{lib*,*base*} | awk '{print $5 " " $9}'

Before:
167976 gen/lib/c/clang-5.0-dynamic/libwuffs.so
 13944 gen/lib/c/clang-5.0-dynamic/wuffs-base-core.lo
 11640 gen/lib/c/clang-5.0-dynamic/wuffs-base-pixconv.lo
207150 gen/lib/c/clang-5.0-static/libwuffs.a
 14240 gen/lib/c/clang-5.0-static/wuffs-base-core.o
 12096 gen/lib/c/clang-5.0-static/wuffs-base-pixconv.o
188088 gen/lib/c/gcc-dynamic/libwuffs.so
 13296 gen/lib/c/gcc-dynamic/wuffs-base-core.lo
 27232 gen/lib/c/gcc-dynamic/wuffs-base-pixconv.lo
234766 gen/lib/c/gcc-static/libwuffs.a
 13432 gen/lib/c/gcc-static/wuffs-base-core.o
 27216 gen/lib/c/gcc-static/wuffs-base-pixconv.o

After:
167976 gen/lib/c/clang-5.0-dynamic/libwuffs.so
 11376 gen/lib/c/clang-5.0-dynamic/wuffs-base-core.lo
 14328 gen/lib/c/clang-5.0-dynamic/wuffs-base-pixconv.lo
207270 gen/lib/c/clang-5.0-static/libwuffs.a
 11696 gen/lib/c/clang-5.0-static/wuffs-base-core.o
 14760 gen/lib/c/clang-5.0-static/wuffs-base-pixconv.o
188088 gen/lib/c/gcc-dynamic/libwuffs.so
 10680 gen/lib/c/gcc-dynamic/wuffs-base-core.lo
 29968 gen/lib/c/gcc-dynamic/wuffs-base-pixconv.lo
234886 gen/lib/c/gcc-static/libwuffs.a
 10856 gen/lib/c/gcc-static/wuffs-base-core.o
 29912 gen/lib/c/gcc-static/wuffs-base-pixconv.o
2020-05-26 11:54:36 +10:00
Nigel Tao 4d3a65763e Spin out base-interfaces sub-module
$ ls -l gen/lib/c/*/{lib*,*base*} | awk '{print $5 " " $9}'

Before:
167952 gen/lib/c/clang-5.0-dynamic/libwuffs.so
 20664 gen/lib/c/clang-5.0-dynamic/wuffs-base-core.lo
205656 gen/lib/c/clang-5.0-static/libwuffs.a
 20960 gen/lib/c/clang-5.0-static/wuffs-base-core.o
188064 gen/lib/c/gcc-dynamic/libwuffs.so
 18936 gen/lib/c/gcc-dynamic/wuffs-base-core.lo
232976 gen/lib/c/gcc-static/libwuffs.a
 18920 gen/lib/c/gcc-static/wuffs-base-core.o

After:
167976 gen/lib/c/clang-5.0-dynamic/libwuffs.so
 13944 gen/lib/c/clang-5.0-dynamic/wuffs-base-core.lo
  8128 gen/lib/c/clang-5.0-dynamic/wuffs-base-interfaces.lo
207150 gen/lib/c/clang-5.0-static/libwuffs.a
 14240 gen/lib/c/clang-5.0-static/wuffs-base-core.o
  8128 gen/lib/c/clang-5.0-static/wuffs-base-interfaces.o
188088 gen/lib/c/gcc-dynamic/libwuffs.so
 13296 gen/lib/c/gcc-dynamic/wuffs-base-core.lo
  7384 gen/lib/c/gcc-dynamic/wuffs-base-interfaces.lo
234766 gen/lib/c/gcc-static/libwuffs.a
 13432 gen/lib/c/gcc-static/wuffs-base-core.o
  7192 gen/lib/c/gcc-static/wuffs-base-interfaces.o
2020-05-26 11:43:54 +10:00
Nigel Tao 04ab8868bd Add some more WUFFS_BASE__MAYBE_STATIC's to base 2020-05-26 11:02:31 +10:00
Nigel Tao 092b03cd1e Add WUFFS_CONFIG__MODULE__BASE__ETC sub-modules
$ ls -l gen/lib/c/*/{lib*,*base*} | awk '{print $5 " " $9}'

Before:
167976 gen/lib/c/clang-5.0-dynamic/libwuffs.so
 40824 gen/lib/c/clang-5.0-dynamic/wuffs-base.lo
203306 gen/lib/c/clang-5.0-static/libwuffs.a
 41816 gen/lib/c/clang-5.0-static/wuffs-base.o
188080 gen/lib/c/gcc-dynamic/libwuffs.so
 53976 gen/lib/c/gcc-dynamic/wuffs-base.lo
230002 gen/lib/c/gcc-static/libwuffs.a
 53976 gen/lib/c/gcc-static/wuffs-base.o

After:
168024 gen/lib/c/clang-5.0-dynamic/libwuffs.so
 20664 gen/lib/c/clang-5.0-dynamic/wuffs-base-core.lo
 10784 gen/lib/c/clang-5.0-dynamic/wuffs-base-f64conv.lo
 11640 gen/lib/c/clang-5.0-dynamic/wuffs-base-pixconv.lo
205752 gen/lib/c/clang-5.0-static/libwuffs.a
 20960 gen/lib/c/clang-5.0-static/wuffs-base-core.o
 11024 gen/lib/c/clang-5.0-static/wuffs-base-f64conv.o
 12096 gen/lib/c/clang-5.0-static/wuffs-base-pixconv.o
188128 gen/lib/c/gcc-dynamic/libwuffs.so
 18936 gen/lib/c/gcc-dynamic/wuffs-base-core.lo
 10672 gen/lib/c/gcc-dynamic/wuffs-base-f64conv.lo
 27232 gen/lib/c/gcc-dynamic/wuffs-base-pixconv.lo
232984 gen/lib/c/gcc-static/libwuffs.a
 18920 gen/lib/c/gcc-static/wuffs-base-core.o
 10640 gen/lib/c/gcc-static/wuffs-base-f64conv.o
 27216 gen/lib/c/gcc-static/wuffs-base-pixconv.o
2020-05-25 23:01:11 +10:00
Nigel Tao 43db33a345 Prepare to spin out base submodules 2020-05-25 22:44:29 +10:00