Commit Graph
195 Commits
Author SHA1 Message Date
Nigel Tao f34d189236 Collapse trivial io_{reader,writer} buffer field 2019-07-06 16:47:47 +10:00
Nigel Tao e5f535db4f Remove set_{reader,writer}_limit in test/c code 2019-07-06 08:43:41 +10:00
Nigel Tao 881474be5a Remove "0 means no I/O limit" in tests 2019-07-06 08:41:46 +10:00
Nigel Tao 0b1f43834f Let GIF decode BGR/RGB, not just BGRA/RGBA 2019-06-09 08:42:13 +10:00
Nigel Tao ba3db0d7e5 Have test/c/std/gif use frame background colors 2019-06-01 09:06:02 +10:00
Nigel Tao 73fcd7e502 Rename wuffs_gif__quirk_background_is_opaque 2019-05-26 17:43:58 +10:00
Nigel Tao 08dd41aa93 Tweak wuffs_gif__quirk_reject_empty_frame 2019-05-26 16:25:01 +10:00
Nigel Tao 143b19c564 Add wuffs_gif__quirk_reject_empty_frame 2019-05-26 13:12:22 +10:00
Nigel Tao ded9ffb0c0 Add wuffs_gif__quirk_delay_num_decoded_frames 2019-05-26 09:01:20 +10:00
Nigel Tao 5780b406dc Fix ignore_too_much_pixel_data infinite loop 2019-05-25 12:31:43 +10:00
Nigel Tao 31a2bc918e Let GIF decode an opaque but non-black background 2019-05-21 08:53:35 +10:00
Nigel Tao b1ff27fded Decode multiple graphic controls in a GIF 2019-05-12 22:02:39 +10:00
Nigel Tao 24a2f12c30 Add wuffs_gif__quirk_ignore_too_much_pixel_data 2019-05-04 14:04:28 +10:00
Nigel Tao 746681ea68 Add wuffs_gif__quirk_reject_empty_palette 2019-05-04 13:49:22 +10:00
Nigel Tao 1311445408 Add wuffs_gif__quirk_initial_background_is_opaque 2019-05-04 12:35:37 +10:00
Nigel Tao 941cecca8c Add wuffs_gif__quirk_image_bounds_are_strict 2019-05-04 12:19:52 +10:00
Nigel Tao 842500d51c Report ICCP metadata 2019-04-20 16:48:18 +10:00
Nigel Tao 21f2890217 Report image metadata such as ICCP and XMP 2019-04-20 16:33:11 +10:00
Nigel Tao ffeb2bff63 Split benchmarks for full / partial initialization 2019-02-24 16:54:19 +11:00
Nigel Tao 3c254cb5f5 Rename gif "not enough / too much" data tests 2019-02-24 11:31:37 +11:00
Nigel Tao 917a94b445 Add "gif-pixel-data-none" test 2019-02-24 11:28:11 +11:00
Nigel Tao dd861416ff Allow calling pure functions after seeing an error
Updates #20
2019-02-24 11:13:51 +11:00
Nigel Tao 045f180a6c Rename errors from "?msg" to "#msg" 2019-02-23 17:06:24 +11:00
Nigel Tao 8b41881ba7 Rename gif's "too much pixel data" 2019-02-23 14:34:06 +11:00
Nigel Tao d7f434c6e4 Have the GIF decoder check for "not enough data"
Fixes #20
2019-02-23 14:29:16 +11:00
Nigel Tao b41f121d20 Make "uninitialized internal buffers" explicit 2019-02-16 14:02:32 +11:00
Nigel Tao 8ff151ce2d Fix std/gif tests for recent workbuf_len tweak 2019-02-16 13:49:44 +11:00
Nigel Tao 37a5ead3b7 Have tests let the initializers memset to zero 2019-02-10 14:08:21 +11:00
Nigel Tao 0ab52c6204 Move cgen's sub-structs to private_data
name                                             old speed      new speed      delta

wuffs_gif_decode_1k_bw/clang5                     243MB/s ± 1%   243MB/s ± 1%    ~     (p=0.101 n=47+48)
wuffs_gif_decode_1k_color/clang5                  142MB/s ± 1%   142MB/s ± 1%  +0.36%  (p=0.000 n=48+47)
wuffs_gif_decode_10k_bgra/clang5                  734MB/s ± 1%   728MB/s ± 1%  -0.78%  (p=0.000 n=46+50)
wuffs_gif_decode_10k_indexed/clang5               197MB/s ± 0%   196MB/s ± 1%  -0.52%  (p=0.000 n=47+46)
wuffs_gif_decode_20k/clang5                       250MB/s ± 1%   249MB/s ± 1%    ~     (p=0.189 n=49+46)
wuffs_gif_decode_100k_artificial/clang5           556MB/s ± 1%   555MB/s ± 1%  -0.23%  (p=0.000 n=46+44)
wuffs_gif_decode_100k_realistic/clang5            229MB/s ± 1%   229MB/s ± 0%    ~     (p=0.055 n=48+48)
wuffs_gif_decode_1000k/clang5                     233MB/s ± 1%   234MB/s ± 0%  +0.30%  (p=0.000 n=48+45)
wuffs_gif_decode_anim_screencap/clang5           1.11GB/s ± 1%  1.10GB/s ± 0%  -0.28%  (p=0.000 n=46+47)

wuffs_gif_decode_1k_bw/gcc7                       257MB/s ± 2%   263MB/s ± 1%  +2.67%  (p=0.000 n=49+47)
wuffs_gif_decode_1k_color/gcc7                    142MB/s ± 1%   146MB/s ± 1%  +3.25%  (p=0.000 n=50+49)
wuffs_gif_decode_10k_bgra/gcc7                    627MB/s ± 1%   625MB/s ± 1%  -0.35%  (p=0.000 n=48+49)
wuffs_gif_decode_10k_indexed/gcc7                 197MB/s ± 1%   196MB/s ± 1%  -0.21%  (p=0.000 n=48+43)
wuffs_gif_decode_20k/gcc7                         239MB/s ± 0%   239MB/s ± 1%  +0.21%  (p=0.000 n=50+47)
wuffs_gif_decode_100k_artificial/gcc7             511MB/s ± 0%   512MB/s ± 1%  +0.21%  (p=0.000 n=49+44)
wuffs_gif_decode_100k_realistic/gcc7              211MB/s ± 0%   212MB/s ± 1%  +0.39%  (p=0.000 n=45+44)
wuffs_gif_decode_1000k/gcc7                       215MB/s ± 0%   216MB/s ± 1%  +0.13%  (p=0.002 n=46+48)
wuffs_gif_decode_anim_screencap/gcc7             1.06GB/s ± 1%  1.06GB/s ± 1%  +0.12%  (p=0.007 n=45+48)

wuffs_lzw_decode_20k/clang5                       271MB/s ± 1%   270MB/s ± 1%  -0.34%  (p=0.000 n=49+49)
wuffs_lzw_decode_100k/clang5                      480MB/s ± 1%   478MB/s ± 1%  -0.31%  (p=0.001 n=48+50)

wuffs_lzw_decode_20k/gcc7                         263MB/s ± 1%   264MB/s ± 1%  +0.38%  (p=0.000 n=45+47)
wuffs_lzw_decode_100k/gcc7                        476MB/s ± 1%   482MB/s ± 2%  +1.30%  (p=0.000 n=47+50)
2019-02-10 11:22:04 +11:00
Nigel Tao 4f76d2f893 Rename some check_wuffs_version status messages 2019-02-09 14:56:27 +11:00
Nigel Tao 0842bc7115 Make the GIF dirty_rect be in the frame_rect
Updates https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11823
2019-02-09 13:56:24 +11:00
Nigel Tao 3056a84393 Roll back 3 recent lzw.decoder.suffixes commits
Specifically:
49627b4 Flatten the lzw.decoder.suffixes array
f877fb2 Use the workbuf instead of lzw.decoder.suffixes
85be5b9 Delete the obsolete lzw.decoder.suffixes array

name                                     old speed      new speed      delta

wuffs_lzw_decode_20k/clang5               247MB/s ± 0%   265MB/s ± 0%   +7.31%  (p=0.008 n=5+5)
wuffs_lzw_decode_100k/clang5              407MB/s ± 0%   452MB/s ± 1%  +11.21%  (p=0.008 n=5+5)

wuffs_lzw_decode_20k/gcc7                 238MB/s ± 1%   263MB/s ± 1%  +10.81%  (p=0.008 n=5+5)
wuffs_lzw_decode_100k/gcc7                384MB/s ± 0%   482MB/s ± 2%  +25.54%  (p=0.008 n=5+5)

wuffs_gif_decode_1k_bw/clang5             318MB/s ± 0%   241MB/s ± 1%  -24.15%  (p=0.008 n=5+5)
wuffs_gif_decode_1k_color/clang5          154MB/s ± 0%   141MB/s ± 1%   -8.58%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_bgra/clang5          697MB/s ± 1%   721MB/s ± 0%   +3.53%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_indexed/clang5       186MB/s ± 0%   194MB/s ± 1%   +4.20%  (p=0.008 n=5+5)
wuffs_gif_decode_20k/clang5               226MB/s ± 1%   246MB/s ± 1%   +8.85%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_artificial/clang5   508MB/s ± 1%   551MB/s ± 0%   +8.33%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_realistic/clang5    203MB/s ± 0%   227MB/s ± 0%  +11.88%  (p=0.008 n=5+5)
wuffs_gif_decode_1000k/clang5             206MB/s ± 0%   231MB/s ± 0%  +12.46%  (p=0.008 n=5+5)
wuffs_gif_decode_anim_screencap/clang5   1.03GB/s ± 0%  1.10GB/s ± 0%   +5.85%  (p=0.008 n=5+5)

wuffs_gif_decode_1k_bw/gcc7               398MB/s ± 0%   265MB/s ± 1%  -33.35%  (p=0.008 n=5+5)
wuffs_gif_decode_1k_color/gcc7            161MB/s ± 0%   145MB/s ± 1%   -9.74%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_bgra/gcc7            604MB/s ± 1%   622MB/s ± 1%   +2.94%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_indexed/gcc7         187MB/s ± 1%   194MB/s ± 0%   +3.83%  (p=0.008 n=5+5)
wuffs_gif_decode_20k/gcc7                 227MB/s ± 0%   234MB/s ± 1%   +3.09%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_artificial/gcc7     492MB/s ± 0%   506MB/s ± 1%   +2.91%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_realistic/gcc7      201MB/s ± 0%   210MB/s ± 1%   +4.42%  (p=0.008 n=5+5)
wuffs_gif_decode_1000k/gcc7               203MB/s ± 0%   213MB/s ± 0%   +4.97%  (p=0.008 n=5+5)
wuffs_gif_decode_anim_screencap/gcc7     1.04GB/s ± 0%  1.06GB/s ± 0%   +2.61%  (p=0.008 n=5+5)
2019-02-03 15:25:53 +11:00
Nigel Tao f877fb2c59 Use the workbuf instead of lzw.decoder.suffixes
This commit will soon be followed by a rollback, but it is committed
anyway so that we can refer to these numbers in the git log.

name                                     old speed      new speed      delta

wuffs_lzw_decode_20k/clang5               255MB/s ± 0%   241MB/s ± 0%   -5.63%  (p=0.008 n=5+5)
wuffs_lzw_decode_100k/clang5              418MB/s ± 1%   401MB/s ± 1%   -4.02%  (p=0.008 n=5+5)

wuffs_lzw_decode_20k/gcc7                 255MB/s ± 1%   235MB/s ± 0%   -7.88%  (p=0.008 n=5+5)
wuffs_lzw_decode_100k/gcc7                444MB/s ± 1%   382MB/s ± 0%  -13.90%  (p=0.008 n=5+5)

wuffs_gif_decode_1k_bw/clang5             239MB/s ± 2%   235MB/s ± 1%   -1.89%  (p=0.016 n=5+5)
wuffs_gif_decode_1k_color/clang5          135MB/s ± 0%   132MB/s ± 0%   -1.86%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_bgra/clang5          692MB/s ± 1%   678MB/s ± 0%   -2.08%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_indexed/clang5       186MB/s ± 0%   181MB/s ± 0%   -2.58%  (p=0.008 n=5+5)
wuffs_gif_decode_20k/clang5               237MB/s ± 1%   226MB/s ± 0%   -4.46%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_artificial/clang5   536MB/s ± 0%   506MB/s ± 0%   -5.53%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_realistic/clang5    219MB/s ± 0%   203MB/s ± 1%   -7.11%  (p=0.008 n=5+5)
wuffs_gif_decode_1000k/clang5             222MB/s ± 0%   206MB/s ± 0%   -7.25%  (p=0.008 n=5+5)
wuffs_gif_decode_anim_screencap/clang5   1.07GB/s ± 0%  1.04GB/s ± 1%   -3.11%  (p=0.008 n=5+5)

wuffs_gif_decode_1k_bw/gcc7               262MB/s ± 0%   255MB/s ± 1%   -2.63%  (p=0.008 n=5+5)
wuffs_gif_decode_1k_color/gcc7            142MB/s ± 1%   137MB/s ± 1%   -3.38%  (p=0.008 n=5+5)
wuffs_gif_decode_10k_bgra/gcc7            596MB/s ± 1%   593MB/s ± 0%     ~     (p=0.151 n=5+5)
wuffs_gif_decode_10k_indexed/gcc7         185MB/s ± 0%   182MB/s ± 2%   -1.63%  (p=0.008 n=5+5)
wuffs_gif_decode_20k/gcc7                 230MB/s ± 0%   226MB/s ± 0%   -1.78%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_artificial/gcc7     490MB/s ± 1%   488MB/s ± 0%     ~     (p=0.095 n=5+5)
wuffs_gif_decode_100k_realistic/gcc7      203MB/s ± 1%   203MB/s ± 0%     ~     (p=0.421 n=5+5)
wuffs_gif_decode_1000k/gcc7               207MB/s ± 0%   207MB/s ± 0%     ~     (p=1.000 n=5+5)
wuffs_gif_decode_anim_screencap/gcc7     1.04GB/s ± 0%  1.03GB/s ± 0%   -0.83%  (p=0.008 n=5+5)
2019-02-03 14:57:34 +11:00
Nigel Tao 670b45be53 Add some "horizontal rule" comment lines 2019-02-02 08:10:08 +11:00
Nigel Tao 65c2f4971f Rename some initialize methods to prepare or set 2019-01-26 15:46:42 +11:00
Nigel Tao ecccafab09 Add check for interleaved coroutines
It's not an optimization per se, but it seems to help:

name                                             old speed      new speed      delta

wuffs_deflate_decode_1k/clang5                    138MB/s ± 1%   150MB/s ± 1%   +8.96%  (p=0.008 n=5+5)
wuffs_deflate_decode_10k/clang5                   223MB/s ± 0%   243MB/s ± 0%   +9.25%  (p=0.008 n=5+5)
wuffs_deflate_decode_100k_just_one_read/clang5    263MB/s ± 2%   289MB/s ± 0%  +10.19%  (p=0.008 n=5+5)
wuffs_deflate_decode_100k_many_big_reads/clang5   220MB/s ± 1%   243MB/s ± 0%  +10.42%  (p=0.008 n=5+5)

wuffs_deflate_decode_1k/gcc7                      158MB/s ± 0%   157MB/s ± 0%     ~     (p=0.056 n=5+5)
wuffs_deflate_decode_10k/gcc7                     268MB/s ± 0%   268MB/s ± 0%     ~     (p=1.000 n=5+5)
wuffs_deflate_decode_100k_just_one_read/gcc7      312MB/s ± 0%   320MB/s ± 0%   +2.62%  (p=0.008 n=5+5)
wuffs_deflate_decode_100k_many_big_reads/gcc7     254MB/s ± 0%   253MB/s ± 0%   -0.48%  (p=0.016 n=5+5)
2019-01-26 15:33:43 +11:00
Nigel Tao c3a07db892 Add wuffs_gif_decode_20k benchmark
That GIF image's LZW-compressed data is the same as that used for the
wuffs_lzw_decode_20k benchmark. Comparing the two speeds gives some
indication of the relative overhead of the framing format, as well as
decoding to a richer data structure (2D table instead of a 1D array,
potentially to BGRA instead of palette-index, amongst other things).

name                        speed
wuffs_gif_decode_20k/clang  246MB/s ± 1%
wuffs_gif_decode_20k/gcc    234MB/s ± 1%
wuffs_lzw_decode_20k/clang  272MB/s ± 0%
wuffs_lzw_decode_20k/gcc    269MB/s ± 0%
2019-01-12 14:17:03 +11:00
Nigel Tao 11d7629efd Fix a "release/c/etc.c" comment typo 2018-12-29 15:20:38 +11:00
Nigel Tao dd94ad3821 Rename z variable to status, in C code 2018-12-28 16:14:03 +11:00
Nigel Tao 39a01cdc64 Flush std/gif when paused on the next block size 2018-12-22 16:51:46 +11:00
Nigel Tao 04c91f1410 Generate .c files instead of .h files
The files' contents haven't changed (other than some relative #include's
that refer to other .c files).

Some build systems have difficulty recognizing .h files as things to be
compiled, instead of just things referred to by things to be compiled.
2018-12-22 15:29:00 +11:00
Nigel Tao 529ebb0a61 Introduce binary alpha 2018-12-22 08:48:49 +11:00
Nigel Tao e497b38da0 Avoid test names being prefixes of other names 2018-12-15 13:58:22 +11:00
Nigel Tao f1c5bb6cb7 Add BGRA GIF benchmark, not just indexed color 2018-12-08 21:24:26 +11:00
Nigel Tao 45ab79b451 Allow GIF decoding to non-indexed pixel formats 2018-12-08 16:08:02 +11:00
Nigel Tao 8ab2a33aae Update GIF frame_dirty_rect more frequently
It's not an optimization per se, but for the record:

name                                    old speed     new speed     delta

wuffs_gif_decode_1k_bw/clang            260MB/s ± 1%  261MB/s ± 0%  +0.51%  (p=0.032 n=5+5)
wuffs_gif_decode_1k_color/clang         122MB/s ± 0%  123MB/s ± 1%    ~     (p=0.222 n=5+5)
wuffs_gif_decode_10k/clang              148MB/s ± 1%  148MB/s ± 0%    ~     (p=0.421 n=5+5)
wuffs_gif_decode_100k_artificial/clang  439MB/s ± 0%  443MB/s ± 1%  +0.99%  (p=0.008 n=5+5)
wuffs_gif_decode_100k_realistic/clang   174MB/s ± 1%  173MB/s ± 1%    ~     (p=0.151 n=5+5)
wuffs_gif_decode_1000k/clang            175MB/s ± 0%  175MB/s ± 0%  -0.30%  (p=0.016 n=4+5)
wuffs_gif_decode_anim_screencap/clang   941MB/s ± 1%  948MB/s ± 0%  +0.74%  (p=0.016 n=5+5)

wuffs_gif_decode_1k_bw/gcc              266MB/s ± 0%  273MB/s ± 0%  +2.60%  (p=0.008 n=5+5)
wuffs_gif_decode_1k_color/gcc           137MB/s ± 0%  139MB/s ± 0%  +1.54%  (p=0.008 n=5+5)
wuffs_gif_decode_10k/gcc                163MB/s ± 0%  162MB/s ± 0%    ~     (p=0.151 n=5+5)
wuffs_gif_decode_100k_artificial/gcc    457MB/s ± 0%  456MB/s ± 0%    ~     (p=0.095 n=5+5)
wuffs_gif_decode_100k_realistic/gcc     184MB/s ± 0%  182MB/s ± 0%  -1.02%  (p=0.008 n=5+5)
wuffs_gif_decode_1000k/gcc              186MB/s ± 0%  184MB/s ± 0%  -1.04%  (p=0.016 n=5+4)
wuffs_gif_decode_anim_screencap/gcc     985MB/s ± 1%  980MB/s ± 0%    ~     (p=0.095 n=5+5)
2018-11-24 10:17:16 +11:00
Nigel Tao c598e119e2 Add a gif.decoder.frame_dirty_rect test 2018-11-17 22:13:22 +11:00
Nigel Tao fc1002cb89 Implement gif.decoder.workbuf_len
Also relax decode_frame's workbuf length check from not-equals to
less-than.
2018-11-17 21:52:26 +11:00
Nigel Tao 3854ce3e89 Let test binaries run from any dir in the repo
Also spin out generate.WuffsRoot into its own package.
2018-11-03 08:46:31 +11:00
Nigel Tao 8d7bd36179 Add more GIF benchmarks
The existing benchmarks decoded realistic photos. The new benchmarks
also decode artificially generated images, which compress better.

Also adjust script/extract-giflzw.go to optionally analyze and print a
histogram of LZW code emission lengths. "Compresses better" is highly
correlated with "a lower proportion of literal (1 length) codes".
2018-10-21 11:46:37 +11:00