Commit Graph
170 Commits
Author SHA1 Message Date
Nigel Tao fb2430e765 Add some GIF per-frame fields 2018-02-15 12:41:13 +11:00
Nigel Tao 0d33d3ef3a Decode a GIF local color table 2018-02-11 15:30:18 +11:00
Nigel Tao 584fc631a8 Decode a GIF's loop count 2018-02-10 17:14:49 +11:00
Nigel Tao ded38a043a Add testdata/animated-red-blue.gif 2018-02-10 15:09:29 +11:00
Nigel Tao d3770b9972 Add an end of data concept 2018-02-10 12:13:26 +11:00
Nigel Tao bde5a6d39e Add testdata/muybridge.gif
Starting with the source image at:
https://en.wikipedia.org/wiki/File:Muybridge_race_horse_animated.gif

It was resized via:
gifsicle --use-colormap gray --resize 30x20 <etc >etc

The transparency-using frames were made stand-alone via:
convert etc -coalesce etc

A custom program re-mapped the palette indexes to the canonical
grayscale palette, so that palette index i means RGB (i, i, i), and
re-encoded the final GIF image. This program also generated the
*.indexes files.
2018-02-10 11:12:04 +11:00
Nigel Tao 7e90967717 Fill in a GIF image_config 2018-02-09 16:05:04 +11:00
Nigel Tao d750ea7653 Add an image_config concept 2018-02-09 14:46:37 +11:00
Nigel Tao de9000cc70 Add a call sequence concept 2018-02-08 09:06:19 +11:00
Nigel Tao 372618c817 Use the faster mimic_deflate API
name                             old speed     new speed     delta
mimic_deflate_decode_1k/gcc      217MB/s ± 1%  217MB/s ± 1%     ~     (p=1.000 n=5+5)
mimic_deflate_decode_10k/gcc     260MB/s ± 2%  263MB/s ± 1%     ~     (p=0.421 n=5+5)
mimic_deflate_decode_100k/gcc    277MB/s ± 1%  316MB/s ± 1%  +13.95%  (p=0.008 n=5+5)

Note that these numbers are for the C zlib library (these are "mimic"
numbers), not for the Wuffs code.
2018-01-05 18:22:25 +11:00
Nigel Tao f5c6204f09 Strip the prefix from base status messages 2017-12-27 14:45:54 +11:00
Nigel Tao 7e47f4cc7a Delegate etc__status__string to used packages 2017-12-27 13:49:05 +11:00
Nigel Tao 4877279ee7 Be able to test and bench the miniz library
For the record, benchstat numbers for 'old' being zlib-the-library and
'new' being miniz are below. Neither 'old' or 'new' is Wuffs code.

name                             old speed     new speed     delta
mimic_deflate_decode_1k/clang    217MB/s ± 1%  175MB/s ± 1%  -19.54%  (p=0.008 n=5+5)
mimic_deflate_decode_10k/clang   262MB/s ± 2%  222MB/s ± 0%  -15.34%  (p=0.008 n=5+5)
mimic_deflate_decode_100k/clang  281MB/s ± 1%  262MB/s ± 0%   -6.86%  (p=0.008 n=5+5)
mimic_deflate_decode_1k/gcc      220MB/s ± 1%  169MB/s ± 0%  -23.12%  (p=0.008 n=5+5)
mimic_deflate_decode_10k/gcc     267MB/s ± 0%  266MB/s ± 0%     ~     (p=0.222 n=5+5)
mimic_deflate_decode_100k/gcc    283MB/s ± 0%  282MB/s ± 1%     ~     (p=0.690 n=5+5)
mimic_zlib_decode_10k/clang      243MB/s ± 1%  197MB/s ± 1%  -18.68%  (p=0.008 n=5+5)
mimic_zlib_decode_100k/clang     287MB/s ± 1%  229MB/s ± 1%  -20.13%  (p=0.008 n=5+5)
mimic_zlib_decode_10k/gcc        243MB/s ± 0%  240MB/s ± 6%     ~     (p=0.730 n=5+5)
mimic_zlib_decode_100k/gcc       288MB/s ± 1%  260MB/s ± 0%   -9.51%  (p=0.008 n=5+5)
2017-12-15 11:33:35 +11:00
Nigel Tao 2e12a41414 Make std/gif's LZW decoder private 2017-12-08 16:18:35 +11:00
Nigel Tao afb879b000 Rename deflate-related testdata 2017-12-04 10:49:11 +11:00
Nigel Tao 8e2255916e Drop the "flate_" in "deflate.flate_decoder" 2017-12-04 10:35:08 +11:00
Nigel Tao 1388f84e5c Rename std/flate to std/deflate 2017-12-04 10:27:48 +11:00
Nigel Tao d168e6977b Rename test/c/mimiclib/flate.c 2017-12-03 14:34:41 +11:00
Nigel Tao 7e73a5ac5f Call initializers for out-of-pkg struct fields 2017-12-03 14:22:49 +11:00
Nigel Tao 6fec22c6d7 Move zlib tests from std/flate to std/zlib 2017-12-03 14:08:52 +11:00
Nigel Tao dd3f0b9ed4 Add a placeholder std/zlib package 2017-12-02 11:21:30 +11:00
Nigel Tao 56a2a926c5 Add comment about inlining C relative includes 2017-12-01 11:36:12 +11:00
Nigel Tao 3c708dfe59 Rename PUFFS to WUFFS, part 7 of N 2017-11-30 18:02:59 +11:00
Nigel Tao 79a94558be Rename PUFFS to WUFFS, part 5 of N 2017-11-30 16:37:20 +11:00
Nigel Tao 1910ca31cf Run the mimic checksum benchmarks for longer. 2017-11-08 12:46:57 +11:00
Nigel Tao 13731f989f Add a reader1.unread_u8 method.
Also re-enable a number of std/flate tests and benchmarks.

It's not an optimization per se, but as a data point, here are some
benchmark numbers between 36a93fa and this commit. 36a93fa is "36a93fa
Add a TODO about impure functions", which is one commit before "f968950
Read bits up front in decode_huffman_fast", and f968950 was the commit
that made decode_huffman_fast read more than one byte at a time.

name                             old speed      new speed       delta

puffs_adler32_10k/clang          2.45GB/s ± 0%   2.45GB/s ± 0%     ~     (p=0.684 n=10+10)
puffs_adler32_100k/clang         2.45GB/s ± 0%   2.46GB/s ± 0%   +0.07%  (p=0.019 n=10+10)
puffs_flate_decode_1k/clang       124MB/s ± 0%    132MB/s ± 0%   +6.06%  (p=0.000 n=10+10)
puffs_flate_decode_10k/clang      145MB/s ± 0%    174MB/s ± 0%  +20.19%  (p=0.000 n=9+10)
puffs_flate_decode_100k/clang     168MB/s ± 0%    208MB/s ± 0%  +23.31%  (p=0.000 n=10+10)
puffs_zlib_decode_10k/clang       136MB/s ± 0%    162MB/s ± 0%  +18.94%  (p=0.000 n=10+9)
puffs_zlib_decode_100k/clang      158MB/s ± 0%    192MB/s ± 0%  +21.58%  (p=0.000 n=10+9)

puffs_adler32_10k/gcc            3.26GB/s ± 0%   3.26GB/s ± 0%     ~     (p=0.631 n=10+10)
puffs_adler32_100k/gcc           3.27GB/s ± 0%   3.27GB/s ± 0%     ~     (p=0.237 n=10+8)
puffs_flate_decode_1k/gcc        95.3MB/s ± 0%  105.5MB/s ± 0%  +10.67%  (p=0.000 n=10+10)
puffs_flate_decode_10k/gcc        110MB/s ± 0%    140MB/s ± 0%  +27.32%  (p=0.000 n=9+9)
puffs_flate_decode_100k/gcc       121MB/s ± 0%    150MB/s ± 0%  +24.02%  (p=0.000 n=8+10)
puffs_zlib_decode_10k/gcc         112MB/s ± 0%    120MB/s ± 0%   +6.96%  (p=0.000 n=10+9)
puffs_zlib_decode_100k/gcc        123MB/s ± 0%    134MB/s ± 0%   +8.93%  (p=0.000 n=9+8)
2017-11-05 15:59:02 +11:00
Nigel Tao f6e072fe77 Add some more "inconsistent n_bits" checks.
This uncovered a bug in the decode_huffman_fast function. A follow up commit
will actually fix the bug.

For what it's worth, some benchmark numbers are below, but they're
possibly bogus, as we might be decoding incorrect (and truncated) output
for some inputs. Everything since "f968950 Read bits up front in
decode_huffman_fast" landed possibly has bogus numbers too.

name                           old speed     new speed     delta
puffs_flate_decode_100k/clang  194MB/s ± 0%  204MB/s ± 1%   +5.02%  (p=0.008 n=5+5)
puffs_flate_decode_100k/gcc    180MB/s ± 3%  202MB/s ± 1%  +12.09%  (p=0.008 n=5+5)
2017-11-05 09:23:49 +11:00
Nigel Tao cf61ca11c3 Run the adler benchmarks for longer.
A future commit could set each benchmark's iteration count (call it N)
dynamically, but for now, the iteration counts are hard-coded. The rough
guiding principle is those N iterations should take more or less one
second, on my modern desktop CPU.

Prior to this commit, the adler benchmarks ran for the same N as the
zlib benchmarks. Each zlib decode involves exactly one adler checksum
computation, so both having the same N makes it very easy to calculate a
rough estimate of what fraction of zlib decoding is spent in adler code.
But in having the same N, the adler benchmarks run for a tiny fraction
of a second (and would run for an even tinier fraction if we further
optimize the adler code, e.g. with SIMD).

This commit raises that N for the adler benchmarks (but not for the zlib
benchmarks), which should hopefully make the adler numbers a little more
reliable. It will make that very easy calculation slightly less easy,
but it'd still be trivial.

The benchmark numbers do change. I'm not entirely sure why, but keep in
mind that this commit only changes the benchmark harness code, not the
actual std/flate code running in that harness.

name                           old speed      new speed      delta

puffs_adler32_10k/clang        2.45GB/s ± 0%  2.40GB/s ± 1%  -2.00%  (p=0.008 n=5+5)
puffs_adler32_100k/clang       2.44GB/s ± 0%  2.40GB/s ± 1%  -1.67%  (p=0.008 n=5+5)
puffs_flate_decode_1k/clang     133MB/s ± 0%   131MB/s ± 1%  -1.37%  (p=0.008 n=5+5)
puffs_flate_decode_10k/clang    174MB/s ± 0%   171MB/s ± 1%  -1.66%  (p=0.008 n=5+5)
puffs_flate_decode_100k/clang   205MB/s ± 0%   202MB/s ± 0%  -1.28%  (p=0.016 n=5+4)
puffs_zlib_decode_10k/clang     162MB/s ± 0%   159MB/s ± 1%  -1.94%  (p=0.008 n=5+5)
puffs_zlib_decode_100k/clang    188MB/s ± 0%   185MB/s ± 1%  -1.60%  (p=0.008 n=5+5)

puffs_adler32_10k/gcc          3.25GB/s ± 0%  3.26GB/s ± 0%  +0.25%  (p=0.016 n=4+5)
puffs_adler32_100k/gcc         3.25GB/s ± 0%  3.27GB/s ± 0%  +0.39%  (p=0.008 n=5+5)
puffs_flate_decode_1k/gcc       132MB/s ± 0%   132MB/s ± 0%    ~     (p=0.151 n=5+5)
puffs_flate_decode_10k/gcc      170MB/s ± 0%   170MB/s ± 0%    ~     (p=0.738 n=5+5)
puffs_flate_decode_100k/gcc     207MB/s ± 0%   207MB/s ± 0%    ~     (p=0.841 n=5+5)
puffs_zlib_decode_10k/gcc       161MB/s ± 1%   162MB/s ± 0%    ~     (p=0.841 n=5+5)
puffs_zlib_decode_100k/gcc      194MB/s ± 0%   194MB/s ± 0%    ~     (p=0.841 n=5+5)
2017-11-05 07:16:04 +11:00
Nigel Tao 66047db6d8 Be more paranoid about calling strncmp. 2017-11-04 10:49:23 +11:00
Nigel Tao 6602dea7be Make focus's "/gcc" suffix optional. 2017-11-04 10:40:43 +11:00
Nigel Tao 4729170678 Make focus's "Benchmark" prefix optional. 2017-11-04 10:25:24 +11:00
Nigel Tao 0230a65c7b Let focus have a trailing comma. 2017-11-04 10:21:32 +11:00
Nigel Tao c62aa518a5 Make focus's "test_" or "bench_" prefix optional. 2017-11-04 10:05:37 +11:00
Nigel Tao 1487da7af8 Add a -focus flag. 2017-11-03 17:54:29 +11:00
Nigel Tao aec5715f12 Declare proc_filename exactly once. 2017-11-03 15:09:22 +11:00
Nigel Tao d7c910fd1b Avoid "array decl needs an explicit size". 2017-11-03 12:11:21 +11:00
Nigel Tao 94eba81892 Have mimiclib accept both giflib v4 and v5. 2017-11-03 11:35:16 +11:00
Nigel Tao 0e136f59af Use an explicitly typed tc_neither. 2017-11-03 11:18:38 +11:00
Nigel Tao b7f347d406 Fix a "return false as char*" typo. 2017-11-03 11:15:38 +11:00
Nigel Tao e3822f9951 Re-introduce puffs_base__limit1.
It's not immediately obvious why this data structure performs differently, but
on net, the benchmark numbers seem better. It also won't require any
PUFFS_USE_NO_OP_PERFORMANCE_HACKS or "redundant but mysteriously performant"
use_limit fields.

name                             old speed      new speed      delta

puffs_adler32_10k/clang          2.46GB/s ± 0%  2.43GB/s ± 3%     ~     (p=0.513 n=5+10)
puffs_adler32_100k/clang         2.46GB/s ± 0%  2.44GB/s ± 2%     ~     (p=0.241 n=5+10)
puffs_flate_decode_1k/clang       122MB/s ± 1%   119MB/s ± 2%   -1.86%  (p=0.013 n=5+10)
puffs_flate_decode_10k/clang      147MB/s ± 0%   142MB/s ± 2%   -3.47%  (p=0.001 n=5+10)
puffs_flate_decode_100k/clang     161MB/s ± 0%   161MB/s ± 4%     ~     (p=0.635 n=4+10)
puffs_zlib_decode_10k/clang       139MB/s ± 0%   135MB/s ± 1%   -2.69%  (p=0.001 n=5+10)
puffs_zlib_decode_100k/clang      151MB/s ± 0%   152MB/s ± 3%     ~     (p=1.000 n=5+10)

puffs_adler32_10k/gcc            3.21GB/s ± 1%  3.18GB/s ± 2%     ~     (p=0.310 n=5+10)
puffs_adler32_100k/gcc           3.22GB/s ± 0%  3.19GB/s ± 2%     ~     (p=0.075 n=5+10)
puffs_flate_decode_1k/gcc         121MB/s ± 4%   126MB/s ± 1%   +4.54%  (p=0.002 n=5+8)
puffs_flate_decode_10k/gcc        144MB/s ± 1%   141MB/s ± 1%   -2.52%  (p=0.001 n=5+9)
puffs_flate_decode_100k/gcc       154MB/s ± 1%   158MB/s ± 0%   +2.39%  (p=0.001 n=5+9)
puffs_zlib_decode_10k/gcc         137MB/s ± 2%   135MB/s ± 1%     ~     (p=0.055 n=5+10)
puffs_zlib_decode_100k/gcc        146MB/s ± 2%   150MB/s ± 0%   +2.87%  (p=0.001 n=5+10)

puffs_gif_lzw_decode_20k/clang    132MB/s ± 0%   125MB/s ± 0%   -5.24%  (p=0.001 n=5+10)
puffs_gif_lzw_decode_100k/clang   176MB/s ± 0%   164MB/s ± 0%   -6.82%  (p=0.001 n=5+9)
puffs_gif_decode_1k/clang         363MB/s ± 0%   339MB/s ± 1%   -6.58%  (p=0.002 n=4+10)
puffs_gif_decode_10k/clang        138MB/s ± 0%   133MB/s ± 1%   -3.77%  (p=0.001 n=5+10)
puffs_gif_decode_100k/clang       125MB/s ± 0%   119MB/s ± 0%   -4.79%  (p=0.001 n=5+10)
puffs_gif_decode_1000k/clang      127MB/s ± 0%   121MB/s ± 0%   -5.04%  (p=0.001 n=5+10)

puffs_gif_lzw_decode_20k/gcc      141MB/s ± 0%   140MB/s ± 2%     ~     (p=1.000 n=5+10)
puffs_gif_lzw_decode_100k/gcc     182MB/s ± 0%   180MB/s ± 2%   -1.56%  (p=0.001 n=5+10)
puffs_gif_decode_1k/gcc           363MB/s ± 0%   409MB/s ± 3%  +12.71%  (p=0.001 n=5+10)
puffs_gif_decode_10k/gcc          127MB/s ± 0%   161MB/s ± 3%  +26.15%  (p=0.001 n=5+10)
puffs_gif_decode_100k/gcc         112MB/s ± 0%   136MB/s ± 2%  +21.95%  (p=0.001 n=5+10)
puffs_gif_decode_1000k/gcc        114MB/s ± 0%   140MB/s ± 2%  +22.78%  (p=0.001 n=5+10)
2017-11-03 10:09:57 +11:00
Nigel Tao aa396e7992 Change cgen's limit from a count to a pointer. 2017-10-27 10:28:35 +11:00
Nigel Tao e0836d73a8 Migrate tests to use new limit mechanism. 2017-10-27 07:49:08 +11:00
Nigel Tao d61594b03f Add citation to RFC 1951 (flate). 2017-10-22 15:27:25 +11:00
Nigel Tao 21bbbd422f Generate code for "mark in.dst".
The generated code is ugly and the language design is not finalized, but
the flate_backref_crosses_blocks test (testing a correctness bug) now
passes. We can fix the ugliness in subsequent commits.
2017-10-22 14:44:53 +11:00
Nigel Tao bcc7171b5a Add a flate_backref_crosses_blocks test. 2017-10-22 12:54:57 +11:00
Nigel Tao 27a33ff27c Add a test/testdata/artificial directory. 2017-10-22 11:41:06 +11:00
Nigel Tao f29c4e278f Follow the pkg__type__method convention for base. 2017-10-21 15:59:08 +11:00
Nigel Tao 6815375de5 Generate double '_'s for pkg__type__method names. 2017-10-21 15:10:25 +11:00
Nigel Tao 2639f8f46a Rename std/flate's decoder to flate_decoder. 2017-10-21 13:05:19 +11:00
Nigel Tao 1c75edb32e Calculate the zlib checksum. 2017-10-21 12:38:23 +11:00