ddidderr/zstd-rs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
5,586 Commits 17 Branches 77 Tags
9e26893e0755650a92a899b2daf3886b0ea79055
Commit Graph
5586 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Yann Collet 9e26893e07 paramgrill: fixed a bunch of div-by-zero 
they were pretty easy to trigger by the way,
just start an extended paramgrill session
to find a compression table based on any sample,
it would necessarily happen at some point.
 2018-08-27 18:47:09 -07:00
Yann Collet 0071e8348f restored assert() in paramgrill 
assert() in paramgrill are not in the benchmark path.
They should remain active, as they don't impact measurements, and their runtime is insignificant.
 2018-08-27 17:52:04 -07:00
Yann Collet 01dcd0fd17 bench: minor api update, for consistency 
BMK_benchTimedFn()
BMK_isCompleted_TimedFn() uses TimedFnState
 2018-08-26 21:30:18 -07:00
Yann Collet c3a4baaf6e fixed minor warnings 
valgrind: memory leak of a few bytes in fullbench
static analyzer: uninitialized data passed as result
 2018-08-24 23:25:35 -07:00
Yann Collet 2279f3d127 bench: reduce nb of return type 
runOutcome is enough
removed timedFnOutcome
 2018-08-24 17:28:38 -07:00
Yann Collet 6ce7b08f17 fix minor warnings 
gcc : prototype with 0 parameter must be labelled (void)
visual : const property must be identical in both declaration and implementation
 2018-08-24 15:59:57 -07:00
Yann Collet 7b23cc4d1e fixed fullbench behavior 
now same as v1.3.5
 2018-08-24 12:40:10 -07:00
Yann Collet 4da5bdf482 fixed zstd -b speed result 
the benchmark was displaying the speed of last run
instead of the best of all previous runs.
 2018-08-23 18:13:49 -07:00
Yann Collet b0e1f3982d fixed paramgrill 
to work with new bench.c
 2018-08-23 17:21:38 -07:00
Yann Collet 1f9ec13621 introduced MB_UNIT 
so that all benchmarking programs use the same speed scale
 2018-08-23 16:03:30 -07:00
Yann Collet d39a25c5ed update fullbench.c to work with new bench.h 2018-08-23 15:00:09 -07:00
Yann Collet 2e45badff4 refactored bench.c 
for clarity and safety, especially at interface level
 2018-08-23 14:21:18 -07:00
Yann Collet 77e805e3db bench: changed creation/reset function to timedFnState 
for consistency
 2018-08-21 18:19:27 -07:00
Yann ColletandGitHub 1af27a7ed7 Merge pull request #1287 from tgurr/cmake-docdir 
Use GNUInstallDirs DOCDIR for installing the manual
 2018-08-21 14:48:50 -07:00
Yann ColletandGitHub 801e3bcd97 Merge pull request #1290 from edenzik/ezik/1119-safe-strcpy-in-fileio 
Fixed unsafe string copy and concat in `fileio.c`.
 2018-08-21 13:18:44 -07:00
Eden Zik 78af534f82 Fixed unsafe string copy and concat in fileio.c. 
Per warnings from flawfinder: "Does not check for buffer overflows when
copying to destination [MS-banned] (CWE-120). Consider using snprintf,
strcpy_s, or strlcpy (warning: strncpy easily misused).".

Replaced called to strcpy and strcat in `fileio.c` to calls with a
specified size (`strncpy` and `strncat`).

Tested the changes on OSX, Linux, Windows.
On OSX + Linux, changes were tested with ASAN. The following flags were
used: 'check_initialization_order=1:strict_init_order=1:detect_odr_violation=1:detect_stack_use_after_return=1'

To reproduce warning:
./flawfinder.py ./programs/fileio.c
 2018-08-20 22:15:24 -04:00
Yann ColletandGitHub ea0b5fc193 Merge pull request #1285 from facebook/scanbuild 
static analyzer tests
 2018-08-17 16:38:41 -07:00
Timo Gurr e400a86f17 Use GNUInstallDirs DOCDIR for installing the manual 2018-08-17 13:50:00 +02:00
Yann ColletandGitHub 77fa1d6e42 Merge pull request #1284 from GeorgeLu97/negativeLvlDisplay 
Fix negative lvl display value
 2018-08-16 18:20:37 -07:00
George Lu 3959ba15e6 Clarify README 2018-08-16 17:22:29 -07:00
George Lu 8175b28f03 Fix negative lvl display value 
Also fix synthetic benchmark parameter setting
 2018-08-16 16:46:37 -07:00
Yann Collet 36d6165a2d Makefile: added variable SCANBUILD 
so that a different version of scan-build can be selected
 2018-08-16 16:44:13 -07:00
Yann Collet 1515f0bb0d fixed more issues detected by recent version of scan-build 
test run on Linux
 2018-08-16 15:20:25 -07:00
Yann ColletandGitHub 1dd3156f2b Merge pull request #1281 from GeorgeLu97/cleanUp 
Clean up paramgrill code
 2018-08-15 17:56:45 -07:00
Yann Collet 31224cc126 added static analyzer tests to travis CI 2018-08-15 17:44:27 -07:00
Yann Collet 5291d9ac31 fix scope of scan-build tests 
exclude zlib code
 2018-08-15 17:41:44 -07:00
Yann Collet da55865e47 ensure dependency for zlib wrapper 2018-08-15 16:43:13 -07:00
George Lu 239e114d62 prune comments 2018-08-15 16:04:34 -07:00
George Lu 8a296d3e1f Move Stuff around 
Group similar functions together, remove outdated comments
 2018-08-15 16:04:34 -07:00
George Lu 3f8b10baa1 consts 2018-08-15 16:04:34 -07:00
George Lu 46be2ef5d8 Remove unused stuff 2018-08-15 16:04:34 -07:00
Yann ColletandGitHub 512919415c Merge pull request #1280 from GeorgeLu97/betterDisplay 
Better Paramgrill Display
 2018-08-15 15:20:56 -07:00
Yann Collet 42a02ab745 fixed minor warnings issued by scan-build 2018-08-15 14:36:02 -07:00
George Lu b234870c33 clarify display README 2018-08-15 14:29:49 -07:00
George Lu ee77ddc28d Fix wraparound 2018-08-15 14:01:32 -07:00
George Lu 1e8d352930 silencing params 2018-08-15 14:01:32 -07:00
George Lu 2c5fdae0ae Clean up repetitive display 
Add documentation
 2018-08-15 14:01:32 -07:00
George Lu 4d9c6f51b8 -q -v options 2018-08-15 14:01:32 -07:00
George Lu 3dcfe5cc2c begin display changes 2018-08-15 14:01:32 -07:00
Yann Collet 3692c31598 Merge branch 'dev' into scanbuild 2018-08-15 13:50:49 -07:00
Yann ColletandGitHub a01b964207 Merge pull request #1277 from GeorgeLu97/mtoptions 
memoTableOptions
 2018-08-15 13:45:17 -07:00
George Lu b1d9ca737a Add memoTable options 
-hashing memotable
-no memotable
 2018-08-15 10:19:38 -07:00
Yann Collet 6e66bbf5dd fixed several minor issues detected by scan-build 
only notable one :
writeNCount() resists better vs invalid distributions
(though it should never happen within zstd anyway)
 2018-08-14 16:55:35 -07:00
Yann ColletandGitHub 90a3901d1e Merge pull request #1279 from GeorgeLu97/benchSA 
Fix scan-build warnings in bench.c
 2018-08-14 16:44:28 -07:00
George Lu 8c918edd3a MAke it easier to add params 
Make memoTable size limited
 2018-08-14 16:15:46 -07:00
George Lu 96725989ef Temp fix perf regression 2018-08-14 16:14:37 -07:00
Yann ColletandGitHub 0c9772b084 Merge pull request #1276 from GeorgeLu97/fadt 
forceAttachDict
 2018-08-14 16:06:18 -07:00
George Lu e89f1fb45c Fix scan-build warnings in bench.c 2018-08-14 14:44:47 -07:00
George Lu 3f2d024dca forceAttachDict 2018-08-14 14:24:41 -07:00
George Lu e3c679484a Add Time Checks 
Fix double -> U64 display
 2018-08-14 14:24:41 -07:00