rustics/dns
2
0
Fork 0
Code Issues 8 Pull Requests Projects 1 Releases Wiki Activity

Move parsing of udp datagram for dns header into model #1

Merged
ddidderr merged 1 commits from partial-error-handling into master 2022-04-03 16:10:36 +02:00
Conversation 5 Commits 1 Files Changed 2
+97 -64
ddidderr commented 2022-03-15 22:12:37 +01:00
Owner
Copy Link
Copy Source
No description provided.
ddidderr added 1 commit 2022-03-15 22:12:37 +01:00
Move parsing of udp datagram for dns header into model b9ff4c9a51
ddidderr commented 2022-03-15 22:13:33 +01:00
Author
Owner
Copy Link
Copy Source

Pull Request kam eigentlich von @mice_on_drugs aus Gogs.

Pull Request kam eigentlich von @mice_on_drugs aus Gogs.
ddidderr marked the pull request as work in progress 2022-03-15 22:13:47 +01:00
ddidderr marked the pull request as ready for review 2022-03-15 22:14:16 +01:00
ddidderr commented 2022-03-15 22:17:07 +01:00
Author
Owner
Copy Link
Copy Source

Meine Anmerkung war die Member in den Structs erstmal private zu machen, also das pub wegzulassen.

Weil die Implementierung das kapseln sollte und nicht andere von außen auf die Member zugreifen sollten.

Meine Anmerkung war die Member in den Structs erstmal private zu machen, also das `pub` wegzulassen. Weil die Implementierung das kapseln sollte und nicht andere von außen auf die Member zugreifen sollten.
ddidderr added the due date 2022-03-18 2022-03-16 10:20:44 +01:00
ddidderr reviewed 2022-03-16 11:03:07 +01:00
src/proto.rs
@@ -85,0 +109,4 @@
const OPCODE_OFFSET: u16 = 1;
const RCODE_OFFSET: u16 = 11;
pub fn from_udp_datagram(datagram: &[u8]) -> Result<Self, &'static str> {
ddidderr commented 2022-03-16 11:03:07 +01:00
Author
Owner
Copy Link
Copy Source

Error Handling mit nem &'static str als Error ist auch erstmal temporär, das müssen wir später noch schöner ausgestalten.

Error Handling mit nem `&'static str` als Error ist auch erstmal temporär, das müssen wir später noch schöner ausgestalten.
mice_on_drugs was assigned by ddidderr 2022-03-16 15:22:02 +01:00
ddidderr commented 2022-03-16 15:23:16 +01:00
Author
Owner
Copy Link
Copy Source

by the way, ich würd gern erstmal Merge commits vermeiden, deshalb gerne Rebase and Merge auswählen, beim mergen von PRs.

by the way, ich würd gern erstmal Merge commits vermeiden, deshalb gerne `Rebase and Merge` auswählen, beim mergen von PRs.
Maashkinoozhe was assigned by ddidderr 2022-03-17 18:49:52 +01:00
Maashkinoozhe was unassigned by ddidderr 2022-03-17 18:49:55 +01:00
ddidderr requested review from Maashkinoozhe 2022-03-17 18:49:57 +01:00
ddidderr added this to the 0.1 sprint project 2022-03-17 20:51:18 +01:00
mice_on_drugs approved these changes 2022-04-03 16:08:46 +02:00
ddidderr merged commit b9ff4c9a51 into master 2022-04-03 16:10:36 +02:00
ddidderr deleted branch partial-error-handling 2022-04-03 16:10:36 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
ddidderr
Maashkinoozhe
mice_on_drugs
Labels
Clear labels
architecture
Discussions about how to solve a problem in code.
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 refactor
Refactor code
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
0.1 sprint
Done
Assignees
Clear assignees
Maashkinoozhe ddidderr mice_on_drugs
No Assignees mice_on_drugs
2 Participants
Notifications
Due Date
2022-03-18
Dependencies

No dependencies set.

Reference: rustics/dns#1