Files

T

Update FOLLOW_UP_2.md after the follow-up stack landed. The document now marks
the active-operation reconciliation, recovery matrix, rollback tests,
installed-only rescan, scanner gating, serve gating, and TempDir consolidation
as completed.

The remaining open items are intentionally limited to the deferred hygiene
called out by the plan: typed availability, atomic library-index writes, and a
future download.rs split.

Test Plan:
- git diff --check

Follow-up-Plan: FOLLOW_UP_2.md

2026-05-16 09:23:02 +02:00

3.4 KiB

Raw Blame History

Follow-up Plan #2

State of FOLLOW_UP_PLAN.md after two implementation rounds. Items here are what's still open, plus notes for follow-up items completed after this file was created.

Context for next time

Branch p2p-codex-muenchhausen has uncommitted work that completes the bulk of FOLLOW_UP_PLAN.md (52 tests pass via just test). Specifically these items in the original plan are done and shouldn't be re-opened: #1, #2, #3, #4, #5, #6, #7, #8, #9, #15, #17, #20, plus parts of #12 (update success, version-ini begin/rollback, multi-eti sorted order, corrupt + mismatched-id intent JSON).

The OperationGuard ordering fix in handlers.rs is the structurally most important change: install/update/uninstall now drop the guard before the finish event and refresh_local_game, so peers see settled state in the next announcement instead of waiting for a scan tick. Tests *_refreshes_settled_state_after_guard_release pin this.

Completed after this file was created

Tauri-side active_operations reconciliation: PeerEvent::LocalGamesUpdated now carries an authoritative active-operation snapshot, the Tauri bridge replaces its UI operation map from that snapshot, and the React game-list merge uses the snapshot to clear stale download/install/update/uninstall spinners even when a begin/finish/fail event was missed.
Install-recovery matrix: recovery_covers_install_matrix_rows now covers the ten named Installing / Updating / Uninstalling rows from PLAN.md, including markerless reserved directories while an intent proves ownership.
Update rollback on commit-rename failure: update_commit_rename_failure_restores_previous_local forces a post-extract commit conflict without production hooks and verifies backup restore.
Uninstall delete-failure restore: uninstall_delete_failure_restores_backup covers the rollback path on Unix, where directory permissions can force recursive delete failure without hooks.
Installed-only → Ready rescan: rescan_promotes_installed_only_game_to_ready_when_sentinel_appears pins the cached-index transition after a user adds version.ini to a local-only root.
Scanner gating dispatch: local monitor tests now cover active-operation event drops, burst collapse, fallback sideload pickup, and non-catalog roots leaving no library entry or delta.
Serve gating dispatch: stream tests now cover GetGame response gates and the shared full-file/chunk transfer gate for non-catalog, active-operation, missing-sentinel, and local-path cases.
TempDir test helper: peer tests now share test_support::TempDir instead of carrying per-module copies.

Still open

Code hygiene

9. `availability` field is `String`, not a typed enum

lanspread-db::Game::availability: String with AVAILABILITY_* consts works but allows invalid values. remote_peer::summary_from_game already has a defensive fallback for unknown strings. A typed enum + serde would be tighter, but is a wire-format change — coordinate if/when other peers are upgraded.

10. `save_library_index` non-atomic

local_games.rs:141-148 writes without temp+rename. Corrupt index → next scan rebuilds, so blast radius is small. Match the intent-log atomic pattern if touching that module.

11. Split `download.rs` (1162 lines, growing)

Mixes chunk planning, retry orchestration, version-sentinel transaction, in-memory buffer, and the main loop. Future split into download/{transaction,chunks,orchestrator}.rs. Pure cosmetic.

3.4 KiB Raw Blame History