test: fix gcc -Wmaybe-uninitialized false positive

When running "gcc -O3 -Wall test/c/std/adler32.c", gcc 12.2.0 (but not
gcc 10.2.1) would warn that adler32's "checksum.private_impl.f_started"
may be used uninitialized. There is no warning without the "-O3".

That warning is a false positive. f_started is always zero-initialized
by wuffs_adler32__hasher__initialize (unless opted in to
WUFFS_INITIALIZE__ALREADY_ZEROED, which the benchmarks do not).

Also update test/c/std/crc32.c so that all of the base.hasher_u32
wuffs_bench_etc functions are consistent, even though gcc on crc32.c
does not produce that same false positive warning.
This commit is contained in:
Nigel Tao committed 2023-04-12 13:31:01 +10:00
1 parent 35fd84bea0
commit 176cdf7527
2 files changed
+2 -2

No files matched your search

+1 -1
View File
@@ -239,7 +239,7 @@ wuffs_bench_adler32(wuffs_base__io_buffer* dst,
if (rlimit) {
len = wuffs_base__u64__min(len, rlimit);
}
wuffs_adler32__hasher checksum;
wuffs_adler32__hasher checksum = {0};
CHECK_STATUS("initialize", wuffs_adler32__hasher__initialize(
&checksum, sizeof checksum, WUFFS_VERSION,
wuffs_initialize_flags));
+1 -1
View File
@@ -276,7 +276,7 @@ wuffs_bench_crc32_ieee(wuffs_base__io_buffer* dst,
if (rlimit) {
len = wuffs_base__u64__min(len, rlimit);
}
wuffs_crc32__ieee_hasher checksum;
wuffs_crc32__ieee_hasher checksum = {0};
CHECK_STATUS("initialize", wuffs_crc32__ieee_hasher__initialize(
&checksum, sizeof checksum, WUFFS_VERSION,
wuffs_initialize_flags));