Commit Graph
622 Commits
Author SHA1 Message Date
Nigel Tao 13731f989f Add a reader1.unread_u8 method.
Also re-enable a number of std/flate tests and benchmarks.

It's not an optimization per se, but as a data point, here are some
benchmark numbers between 36a93fa and this commit. 36a93fa is "36a93fa
Add a TODO about impure functions", which is one commit before "f968950
Read bits up front in decode_huffman_fast", and f968950 was the commit
that made decode_huffman_fast read more than one byte at a time.

name                             old speed      new speed       delta

puffs_adler32_10k/clang          2.45GB/s ± 0%   2.45GB/s ± 0%     ~     (p=0.684 n=10+10)
puffs_adler32_100k/clang         2.45GB/s ± 0%   2.46GB/s ± 0%   +0.07%  (p=0.019 n=10+10)
puffs_flate_decode_1k/clang       124MB/s ± 0%    132MB/s ± 0%   +6.06%  (p=0.000 n=10+10)
puffs_flate_decode_10k/clang      145MB/s ± 0%    174MB/s ± 0%  +20.19%  (p=0.000 n=9+10)
puffs_flate_decode_100k/clang     168MB/s ± 0%    208MB/s ± 0%  +23.31%  (p=0.000 n=10+10)
puffs_zlib_decode_10k/clang       136MB/s ± 0%    162MB/s ± 0%  +18.94%  (p=0.000 n=10+9)
puffs_zlib_decode_100k/clang      158MB/s ± 0%    192MB/s ± 0%  +21.58%  (p=0.000 n=10+9)

puffs_adler32_10k/gcc            3.26GB/s ± 0%   3.26GB/s ± 0%     ~     (p=0.631 n=10+10)
puffs_adler32_100k/gcc           3.27GB/s ± 0%   3.27GB/s ± 0%     ~     (p=0.237 n=10+8)
puffs_flate_decode_1k/gcc        95.3MB/s ± 0%  105.5MB/s ± 0%  +10.67%  (p=0.000 n=10+10)
puffs_flate_decode_10k/gcc        110MB/s ± 0%    140MB/s ± 0%  +27.32%  (p=0.000 n=9+9)
puffs_flate_decode_100k/gcc       121MB/s ± 0%    150MB/s ± 0%  +24.02%  (p=0.000 n=8+10)
puffs_zlib_decode_10k/gcc         112MB/s ± 0%    120MB/s ± 0%   +6.96%  (p=0.000 n=10+9)
puffs_zlib_decode_100k/gcc        123MB/s ± 0%    134MB/s ± 0%   +8.93%  (p=0.000 n=9+8)
2017-11-05 15:59:02 +11:00
Nigel Tao 6621526a2c Re-introduce codegen for b_wstart_dst. 2017-11-05 14:24:33 +11:00
Nigel Tao 586413dbd3 Run "go generate".
I previously forgot to do this after a trivial edit to the cgen package.
2017-11-05 14:21:02 +11:00
Nigel Tao 325c36314a Prepare decode_huffman_fast to rewind in.src. 2017-11-05 14:13:27 +11:00
Nigel Tao 3099991d7f Add an "invalid I/O operation" error code. 2017-11-05 13:53:35 +11:00
Nigel Tao b6a079fd3e Tweak the decode_huffman_fast loop condition more. 2017-11-05 13:47:28 +11:00
Nigel Tao f6e072fe77 Add some more "inconsistent n_bits" checks.
This uncovered a bug in the decode_huffman_fast function. A follow up commit
will actually fix the bug.

For what it's worth, some benchmark numbers are below, but they're
possibly bogus, as we might be decoding incorrect (and truncated) output
for some inputs. Everything since "f968950 Read bits up front in
decode_huffman_fast" landed possibly has bogus numbers too.

name                           old speed     new speed     delta
puffs_flate_decode_100k/clang  194MB/s ± 0%  204MB/s ± 1%   +5.02%  (p=0.008 n=5+5)
puffs_flate_decode_100k/gcc    180MB/s ± 3%  202MB/s ± 1%  +12.09%  (p=0.008 n=5+5)
2017-11-05 09:23:49 +11:00
Nigel Tao db57d8b707 Bump decode_huffman_fast's src available hurdle.
We will need this later, to prove that the other read_u8 calls in
decode_huffman_fast will not suspend.

It's not obvious why the clang benchmarks don't change but the gcc ones
(including the adler numbers, which are superficially unrelated) look
worse. If the change from 6 to 12 bytes is a genuine performance
regression, then a future commit can tighten the bound back to 6,
although it would probably make the decode_huffman_fast assertions and
proof requirements considerably more complicated.

name                           old speed      new speed      delta

puffs_adler32_10k/clang        2.40GB/s ± 1%  2.41GB/s ± 0%    ~     (p=0.690 n=5+5)
puffs_adler32_100k/clang       2.39GB/s ± 2%  2.40GB/s ± 1%    ~     (p=1.000 n=5+5)
puffs_flate_decode_1k/clang     128MB/s ± 0%   128MB/s ± 0%    ~     (p=1.000 n=5+5)
puffs_flate_decode_10k/clang    167MB/s ± 2%   168MB/s ± 0%    ~     (p=0.548 n=5+5)
puffs_flate_decode_100k/clang   193MB/s ± 2%   194MB/s ± 0%    ~     (p=0.310 n=5+5)
puffs_zlib_decode_10k/clang     157MB/s ± 0%   155MB/s ± 4%    ~     (p=0.421 n=5+5)
puffs_zlib_decode_100k/clang    180MB/s ± 1%   177MB/s ± 3%    ~     (p=0.222 n=5+5)

puffs_adler32_10k/gcc          3.26GB/s ± 0%  3.20GB/s ± 1%  -1.81%  (p=0.008 n=5+5)
puffs_adler32_100k/gcc         3.26GB/s ± 0%  3.21GB/s ± 0%  -1.63%  (p=0.008 n=5+5)
puffs_flate_decode_1k/gcc       129MB/s ± 0%   126MB/s ± 1%  -2.30%  (p=0.008 n=5+5)
puffs_flate_decode_10k/gcc      164MB/s ± 0%   161MB/s ± 0%  -1.86%  (p=0.008 n=5+5)
puffs_flate_decode_100k/gcc     185MB/s ± 0%   180MB/s ± 3%  -2.81%  (p=0.016 n=4+5)
puffs_zlib_decode_10k/gcc       157MB/s ± 0%   151MB/s ± 2%  -3.49%  (p=0.008 n=5+5)
puffs_zlib_decode_100k/gcc      175MB/s ± 0%   170MB/s ± 2%  -2.97%  (p=0.016 n=4+5)
2017-11-05 08:56:55 +11:00
Nigel Tao 55e0bc513b Don't suspend for read_u8 if data is available.
It's not obvious why the benchmarks get worse when the code looks
better, but the long term goal is for all of decode_huffman_fast to not
suspend, and this is one step along that path.

name                           old speed      new speed      delta

puffs_adler32_10k/clang        2.40GB/s ± 1%  2.40GB/s ± 1%     ~     (p=0.841 n=5+5)
puffs_adler32_100k/clang       2.40GB/s ± 1%  2.39GB/s ± 2%     ~     (p=0.421 n=5+5)
puffs_flate_decode_1k/clang     131MB/s ± 1%   128MB/s ± 0%   -2.51%  (p=0.008 n=5+5)
puffs_flate_decode_10k/clang    171MB/s ± 1%   167MB/s ± 2%   -2.86%  (p=0.008 n=5+5)
puffs_flate_decode_100k/clang   202MB/s ± 0%   193MB/s ± 2%   -4.64%  (p=0.016 n=4+5)
puffs_zlib_decode_10k/clang     159MB/s ± 1%   157MB/s ± 0%   -1.65%  (p=0.008 n=5+5)
puffs_zlib_decode_100k/clang    185MB/s ± 1%   180MB/s ± 1%   -3.11%  (p=0.008 n=5+5)

puffs_adler32_10k/gcc          3.26GB/s ± 0%  3.26GB/s ± 0%     ~     (p=0.421 n=5+5)
puffs_adler32_100k/gcc         3.27GB/s ± 0%  3.26GB/s ± 0%     ~     (p=0.151 n=5+5)
puffs_flate_decode_1k/gcc       132MB/s ± 0%   129MB/s ± 0%   -2.29%  (p=0.008 n=5+5)
puffs_flate_decode_10k/gcc      170MB/s ± 0%   164MB/s ± 0%   -3.13%  (p=0.008 n=5+5)
puffs_flate_decode_100k/gcc     207MB/s ± 0%   185MB/s ± 0%  -10.45%  (p=0.016 n=5+4)
puffs_zlib_decode_10k/gcc       162MB/s ± 0%   157MB/s ± 0%   -2.95%  (p=0.008 n=5+5)
puffs_zlib_decode_100k/gcc      194MB/s ± 0%   175MB/s ± 0%   -9.78%  (p=0.016 n=5+4)
2017-11-05 08:03:21 +11:00
Nigel Tao cf61ca11c3 Run the adler benchmarks for longer.
A future commit could set each benchmark's iteration count (call it N)
dynamically, but for now, the iteration counts are hard-coded. The rough
guiding principle is those N iterations should take more or less one
second, on my modern desktop CPU.

Prior to this commit, the adler benchmarks ran for the same N as the
zlib benchmarks. Each zlib decode involves exactly one adler checksum
computation, so both having the same N makes it very easy to calculate a
rough estimate of what fraction of zlib decoding is spent in adler code.
But in having the same N, the adler benchmarks run for a tiny fraction
of a second (and would run for an even tinier fraction if we further
optimize the adler code, e.g. with SIMD).

This commit raises that N for the adler benchmarks (but not for the zlib
benchmarks), which should hopefully make the adler numbers a little more
reliable. It will make that very easy calculation slightly less easy,
but it'd still be trivial.

The benchmark numbers do change. I'm not entirely sure why, but keep in
mind that this commit only changes the benchmark harness code, not the
actual std/flate code running in that harness.

name                           old speed      new speed      delta

puffs_adler32_10k/clang        2.45GB/s ± 0%  2.40GB/s ± 1%  -2.00%  (p=0.008 n=5+5)
puffs_adler32_100k/clang       2.44GB/s ± 0%  2.40GB/s ± 1%  -1.67%  (p=0.008 n=5+5)
puffs_flate_decode_1k/clang     133MB/s ± 0%   131MB/s ± 1%  -1.37%  (p=0.008 n=5+5)
puffs_flate_decode_10k/clang    174MB/s ± 0%   171MB/s ± 1%  -1.66%  (p=0.008 n=5+5)
puffs_flate_decode_100k/clang   205MB/s ± 0%   202MB/s ± 0%  -1.28%  (p=0.016 n=5+4)
puffs_zlib_decode_10k/clang     162MB/s ± 0%   159MB/s ± 1%  -1.94%  (p=0.008 n=5+5)
puffs_zlib_decode_100k/clang    188MB/s ± 0%   185MB/s ± 1%  -1.60%  (p=0.008 n=5+5)

puffs_adler32_10k/gcc          3.25GB/s ± 0%  3.26GB/s ± 0%  +0.25%  (p=0.016 n=4+5)
puffs_adler32_100k/gcc         3.25GB/s ± 0%  3.27GB/s ± 0%  +0.39%  (p=0.008 n=5+5)
puffs_flate_decode_1k/gcc       132MB/s ± 0%   132MB/s ± 0%    ~     (p=0.151 n=5+5)
puffs_flate_decode_10k/gcc      170MB/s ± 0%   170MB/s ± 0%    ~     (p=0.738 n=5+5)
puffs_flate_decode_100k/gcc     207MB/s ± 0%   207MB/s ± 0%    ~     (p=0.841 n=5+5)
puffs_zlib_decode_10k/gcc       161MB/s ± 1%   162MB/s ± 0%    ~     (p=0.841 n=5+5)
puffs_zlib_decode_100k/gcc      194MB/s ± 0%   194MB/s ± 0%    ~     (p=0.841 n=5+5)
2017-11-05 07:16:04 +11:00
Nigel Tao fe5e9c68b3 Remove a superfluous while loop.
It's not obvious why the adler benchmark numbers also change (for the
better), but it seems superficially repeatable for fresh before/after
measurements. I'll take it for now, but perhaps the adler benchmarks
need to run for longer.

name                           old speed      new speed      delta

puffs_adler32_10k/clang        2.38GB/s ± 2%  2.45GB/s ± 0%  +2.87%  (p=0.008 n=5+5)
puffs_adler32_100k/clang       2.39GB/s ± 1%  2.44GB/s ± 0%  +2.42%  (p=0.008 n=5+5)
puffs_flate_decode_1k/clang     129MB/s ± 2%   133MB/s ± 0%  +3.41%  (p=0.008 n=5+5)
puffs_flate_decode_10k/clang    161MB/s ± 1%   174MB/s ± 0%  +8.46%  (p=0.008 n=5+5)
puffs_flate_decode_100k/clang   187MB/s ± 3%   205MB/s ± 0%  +9.51%  (p=0.008 n=5+5)
puffs_zlib_decode_10k/clang     150MB/s ± 1%   162MB/s ± 0%  +8.09%  (p=0.008 n=5+5)
puffs_zlib_decode_100k/clang    174MB/s ± 1%   188MB/s ± 0%  +8.13%  (p=0.008 n=5+5)

puffs_adler32_10k/gcc          3.12GB/s ± 3%  3.25GB/s ± 0%  +4.30%  (p=0.016 n=5+4)
puffs_adler32_100k/gcc         3.12GB/s ± 3%  3.25GB/s ± 0%  +4.15%  (p=0.008 n=5+5)
puffs_flate_decode_1k/gcc       128MB/s ± 3%   132MB/s ± 0%  +3.11%  (p=0.008 n=5+5)
puffs_flate_decode_10k/gcc      172MB/s ± 4%   170MB/s ± 0%    ~     (p=0.151 n=5+5)
puffs_flate_decode_100k/gcc     196MB/s ± 2%   207MB/s ± 0%  +5.46%  (p=0.008 n=5+5)
puffs_zlib_decode_10k/gcc       164MB/s ± 1%   161MB/s ± 1%  -1.34%  (p=0.008 n=5+5)
puffs_zlib_decode_100k/gcc      186MB/s ± 0%   194MB/s ± 0%  +4.12%  (p=0.016 n=4+5)
2017-11-05 06:57:10 +11:00
Nigel Tao f968950345 Read bits up front in decode_huffman_fast.
name                           old speed      new speed       delta

puffs_adler32_10k/clang        2.36GB/s ± 4%   2.38GB/s ± 2%     ~     (p=1.000 n=5+5)
puffs_adler32_100k/clang       2.39GB/s ± 4%   2.39GB/s ± 1%     ~     (p=0.841 n=5+5)
puffs_flate_decode_1k/clang     121MB/s ± 1%    129MB/s ± 2%   +5.95%  (p=0.008 n=5+5)
puffs_flate_decode_10k/clang    138MB/s ± 3%    161MB/s ± 1%  +16.52%  (p=0.008 n=5+5)
puffs_flate_decode_100k/clang   163MB/s ± 4%    187MB/s ± 3%  +14.50%  (p=0.008 n=5+5)
puffs_zlib_decode_10k/clang     132MB/s ± 2%    150MB/s ± 1%  +13.92%  (p=0.008 n=5+5)
puffs_zlib_decode_100k/clang    152MB/s ± 6%    174MB/s ± 1%  +14.60%  (p=0.008 n=5+5)

puffs_adler32_10k/gcc          3.25GB/s ± 0%   3.12GB/s ± 3%   -4.06%  (p=0.008 n=5+5)
puffs_adler32_100k/gcc         3.25GB/s ± 0%   3.12GB/s ± 3%   -3.99%  (p=0.008 n=5+5)
puffs_flate_decode_1k/gcc      95.1MB/s ± 0%  127.7MB/s ± 3%  +34.25%  (p=0.008 n=5+5)
puffs_flate_decode_10k/gcc      110MB/s ± 0%    172MB/s ± 4%  +55.66%  (p=0.008 n=5+5)
puffs_flate_decode_100k/gcc     121MB/s ± 0%    196MB/s ± 2%  +61.45%  (p=0.008 n=5+5)
puffs_zlib_decode_10k/gcc       112MB/s ± 0%    164MB/s ± 1%  +46.14%  (p=0.008 n=5+5)
puffs_zlib_decode_100k/gcc      123MB/s ± 0%    186MB/s ± 0%  +51.22%  (p=0.016 n=5+4)
2017-11-04 17:37:54 +11:00
Nigel Tao 36a93fa6b7 Add a TODO about impure functions. 2017-11-04 16:04:28 +11:00
Nigel Tao 1c7a6792de Tweak the decode_huffman_fast loop condition. 2017-11-04 15:19:40 +11:00
Nigel Tao 8fafcbcb31 Tweak the flate end_of_block check. 2017-11-04 14:54:56 +11:00
Nigel Tao aa1f0078db Add decode_huffman_fast.
It's not fast yet, and the immediate impact is indeed a significant
performance loss, but follow-up commits should make it faster.

name                           old speed      new speed      delta

puffs_adler32_10k/clang        2.41GB/s ± 0%  2.40GB/s ± 1%     ~     (p=0.222 n=5+5)
puffs_adler32_100k/clang       2.41GB/s ± 1%  2.39GB/s ± 1%   -0.97%  (p=0.016 n=5+5)
puffs_flate_decode_1k/clang     116MB/s ± 5%   115MB/s ± 0%     ~     (p=0.310 n=5+5)
puffs_flate_decode_10k/clang    145MB/s ± 0%   139MB/s ± 0%   -4.18%  (p=0.016 n=4+5)
puffs_flate_decode_100k/clang   164MB/s ± 5%   158MB/s ± 1%     ~     (p=0.151 n=5+5)
puffs_zlib_decode_10k/clang     135MB/s ± 2%   131MB/s ± 0%   -2.84%  (p=0.008 n=5+5)
puffs_zlib_decode_100k/clang    154MB/s ± 1%   148MB/s ± 2%   -4.09%  (p=0.016 n=4+5)

puffs_adler32_10k/gcc          3.13GB/s ± 4%  3.19GB/s ± 0%   +1.94%  (p=0.032 n=5+5)
puffs_adler32_100k/gcc         3.14GB/s ± 3%  3.20GB/s ± 3%     ~     (p=0.056 n=5+5)
puffs_flate_decode_1k/gcc       122MB/s ± 1%    94MB/s ± 1%  -22.84%  (p=0.008 n=5+5)
puffs_flate_decode_10k/gcc      143MB/s ± 0%   110MB/s ± 0%  -23.24%  (p=0.008 n=5+5)
puffs_flate_decode_100k/gcc     158MB/s ± 0%   118MB/s ± 0%  -24.98%  (p=0.008 n=5+5)
puffs_zlib_decode_10k/gcc       136MB/s ± 0%   119MB/s ± 1%  -12.63%  (p=0.008 n=5+5)
puffs_zlib_decode_100k/gcc      150MB/s ± 1%   124MB/s ± 2%  -17.17%  (p=0.008 n=5+5)
2017-11-04 14:45:11 +11:00
Nigel Tao c550ad9bda Add redundant but clearer continue/break labels. 2017-11-04 14:14:07 +11:00
Nigel Tao ded044da41 Add a flate end_of_block field. 2017-11-04 14:12:38 +11:00
Nigel Tao 4810db3994 Rename decode_huffman to decode_huffman_slow. 2017-11-04 13:38:24 +11:00
Nigel Tao c3420dd138 Refactor std/flate/*.puffs code. 2017-11-04 13:31:39 +11:00
Nigel Tao a36535ec6d Generate "static" for private functions. 2017-11-04 11:43:48 +11:00
Nigel Tao 9ebcd54d43 Discuss "puffs bench" in doc/benchmarks.md. 2017-11-04 11:33:49 +11:00
Nigel Tao a0fd42f6d4 Add a puffs/cmd/commonflags package. 2017-11-04 11:09:14 +11:00
Nigel Tao 66047db6d8 Be more paranoid about calling strncmp. 2017-11-04 10:49:23 +11:00
Nigel Tao 6602dea7be Make focus's "/gcc" suffix optional. 2017-11-04 10:40:43 +11:00
Nigel Tao 4729170678 Make focus's "Benchmark" prefix optional. 2017-11-04 10:25:24 +11:00
Nigel Tao 0230a65c7b Let focus have a trailing comma. 2017-11-04 10:21:32 +11:00
Nigel Tao c62aa518a5 Make focus's "test_" or "bench_" prefix optional. 2017-11-04 10:05:37 +11:00
Nigel Tao 7e654ba652 Note that -focus specifies a prefix. 2017-11-04 09:55:42 +11:00
Nigel Tao 1487da7af8 Add a -focus flag. 2017-11-03 17:54:29 +11:00
Nigel Tao e3643574d7 Fix script/inline-c-relative-includes.go. 2017-11-03 15:33:23 +11:00
Nigel Tao aec5715f12 Declare proc_filename exactly once. 2017-11-03 15:09:22 +11:00
Nigel Tao e57c8d77db Add script/inline-c-relative-includes.go. 2017-11-03 15:05:19 +11:00
Nigel Tao 558d8ddbbd Restrict tPrefix temporary variables's scope. 2017-11-03 14:00:35 +11:00
Nigel Tao acec19e969 Add genFilenameLineComments. 2017-11-03 12:28:15 +11:00
Nigel Tao d7c910fd1b Avoid "array decl needs an explicit size". 2017-11-03 12:11:21 +11:00
Nigel Tao eefe590e04 Remove unreachable coroutine suspension code. 2017-11-03 11:57:07 +11:00
Nigel Tao 346b3d4107 Avoid a -Wc++11-narrowing warning. 2017-11-03 11:44:35 +11:00
Nigel Tao 94eba81892 Have mimiclib accept both giflib v4 and v5. 2017-11-03 11:35:16 +11:00
Nigel Tao 0e136f59af Use an explicitly typed tc_neither. 2017-11-03 11:18:38 +11:00
Nigel Tao b7f347d406 Fix a "return false as char*" typo. 2017-11-03 11:15:38 +11:00
Nigel Tao 7f47f19d4a Don't hard-code the printf signature. 2017-11-03 11:14:05 +11:00
Nigel Tao f8146cf1c6 Remove more PUFFS_USE_NO_OP_PERFORMANCE_HACKS. 2017-11-03 10:15:43 +11:00
Nigel Tao e3822f9951 Re-introduce puffs_base__limit1.
It's not immediately obvious why this data structure performs differently, but
on net, the benchmark numbers seem better. It also won't require any
PUFFS_USE_NO_OP_PERFORMANCE_HACKS or "redundant but mysteriously performant"
use_limit fields.

name                             old speed      new speed      delta

puffs_adler32_10k/clang          2.46GB/s ± 0%  2.43GB/s ± 3%     ~     (p=0.513 n=5+10)
puffs_adler32_100k/clang         2.46GB/s ± 0%  2.44GB/s ± 2%     ~     (p=0.241 n=5+10)
puffs_flate_decode_1k/clang       122MB/s ± 1%   119MB/s ± 2%   -1.86%  (p=0.013 n=5+10)
puffs_flate_decode_10k/clang      147MB/s ± 0%   142MB/s ± 2%   -3.47%  (p=0.001 n=5+10)
puffs_flate_decode_100k/clang     161MB/s ± 0%   161MB/s ± 4%     ~     (p=0.635 n=4+10)
puffs_zlib_decode_10k/clang       139MB/s ± 0%   135MB/s ± 1%   -2.69%  (p=0.001 n=5+10)
puffs_zlib_decode_100k/clang      151MB/s ± 0%   152MB/s ± 3%     ~     (p=1.000 n=5+10)

puffs_adler32_10k/gcc            3.21GB/s ± 1%  3.18GB/s ± 2%     ~     (p=0.310 n=5+10)
puffs_adler32_100k/gcc           3.22GB/s ± 0%  3.19GB/s ± 2%     ~     (p=0.075 n=5+10)
puffs_flate_decode_1k/gcc         121MB/s ± 4%   126MB/s ± 1%   +4.54%  (p=0.002 n=5+8)
puffs_flate_decode_10k/gcc        144MB/s ± 1%   141MB/s ± 1%   -2.52%  (p=0.001 n=5+9)
puffs_flate_decode_100k/gcc       154MB/s ± 1%   158MB/s ± 0%   +2.39%  (p=0.001 n=5+9)
puffs_zlib_decode_10k/gcc         137MB/s ± 2%   135MB/s ± 1%     ~     (p=0.055 n=5+10)
puffs_zlib_decode_100k/gcc        146MB/s ± 2%   150MB/s ± 0%   +2.87%  (p=0.001 n=5+10)

puffs_gif_lzw_decode_20k/clang    132MB/s ± 0%   125MB/s ± 0%   -5.24%  (p=0.001 n=5+10)
puffs_gif_lzw_decode_100k/clang   176MB/s ± 0%   164MB/s ± 0%   -6.82%  (p=0.001 n=5+9)
puffs_gif_decode_1k/clang         363MB/s ± 0%   339MB/s ± 1%   -6.58%  (p=0.002 n=4+10)
puffs_gif_decode_10k/clang        138MB/s ± 0%   133MB/s ± 1%   -3.77%  (p=0.001 n=5+10)
puffs_gif_decode_100k/clang       125MB/s ± 0%   119MB/s ± 0%   -4.79%  (p=0.001 n=5+10)
puffs_gif_decode_1000k/clang      127MB/s ± 0%   121MB/s ± 0%   -5.04%  (p=0.001 n=5+10)

puffs_gif_lzw_decode_20k/gcc      141MB/s ± 0%   140MB/s ± 2%     ~     (p=1.000 n=5+10)
puffs_gif_lzw_decode_100k/gcc     182MB/s ± 0%   180MB/s ± 2%   -1.56%  (p=0.001 n=5+10)
puffs_gif_decode_1k/gcc           363MB/s ± 0%   409MB/s ± 3%  +12.71%  (p=0.001 n=5+10)
puffs_gif_decode_10k/gcc          127MB/s ± 0%   161MB/s ± 3%  +26.15%  (p=0.001 n=5+10)
puffs_gif_decode_100k/gcc         112MB/s ± 0%   136MB/s ± 2%  +21.95%  (p=0.001 n=5+10)
puffs_gif_decode_1000k/gcc        114MB/s ± 0%   140MB/s ± 2%  +22.78%  (p=0.001 n=5+10)
2017-11-03 10:09:57 +11:00
Nigel Tao 4158d7eae7 Avoid redundantly setting end ptrs after resume.
No significant benchmark changes.
2017-11-02 18:29:37 +11:00
Nigel Tao 0a7382cfac Remove some PUFFS_USE_NO_OP_PERFORMANCE_HACKS.
They don't seem to actually help the benchmark numbers in a robust way.
2017-11-02 18:23:03 +11:00
Nigel Tao e5db8233fc Re-introduce writer1.use_limit.
Nobody uses it yet, as we only decode and not encode, but it's there for
symmetry.

No benchmark changes, as nobody uses it yet.
2017-11-02 16:46:03 +11:00
Nigel Tao 7d8085f891 Re-introduce reader1.use_limit.
The std/flate benchmarks get better. The std/gif benchmarks get worse,
but that's possibly because the PUFFS_USE_NO_OP_PERFORMANCE_HACKS hacks
are fragile.

name                             old speed      new speed      delta

puffs_adler32_10k/clang          2.45GB/s ± 0%  2.45GB/s ± 0%     ~     (p=0.310 n=5+5)
puffs_adler32_100k/clang         2.46GB/s ± 0%  2.46GB/s ± 0%     ~     (p=0.690 n=5+5)
puffs_flate_decode_1k/clang       113MB/s ± 0%   113MB/s ± 0%     ~     (p=0.690 n=5+5)
puffs_flate_decode_10k/clang      140MB/s ± 0%   140MB/s ± 0%     ~     (p=0.222 n=5+5)
puffs_flate_decode_100k/clang     151MB/s ± 0%   151MB/s ± 0%     ~     (p=0.095 n=5+5)
puffs_zlib_decode_10k/clang       132MB/s ± 1%   132MB/s ± 0%     ~     (p=0.548 n=5+5)
puffs_zlib_decode_100k/clang      143MB/s ± 0%   143MB/s ± 0%     ~     (p=0.730 n=5+4)

puffs_adler32_10k/gcc            3.26GB/s ± 0%  3.26GB/s ± 0%     ~     (p=0.548 n=5+5)
puffs_adler32_100k/gcc           3.27GB/s ± 0%  3.27GB/s ± 0%     ~     (p=0.841 n=5+5)
puffs_flate_decode_1k/gcc         108MB/s ± 0%   125MB/s ± 0%  +14.97%  (p=0.008 n=5+5)
puffs_flate_decode_10k/gcc        128MB/s ± 0%   148MB/s ± 0%  +15.48%  (p=0.016 n=4+5)
puffs_flate_decode_100k/gcc       136MB/s ± 0%   158MB/s ± 0%  +16.40%  (p=0.008 n=5+5)
puffs_zlib_decode_10k/gcc         123MB/s ± 0%   141MB/s ± 0%  +14.70%  (p=0.016 n=4+5)
puffs_zlib_decode_100k/gcc        131MB/s ± 0%   151MB/s ± 0%  +15.60%  (p=0.016 n=5+4)

puffs_gif_lzw_decode_20k/clang    131MB/s ± 1%   128MB/s ± 3%   -2.04%  (p=0.032 n=5+5)
puffs_gif_lzw_decode_100k/clang   172MB/s ± 1%   173MB/s ± 1%     ~     (p=0.151 n=5+5)
puffs_gif_decode_1k/clang         351MB/s ± 3%   341MB/s ± 5%     ~     (p=0.310 n=5+5)
puffs_gif_decode_10k/clang        138MB/s ± 1%   134MB/s ± 3%   -3.34%  (p=0.008 n=5+5)
puffs_gif_decode_100k/clang       122MB/s ± 2%   122MB/s ± 2%     ~     (p=1.000 n=5+5)
puffs_gif_decode_1000k/clang      126MB/s ± 1%   122MB/s ± 4%   -3.07%  (p=0.016 n=5+5)

puffs_gif_lzw_decode_20k/gcc      140MB/s ± 3%   140MB/s ± 3%     ~     (p=0.421 n=5+5)
puffs_gif_lzw_decode_100k/gcc     187MB/s ± 2%   184MB/s ± 1%     ~     (p=0.056 n=5+5)
puffs_gif_decode_1k/gcc           401MB/s ± 1%   357MB/s ± 1%  -10.88%  (p=0.008 n=5+5)
puffs_gif_decode_10k/gcc          154MB/s ± 1%   126MB/s ± 1%  -18.42%  (p=0.008 n=5+5)
puffs_gif_decode_100k/gcc         131MB/s ± 2%   109MB/s ± 0%  -17.37%  (p=0.008 n=5+5)
puffs_gif_decode_1000k/gcc        135MB/s ± 1%   111MB/s ± 1%  -17.65%  (p=0.008 n=5+5)
2017-11-02 16:35:15 +11:00
Nigel Tao ed6ce6fd54 Add PUFFS_USE_NO_OP_PERFORMANCE_HACKS.
name                             old speed      new speed      delta

puffs_adler32_10k/gcc            3.26GB/s ± 0%  3.26GB/s ± 0%     ~     (p=0.222 n=5+5)
puffs_adler32_100k/gcc           3.27GB/s ± 0%  3.27GB/s ± 0%   -0.12%  (p=0.032 n=5+5)
puffs_flate_decode_1k/gcc         108MB/s ± 0%   108MB/s ± 0%     ~     (p=0.841 n=5+5)
puffs_flate_decode_10k/gcc        128MB/s ± 0%   128MB/s ± 0%     ~     (p=0.057 n=4+4)
puffs_flate_decode_100k/gcc       136MB/s ± 0%   136MB/s ± 0%     ~     (p=0.222 n=5+5)
puffs_zlib_decode_10k/gcc         123MB/s ± 0%   123MB/s ± 0%     ~     (p=0.730 n=5+4)
puffs_zlib_decode_100k/gcc        130MB/s ± 0%   131MB/s ± 0%     ~     (p=1.000 n=5+5)

puffs_gif_lzw_decode_20k/gcc      137MB/s ± 4%   140MB/s ± 3%     ~     (p=0.095 n=5+5)
puffs_gif_lzw_decode_100k/gcc     177MB/s ± 3%   187MB/s ± 2%   +5.75%  (p=0.008 n=5+5)
puffs_gif_decode_1k/gcc           348MB/s ± 0%   401MB/s ± 1%  +15.34%  (p=0.016 n=4+5)
puffs_gif_decode_10k/gcc          121MB/s ± 5%   154MB/s ± 1%  +27.90%  (p=0.008 n=5+5)
puffs_gif_decode_100k/gcc         106MB/s ± 4%   131MB/s ± 2%  +24.35%  (p=0.008 n=5+5)
puffs_gif_decode_1000k/gcc        109MB/s ± 2%   135MB/s ± 1%  +24.03%  (p=0.008 n=5+5)
2017-11-02 14:51:29 +11:00
Nigel Tao 4b572702f9 Remove the return error "foo" special case. 2017-10-27 14:39:48 +11:00