Nigel Tao
ca50faaa92
test/3pdata: add more commentary about djpeg diffs
2023-09-26 22:09:25 +10:00
Nigel Tao
bffbad69a4
cgen: halve the sizeof wuffs_foo__bar::unique_ptr
2023-09-24 21:22:22 +10:00
Nigel Tao
bdba035779
cgen: ignore -Wcast-qual when making a roslice
2023-09-24 12:18:52 +10:00
Nigel Tao
70c1a78cd8
test/3pdata: add etc-blinksuite.commentary.md
2023-09-24 11:50:55 +10:00
Nigel Tao
d6dceacf5e
root: add Mascot section to the README.md
2023-09-23 12:11:32 +10:00
Nigel Tao
186bdc5fe2
Roll back 'decode truncated... on MCU boundaries'
...
See the previous commit for the rationale.
2023-09-16 20:53:15 +10:00
Nigel Tao
a3cecef69a
std/jpeg: decode truncated JPEGs on MCU boundaries
...
This only affects truncated (malformed) JPEGs. It moves Wuffs' std/jpeg
decoder closer to libjpeg-turbo, as seen by the "hash of the decoded
output" for test/data/peacock.default.truncated.jpeg now matching
test/data/peacock.default.truncated.decoded-by-djpeg.png instead of
test/data/peacock.default.truncated.decoded-by-wuffs.png
The decoding of test/data/peacock.progressive.truncated.jpeg is not yet
affected, requiring further investigation, but a future commit could
similarly make that match djpeg.
The two libraries don't use exactly the same algorithm because, for
performance, Wuffs' decoder reads from the bitstream 8 bytes at a time
where libjpeg-turbo reads only 1 byte at a time.
While this change moves Wuffs' output closer to libjpeg-turbo (to
repeat, only for truncated JPEGs; well-formed JPEGs are unaffected), the
benchmarks below show a negative performance impact, and visual
inspection of test/data/peacock.*.truncated.decoded-by-*.png shows that
matching libjpeg-turbo *exactly* on truncated JPEGs doesn't actually
always look better.
On balance, it doesn't seem worth it to keep this change (and spend more
time on that further investigation).
This commit will soon be followed by a rollback, but it is committed
anyway so that we can refer to these numbers in the git log.
name old speed new speed delta
wuffs_jpeg_decode_19k_8bpp/clang11 378MB/s ± 0% 364MB/s ± 0% -3.53% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11 325MB/s ± 0% 340MB/s ± 0% +4.62% (p=0.016 n=5+4)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11 1.02GB/s ± 0% 0.99GB/s ± 0% -2.64% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11 842MB/s ± 0% 815MB/s ± 0% -3.16% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11 916MB/s ± 0% 887MB/s ± 0% -3.08% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11 1.10GB/s ± 0% 1.07GB/s ± 2% -3.39% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11 919MB/s ± 0% 892MB/s ± 0% -2.95% (p=0.008 n=5+5)
wuffs_jpeg_decode_19k_8bpp/gcc10 360MB/s ± 0% 348MB/s ± 0% -3.34% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10 290MB/s ± 0% 283MB/s ± 0% -2.46% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10 925MB/s ± 0% 909MB/s ± 0% -1.70% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10 758MB/s ± 0% 732MB/s ± 0% -3.43% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10 829MB/s ± 0% 799MB/s ± 0% -3.54% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10 981MB/s ± 0% 964MB/s ± 0% -1.72% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10 835MB/s ± 0% 811MB/s ± 0% -2.89% (p=0.008 n=5+5)
2023-09-16 20:49:46 +10:00
Nigel Tao
721463be95
test/data: add PNGs of truncated-JPEG decodings
...
"Decoded by wuffs" means as of commit 268b9594 .
"Decoded by djpeg" means as of libjpeg-turbo version 3.0.1.
2023-09-16 14:43:19 +10:00
Nigel Tao
268b959462
script: add print-jpeg-markers.go
...
Also make truncate-progressive-jpeg.go work with reset markers.
2023-09-10 18:12:55 +10:00
Nigel Tao
d89ec2d40b
std/jpeg: drain bitstream for truncated input
...
name old speed new speed delta
wuffs_jpeg_decode_19k_8bpp/clang11 367MB/s ± 0% 378MB/s ± 0% +2.91% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11 333MB/s ± 0% 325MB/s ± 0% -2.46% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11 1.00GB/s ± 0% 1.02GB/s ± 0% +1.37% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11 822MB/s ± 0% 842MB/s ± 0% +2.39% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11 898MB/s ± 0% 916MB/s ± 0% +1.98% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11 1.09GB/s ± 0% 1.10GB/s ± 0% +1.21% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11 898MB/s ± 0% 919MB/s ± 0% +2.29% (p=0.008 n=5+5)
wuffs_jpeg_decode_19k_8bpp/gcc10 362MB/s ± 0% 360MB/s ± 0% -0.55% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10 292MB/s ± 0% 290MB/s ± 0% -0.57% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10 934MB/s ± 0% 925MB/s ± 0% -1.03% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10 759MB/s ± 0% 758MB/s ± 0% -0.25% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10 828MB/s ± 0% 829MB/s ± 0% ~ (p=0.222 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10 1.00GB/s ± 0% 0.98GB/s ± 0% -1.44% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10 837MB/s ± 0% 835MB/s ± 0% -0.29% (p=0.008 n=5+5)
2023-08-28 19:35:08 +10:00
Nigel Tao
813c054c18
example: add ALLOW_GIGABYTES_OF_PIXEL_BUFFERS
2023-08-27 22:15:09 +10:00
Nigel Tao
4f67db8842
script: confirm-matches-djpeg note truncated input
2023-08-27 21:17:57 +10:00
Nigel Tao
00d180ae74
std/jpeg: make decode_mcu* num-bits ask consistent
...
name old speed new speed delta
wuffs_jpeg_decode_19k_8bpp/clang11 367MB/s ± 0% 367MB/s ± 0% -0.13% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11 332MB/s ± 0% 333MB/s ± 0% +0.41% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11 1.00GB/s ± 0% 1.00GB/s ± 0% +0.44% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11 821MB/s ± 0% 822MB/s ± 0% +0.13% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11 896MB/s ± 0% 898MB/s ± 0% +0.17% (p=0.032 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11 1.09GB/s ± 0% 1.09GB/s ± 0% ~ (p=0.095 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11 898MB/s ± 0% 898MB/s ± 0% ~ (p=0.786 n=5+5)
wuffs_jpeg_decode_19k_8bpp/gcc10 364MB/s ± 0% 362MB/s ± 0% -0.45% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10 293MB/s ± 0% 292MB/s ± 0% -0.31% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10 932MB/s ± 0% 934MB/s ± 0% +0.20% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10 762MB/s ± 0% 759MB/s ± 0% -0.35% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10 833MB/s ± 0% 828MB/s ± 0% -0.54% (p=0.016 n=4+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10 1.00GB/s ± 0% 1.00GB/s ± 0% -0.25% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10 841MB/s ± 0% 837MB/s ± 0% -0.49% (p=0.016 n=4+5)
2023-08-27 10:35:05 +10:00
Nigel Tao
dfe5bcd36e
std/jpeg: decode something for truncated input
2023-08-27 10:15:40 +10:00
Nigel Tao
45350db8ca
test/data: add peacock.*.truncated.jpeg
2023-08-26 10:41:46 +10:00
Nigel Tao
80e847dceb
std/jpeg: stash mcu_blocks during progressive IDCT
2023-08-25 23:03:06 +10:00
Nigel Tao
4417dcea4e
std/jpeg: use default Huffman tables if missing
2023-08-24 16:18:11 +10:00
Nigel Tao
eca57ef5b3
base: add status.is_truncated_input_error
...
This just adds a C/C++ function/method. We may or may not add the
corresponding Wuffs method in a future commit.
2023-08-24 16:11:15 +10:00
Nigel Tao
7d4ef9c122
fuzz: let pixel_swizzler_fuzzer do 4 components
2023-08-22 16:31:38 +10:00
Nigel Tao
7cdeeadbf4
fuzz: fix pixel_swizzler_fuzzer build
2023-08-21 22:22:31 +10:00
Nigel Tao
6489915ed3
std/jpeg: decode CMYK and YCbCrK JPEGs
...
Once again, the benchmarks don't exercise the CMYK / YCbCrK code paths
per se, but here are the numbers:
name old speed new speed delta
wuffs_jpeg_decode_19k_8bpp/clang11 376MB/s ± 0% 376MB/s ± 0% ~ (p=0.310 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11 341MB/s ± 0% 340MB/s ± 0% -0.42% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11 1.01GB/s ± 0% 1.01GB/s ± 0% +0.27% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11 836MB/s ± 1% 839MB/s ± 0% +0.37% (p=0.016 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11 912MB/s ± 0% 914MB/s ± 0% +0.28% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11 1.10GB/s ± 0% 1.11GB/s ± 0% +0.82% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11 916MB/s ± 0% 916MB/s ± 0% ~ (p=0.841 n=5+5)
wuffs_jpeg_decode_19k_8bpp/gcc10 368MB/s ± 0% 361MB/s ± 0% -1.87% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10 279MB/s ± 0% 292MB/s ± 0% +4.68% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10 947MB/s ± 1% 930MB/s ± 0% -1.74% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10 770MB/s ± 0% 760MB/s ± 0% -1.32% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10 838MB/s ± 0% 826MB/s ± 0% -1.36% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10 1.00GB/s ± 0% 1.01GB/s ± 0% +1.04% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10 847MB/s ± 0% 833MB/s ± 0% -1.67% (p=0.008 n=5+5)
2023-08-21 22:13:39 +10:00
Nigel Tao
f569699221
pixconv: rename private etc__convert_func type
2023-08-21 19:34:47 +10:00
Nigel Tao
72b9c23120
std/jpeg: decode RGB (not just YCbCr) JPEGs
...
The benchmarks don't exercise the RGB code paths per se, but it does
affect the numbers. Especially for gcc, this essentially undoes the
performance impact of the previous (trivial) commit. This is all
presumably another code alignment coincidence per
https://news.ycombinator.com/item?id=23633583
name old speed new speed delta
wuffs_jpeg_decode_19k_8bpp/clang11 376MB/s ± 0% 376MB/s ± 0% ~ (p=1.000 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11 338MB/s ± 0% 341MB/s ± 0% +0.98% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11 1.01GB/s ± 0% 1.01GB/s ± 0% +0.35% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11 841MB/s ± 0% 836MB/s ± 1% -0.65% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11 913MB/s ± 0% 912MB/s ± 0% -0.18% (p=0.016 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11 1.11GB/s ± 0% 1.10GB/s ± 0% -0.34% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11 920MB/s ± 0% 916MB/s ± 0% -0.42% (p=0.008 n=5+5)
wuffs_jpeg_decode_19k_8bpp/gcc10 349MB/s ± 0% 368MB/s ± 0% +5.60% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10 328MB/s ± 0% 279MB/s ± 0% -14.82% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10 925MB/s ± 0% 947MB/s ± 1% +2.33% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10 732MB/s ± 0% 770MB/s ± 0% +5.23% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10 798MB/s ± 0% 838MB/s ± 0% +4.99% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10 962MB/s ± 0% 996MB/s ± 0% +3.54% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10 806MB/s ± 0% 847MB/s ± 0% +5.19% (p=0.008 n=5+5)
2023-08-21 16:12:21 +10:00
Nigel Tao
748e44fe71
base: skip bulk load/save on short slice length
...
This is about semantics (being easier to reason about if transforming
between u32 and u8 and the u8 slice length is short and not a multiple
of 4). It's not an optimization per se, but for the record, it does have
significant performance impact:
name old speed new speed delta
wuffs_jpeg_decode_19k_8bpp/clang11 369MB/s ± 0% 376MB/s ± 0% +1.97% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11 309MB/s ± 0% 338MB/s ± 0% +9.29% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11 1.00GB/s ± 0% 1.01GB/s ± 0% +1.31% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11 827MB/s ± 0% 841MB/s ± 0% +1.76% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11 897MB/s ± 0% 913MB/s ± 0% +1.86% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11 1.10GB/s ± 0% 1.11GB/s ± 0% +0.11% (p=0.024 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11 900MB/s ± 0% 920MB/s ± 0% +2.20% (p=0.008 n=5+5)
wuffs_jpeg_decode_19k_8bpp/gcc10 369MB/s ± 0% 349MB/s ± 0% -5.45% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10 283MB/s ± 0% 328MB/s ± 0% +15.76% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10 945MB/s ± 0% 925MB/s ± 0% -2.12% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10 769MB/s ± 0% 732MB/s ± 0% -4.88% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10 842MB/s ± 0% 798MB/s ± 0% -5.25% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10 1.01GB/s ± 0% 0.96GB/s ± 0% -4.77% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10 848MB/s ± 0% 806MB/s ± 0% -4.96% (p=0.008 n=5+5)
2023-08-19 21:18:53 +10:00
Nigel Tao
14a8bd0feb
std/jpeg: allow fewer-components sequential scans
...
name old speed new speed delta
wuffs_jpeg_decode_19k_8bpp/clang11 366MB/s ± 0% 369MB/s ± 0% +0.81% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11 302MB/s ± 0% 309MB/s ± 0% +2.28% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11 1.00GB/s ± 0% 1.00GB/s ± 0% -0.58% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11 820MB/s ± 0% 827MB/s ± 0% +0.80% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11 895MB/s ± 0% 897MB/s ± 0% +0.24% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11 1.11GB/s ± 0% 1.10GB/s ± 0% -0.30% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11 897MB/s ± 0% 900MB/s ± 0% +0.30% (p=0.008 n=5+5)
wuffs_jpeg_decode_19k_8bpp/gcc10 370MB/s ± 0% 369MB/s ± 0% -0.26% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10 309MB/s ± 0% 283MB/s ± 0% -8.35% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10 948MB/s ± 0% 945MB/s ± 0% -0.27% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10 769MB/s ± 0% 769MB/s ± 0% ~ (p=0.310 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10 841MB/s ± 0% 842MB/s ± 0% +0.13% (p=0.016 n=4+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10 1.00GB/s ± 0% 1.01GB/s ± 0% +0.75% (p=0.016 n=4+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10 846MB/s ± 0% 848MB/s ± 0% +0.22% (p=0.008 n=5+5)
2023-08-19 17:22:47 +10:00
Nigel Tao
2f5f203d1b
test/3pdata: regenerate nia-checksums-of-*.txt
2023-08-19 17:18:11 +10:00
Nigel Tao
41d0c095c8
std/jpeg: implement block smoothing
...
"script/confirm-matches-djpeg.sh test/data/*.jpeg" is now all matches.
name old speed new speed delta
wuffs_jpeg_decode_19k_8bpp/clang11 369MB/s ± 0% 366MB/s ± 0% -0.79% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11 335MB/s ± 0% 302MB/s ± 0% -9.93% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11 1.01GB/s ± 0% 1.00GB/s ± 0% -1.07% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11 829MB/s ± 0% 820MB/s ± 0% -1.03% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11 903MB/s ± 0% 895MB/s ± 0% -0.93% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11 1.12GB/s ± 0% 1.11GB/s ± 0% -1.28% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11 906MB/s ± 0% 897MB/s ± 0% -0.93% (p=0.008 n=5+5)
wuffs_jpeg_decode_19k_8bpp/gcc10 350MB/s ± 0% 370MB/s ± 0% +5.54% (p=0.016 n=4+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10 334MB/s ± 0% 309MB/s ± 0% -7.46% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10 924MB/s ± 0% 948MB/s ± 0% +2.61% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10 745MB/s ± 0% 769MB/s ± 0% +3.25% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10 813MB/s ± 0% 841MB/s ± 0% +3.41% (p=0.029 n=4+4)
wuffs_jpeg_decode_552k_24bpp_444/gcc10 1.00GB/s ± 0% 1.00GB/s ± 0% +0.25% (p=0.029 n=4+4)
wuffs_jpeg_decode_4002k_24bpp/gcc10 821MB/s ± 0% 846MB/s ± 0% +3.00% (p=0.008 n=5+5)
2023-08-19 17:16:51 +10:00
Nigel Tao
d60bfb05e8
check: ban bulk methods on slices of refined types
2023-08-06 15:30:42 +10:00
Nigel Tao
be9d3fcf0f
example/convert-to-nia: add -output-netpbm flag
2023-08-06 10:49:53 +10:00
Nigel Tao
9c3275658a
doc: add note about shipping in Google Chrome M93
2023-08-03 17:38:43 +10:00
Nigel Tao
fd5ab5f7b3
pixconv: tweak "if (triangle_filter_for_2to1)"
2023-07-31 16:05:10 +10:00
Nigel Tao
836a878861
pixconv: remove unused total_src_len? variables
2023-07-31 09:38:00 +10:00
Nigel Tao
5afaa8911c
pixconv: guard swizzle_ycc__etc__avx2 with #ifdef
2023-07-30 18:52:16 +10:00
Nigel Tao
e60966aa45
pixconv: remove some obsolete swizzle_ycc code
2023-07-30 17:49:19 +10:00
Nigel Tao
b3d0d7b855
pixconv: apply YCC->RGB SIMD code to 444 JPEGs
...
name old speed new speed delta
wuffs_jpeg_decode_19k_8bpp/clang11 368MB/s ± 0% 368MB/s ± 0% ~ (p=0.421 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11 333MB/s ± 0% 335MB/s ± 0% +0.54% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11 1.01GB/s ± 0% 1.01GB/s ± 0% +0.38% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11 829MB/s ± 0% 828MB/s ± 0% -0.16% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11 902MB/s ± 0% 902MB/s ± 0% ~ (p=0.690 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11 649MB/s ± 0% 1121MB/s ± 0% +72.72% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11 905MB/s ± 0% 906MB/s ± 0% ~ (p=0.222 n=5+5)
wuffs_jpeg_decode_19k_8bpp/gcc10 362MB/s ± 0% 351MB/s ± 0% -3.06% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10 328MB/s ± 0% 330MB/s ± 0% +0.53% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10 926MB/s ± 0% 921MB/s ± 0% -0.54% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10 757MB/s ± 0% 743MB/s ± 0% -1.83% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10 835MB/s ± 0% 814MB/s ± 0% -2.55% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10 655MB/s ± 0% 1001MB/s ± 0% +52.74% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10 843MB/s ± 0% 820MB/s ± 0% -2.70% (p=0.016 n=4+5)
2023-07-30 15:56:59 +10:00
Nigel Tao
3dbfb00c42
pixconv: add godbolt comment for upsample code
2023-07-29 11:49:08 +10:00
Nigel Tao
2687d1daaf
pixconv: fix -Werror=pedantic/overflow errors
2023-07-23 22:11:19 +10:00
Nigel Tao
bfc7fc2f45
std/jpeg: add upsample_inv_h2v2 GCC AVX2 comment
2023-07-23 22:04:02 +10:00
Nigel Tao
51bc60ef92
std/jpeg: avoid AVX2 upsample_inv_h2v2 for GCC
...
name old speed new speed delta
wuffs_jpeg_decode_19k_8bpp/clang11 369MB/s ± 0% 368MB/s ± 0% ~ (p=1.000 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11 332MB/s ± 0% 333MB/s ± 0% +0.46% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11 1.01GB/s ± 0% 1.01GB/s ± 0% ~ (p=1.000 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11 829MB/s ± 0% 829MB/s ± 0% ~ (p=0.905 n=4+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11 902MB/s ± 0% 902MB/s ± 0% ~ (p=0.548 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11 649MB/s ± 0% 649MB/s ± 0% ~ (p=0.841 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11 904MB/s ± 0% 905MB/s ± 0% +0.14% (p=0.008 n=5+5)
wuffs_jpeg_decode_19k_8bpp/gcc10 322MB/s ± 0% 362MB/s ± 0% +12.60% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10 284MB/s ± 0% 328MB/s ± 0% +15.63% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10 908MB/s ± 0% 926MB/s ± 0% +2.04% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10 730MB/s ± 0% 757MB/s ± 0% +3.76% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10 785MB/s ± 0% 835MB/s ± 0% +6.40% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10 625MB/s ± 0% 655MB/s ± 0% +4.76% (p=0.016 n=4+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10 783MB/s ± 0% 843MB/s ± 0% +7.57% (p=0.016 n=5+4)
2023-07-23 21:59:52 +10:00
Nigel Tao
5dfc913cb0
base: let cpu_arch__have_x86_etc return true
2023-07-23 21:48:33 +10:00
Nigel Tao
e2b9566fc5
base: restrict x86_avx2 to 64-bit (not 32-bit) x86
...
32-bit C/C++ compilers don't always compile the AVX intrinsics. Per the
60773 bug below,
> clang++ -m32 etc etc fuzz/c/std/jpeg_fuzzer.c
> undefined reference to `_mm_cvtsi128_si64'
> undefined reference to `_mm256_extract_epi64'
See also the "#ifdef __x86_64__" guards in
https://github.com/gcc-mirror/gcc/blob/4a3895903c29ed85da6fcb886f31ff23d4c6e935/gcc/config/i386/emmintrin.h#L228-L231
https://github.com/llvm/llvm-project/blob/08fab9ebecf72a682279d75489dc2460121cbeed/clang/lib/Headers/emmintrin.h#L3502-L3515
Note that -m32 is not the same as -mx32
> $ touch empty.c
> $ gcc -dM -E empty.c | grep -E '__i386__|__x86_64__'
> #define __x86_64__ 1
> $ gcc -m32 -dM -E empty.c | grep -E '__i386__|__x86_64__'
> #define __i386__ 1
> $ gcc -mx32 -dM -E empty.c | grep -E '__i386__|__x86_64__'
> #define __x86_64__ 1
Updates https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=60773
2023-07-23 21:20:35 +10:00
Nigel Tao
605b10a492
pixconv: fix cpu_arch__have_x86_avx2 copy/pasto
...
Not sure why the benchmark numbers change, but they do.
name old speed new speed delta
wuffs_jpeg_decode_19k_8bpp/clang11 376MB/s ± 0% 369MB/s ± 0% -2.06% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11 311MB/s ± 0% 332MB/s ± 0% +6.69% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11 1.02GB/s ± 0% 1.01GB/s ± 0% -1.35% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11 842MB/s ± 0% 829MB/s ± 0% -1.54% (p=0.016 n=5+4)
wuffs_jpeg_decode_552k_24bpp_420/clang11 917MB/s ± 0% 902MB/s ± 0% -1.62% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11 649MB/s ± 0% 649MB/s ± 0% ~ (p=0.548 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11 921MB/s ± 0% 904MB/s ± 0% -1.82% (p=0.008 n=5+5)
wuffs_jpeg_decode_19k_8bpp/gcc10 326MB/s ± 0% 322MB/s ± 0% -1.26% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10 292MB/s ± 0% 284MB/s ± 0% -2.69% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10 920MB/s ± 0% 908MB/s ± 0% -1.31% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10 742MB/s ± 0% 730MB/s ± 0% -1.62% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10 792MB/s ± 0% 785MB/s ± 0% -0.94% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10 627MB/s ± 0% 625MB/s ± 0% -0.23% (p=0.029 n=4+4)
wuffs_jpeg_decode_4002k_24bpp/gcc10 792MB/s ± 0% 783MB/s ± 0% -1.13% (p=0.008 n=5+5)
2023-07-23 21:13:43 +10:00
Nigel Tao
cd769a0cdf
pixconv: add upsample_inv_h2v2_triangle_x86_avx2
...
name old speed new speed delta
wuffs_jpeg_decode_19k_8bpp/clang11 370MB/s ± 0% 376MB/s ± 0% +1.84% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11 295MB/s ± 0% 311MB/s ± 0% +5.56% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11 726MB/s ± 0% 1021MB/s ± 0% +40.62% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11 622MB/s ± 0% 842MB/s ± 0% +35.49% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11 659MB/s ± 0% 917MB/s ± 0% +39.15% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11 649MB/s ± 0% 649MB/s ± 0% -0.09% (p=0.016 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11 675MB/s ± 0% 921MB/s ± 0% +36.49% (p=0.008 n=5+5)
wuffs_jpeg_decode_19k_8bpp/gcc10 351MB/s ± 0% 326MB/s ± 0% -7.21% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10 334MB/s ± 0% 292MB/s ± 0% -12.67% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10 924MB/s ± 0% 920MB/s ± 0% -0.41% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10 740MB/s ± 0% 742MB/s ± 0% +0.27% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10 812MB/s ± 0% 792MB/s ± 0% -2.38% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10 647MB/s ± 0% 627MB/s ± 0% -3.16% (p=0.016 n=5+4)
wuffs_jpeg_decode_4002k_24bpp/gcc10 817MB/s ± 0% 792MB/s ± 0% -3.01% (p=0.016 n=4+5)
2023-07-23 12:03:07 +10:00
Nigel Tao
fed3da528c
pixconv: add pixel swizzler x86_sse42 prototypes
2023-07-22 13:23:37 +10:00
Nigel Tao
35c1f76f86
pixconv: add swizzle_ycc__convert_rgbx_x86_avx2
...
Some of the benchmark numbers move around even though they don't use the
new etc__convert_rgbx_x86_avx2 code paths. It's possibly just a code
alignment coincidence per https://news.ycombinator.com/item?id=23633583
name old speed new speed delta
wuffs_jpeg_decode_19k_8bpp/clang11 372MB/s ± 0% 370MB/s ± 0% -0.64% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11 278MB/s ± 0% 295MB/s ± 0% +5.89% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11 710MB/s ± 0% 726MB/s ± 0% +2.30% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11 603MB/s ± 0% 622MB/s ± 0% +3.12% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11 635MB/s ± 0% 659MB/s ± 0% +3.82% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11 650MB/s ± 0% 649MB/s ± 0% -0.17% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11 629MB/s ± 0% 675MB/s ± 0% +7.20% (p=0.008 n=5+5)
wuffs_jpeg_decode_19k_8bpp/gcc10 364MB/s ± 0% 351MB/s ± 0% -3.62% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10 334MB/s ± 0% 334MB/s ± 0% -0.06% (p=0.032 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10 944MB/s ± 0% 924MB/s ± 0% -2.19% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10 769MB/s ± 0% 740MB/s ± 0% -3.75% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10 842MB/s ± 0% 812MB/s ± 0% -3.60% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10 661MB/s ± 0% 647MB/s ± 0% -2.13% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10 849MB/s ± 0% 817MB/s ± 0% -3.77% (p=0.016 n=5+4)
2023-07-22 13:11:12 +10:00
Nigel Tao
4facef4e01
pixconv: add swizzle_ycc__convert_bgrx_x86_avx2
...
name old speed new speed delta
wuffs_jpeg_decode_19k_8bpp/clang11 365MB/s ± 1% 372MB/s ± 0% +1.77% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11 241MB/s ± 0% 278MB/s ± 0% +15.49% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11 477MB/s ± 0% 710MB/s ± 0% +48.91% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11 429MB/s ± 0% 603MB/s ± 0% +40.56% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11 446MB/s ± 0% 635MB/s ± 0% +42.18% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11 644MB/s ± 0% 650MB/s ± 0% +1.06% (p=0.016 n=4+5)
wuffs_jpeg_decode_4002k_24bpp/clang11 458MB/s ± 0% 629MB/s ± 0% +37.46% (p=0.008 n=5+5)
wuffs_jpeg_decode_19k_8bpp/gcc10 352MB/s ± 0% 364MB/s ± 0% +3.62% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10 295MB/s ± 0% 334MB/s ± 0% +13.19% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10 669MB/s ± 0% 944MB/s ± 0% +41.07% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10 567MB/s ± 0% 769MB/s ± 0% +35.59% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10 605MB/s ± 0% 842MB/s ± 0% +39.07% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10 647MB/s ± 0% 661MB/s ± 0% +2.19% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10 613MB/s ± 0% 849MB/s ± 0% +38.61% (p=0.008 n=5+5)
2023-07-22 12:51:51 +10:00
Nigel Tao
10d4ff7532
pixconv: factor out swizzle_ycc__convert_func
...
name old speed new speed delta
wuffs_jpeg_decode_19k_8bpp/clang11 368MB/s ± 0% 365MB/s ± 1% -0.75% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11 231MB/s ± 0% 241MB/s ± 0% +4.47% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11 470MB/s ± 0% 477MB/s ± 0% +1.35% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11 416MB/s ± 0% 429MB/s ± 0% +3.14% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11 433MB/s ± 0% 446MB/s ± 0% +3.02% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11 646MB/s ± 0% 644MB/s ± 0% -0.39% (p=0.016 n=5+4)
wuffs_jpeg_decode_4002k_24bpp/clang11 439MB/s ± 0% 458MB/s ± 0% +4.35% (p=0.008 n=5+5)
wuffs_jpeg_decode_19k_8bpp/gcc10 364MB/s ± 0% 352MB/s ± 0% -3.49% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10 294MB/s ± 0% 295MB/s ± 0% +0.38% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10 680MB/s ± 0% 669MB/s ± 0% -1.58% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10 578MB/s ± 0% 567MB/s ± 0% -1.92% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10 622MB/s ± 0% 605MB/s ± 0% -2.67% (p=0.016 n=4+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10 659MB/s ± 0% 647MB/s ± 0% -1.72% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10 630MB/s ± 0% 613MB/s ± 0% -2.74% (p=0.008 n=5+5)
2023-07-20 11:22:06 +10:00
Nigel Tao
6f510552be
cgen: add type casts for some avx2 methods
2023-07-18 13:26:39 +10:00
Nigel Tao
44d89c8838
base: add some more x86_m256i methods
2023-07-18 12:48:52 +10:00
Nigel Tao
ecaf25ebf0
std/jpeg: "AC all zero" fast path for x86_avx2
...
name old speed new speed delta
wuffs_jpeg_decode_19k_8bpp/clang11 370MB/s ± 0% 368MB/s ± 0% -0.47% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11 231MB/s ± 0% 231MB/s ± 0% -0.26% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11 470MB/s ± 0% 470MB/s ± 0% ~ (p=0.841 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11 418MB/s ± 0% 416MB/s ± 0% -0.42% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11 435MB/s ± 0% 433MB/s ± 0% -0.33% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11 620MB/s ± 0% 646MB/s ± 0% +4.20% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11 441MB/s ± 0% 439MB/s ± 0% -0.51% (p=0.008 n=5+5)
wuffs_jpeg_decode_19k_8bpp/gcc10 352MB/s ± 0% 364MB/s ± 0% +3.41% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10 296MB/s ± 0% 294MB/s ± 0% -0.69% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10 666MB/s ± 0% 680MB/s ± 0% +2.10% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10 565MB/s ± 0% 578MB/s ± 0% +2.34% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10 608MB/s ± 0% 622MB/s ± 0% +2.26% (p=0.016 n=5+4)
wuffs_jpeg_decode_552k_24bpp_444/gcc10 624MB/s ± 0% 659MB/s ± 0% +5.47% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10 616MB/s ± 0% 630MB/s ± 0% +2.29% (p=0.008 n=5+5)
2023-07-18 12:04:19 +10:00