Nigel Tao
8954281a4e
pixconv: allow decoding to PIXEL_FORMAT__RGB
...
"wuffs genlib" binary size changes:
77936 clang-static/wuffs-base-pixconv.o # Before = 1.00x
79792 clang-static/wuffs-base-pixconv.o # After = 1.02x
173784 gcc-static/wuffs-base-pixconv.o # Before = 1.00x
177112 gcc-static/wuffs-base-pixconv.o # After = 1.02x
Some of the benchmark numbers move around even though they don't use the
new WUFFS_BASE__PIXEL_FORMAT__RGB code paths. It's possibly just a code
alignment coincidence per https://news.ycombinator.com/item?id=23633583
name old speed new speed delta
wuffs_jpeg_decode_19k_8bpp/clang11 249MB/s ± 0% 251MB/s ± 0% +0.76% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11 222MB/s ± 0% 225MB/s ± 0% +1.16% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11 405MB/s ± 0% 406MB/s ± 0% ~ (p=1.000 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11 357MB/s ± 0% 356MB/s ± 0% -0.24% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11 370MB/s ± 0% 372MB/s ± 0% +0.46% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11 504MB/s ± 0% 508MB/s ± 0% +0.83% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11 375MB/s ± 0% 374MB/s ± 0% ~ (p=0.095 n=5+5)
wuffs_jpeg_decode_19k_8bpp/gcc10 258MB/s ± 0% 254MB/s ± 0% -1.68% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10 267MB/s ± 0% 240MB/s ± 0% -9.95% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10 537MB/s ± 0% 537MB/s ± 0% ~ (p=0.556 n=4+5)
wuffs_jpeg_decode_77k_24bpp/gcc10 458MB/s ± 0% 453MB/s ± 0% -1.18% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10 482MB/s ± 0% 478MB/s ± 0% -0.78% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10 508MB/s ± 0% 511MB/s ± 0% +0.49% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10 489MB/s ± 0% 484MB/s ± 0% -1.11% (p=0.016 n=4+5)
wuffs_png_decode_image_19k_8bpp/clang11 269MB/s ± 0% 275MB/s ± 0% +2.25% (p=0.008 n=5+5)
wuffs_png_decode_image_40k_24bpp/clang11 328MB/s ± 0% 328MB/s ± 0% ~ (p=0.841 n=5+5)
wuffs_png_decode_image_77k_8bpp/clang11 949MB/s ± 0% 962MB/s ± 0% +1.29% (p=0.008 n=5+5)
wuffs_png_decode_image_552k_32bpp_ignore_checksum/clang11 854MB/s ± 0% 859MB/s ± 0% +0.54% (p=0.008 n=5+5)
wuffs_png_decode_image_552k_32bpp_verify_checksum/clang11 822MB/s ± 0% 826MB/s ± 0% +0.52% (p=0.008 n=5+5)
wuffs_png_decode_image_4002k_24bpp/clang11 331MB/s ± 0% 332MB/s ± 0% +0.15% (p=0.008 n=5+5)
wuffs_png_decode_image_19k_8bpp/gcc10 287MB/s ± 0% 277MB/s ± 0% -3.46% (p=0.008 n=5+5)
wuffs_png_decode_image_40k_24bpp/gcc10 341MB/s ± 0% 346MB/s ± 0% +1.34% (p=0.008 n=5+5)
wuffs_png_decode_image_77k_8bpp/gcc10 1.02GB/s ± 0% 1.01GB/s ± 0% -0.41% (p=0.008 n=5+5)
wuffs_png_decode_image_552k_32bpp_ignore_checksum/gcc10 939MB/s ± 0% 916MB/s ± 0% -2.50% (p=0.008 n=5+5)
wuffs_png_decode_image_552k_32bpp_verify_checksum/gcc10 895MB/s ± 0% 874MB/s ± 0% -2.41% (p=0.008 n=5+5)
wuffs_png_decode_image_4002k_24bpp/gcc10 352MB/s ± 0% 350MB/s ± 0% -0.44% (p=0.008 n=5+5)
Updates #131
2023-07-16 11:17:45 +10:00
Nigel Tao
b97560b292
cgen: emit "do { etc } while (0);" for some loops
2023-06-28 22:58:07 +10:00
Nigel Tao
66ef485efa
cgen: emit "break/continue" not "goto", part 3
...
A selection of benchmarks below. Some are up, some are down.
name old speed new speed delta
wuffs_bzip2_decode_10k/clang11 59.5MB/s ± 0% 59.1MB/s ± 0% -0.72% (p=0.008 n=5+5)
wuffs_bzip2_decode_100k/clang11 49.6MB/s ± 1% 47.4MB/s ± 0% -4.48% (p=0.008 n=5+5)
wuffs_bzip2_decode_10k/gcc10 59.0MB/s ± 0% 59.8MB/s ± 0% +1.40% (p=0.008 n=5+5)
wuffs_bzip2_decode_100k/gcc10 49.8MB/s ± 2% 53.0MB/s ± 0% +6.51% (p=0.008 n=5+5)
wuffs_deflate_decode_1k_full_init/clang11 184MB/s ± 0% 182MB/s ± 0% -1.06% (p=0.008 n=5+5)
wuffs_deflate_decode_1k_part_init/clang11 213MB/s ± 0% 211MB/s ± 0% -0.65% (p=0.008 n=5+5)
wuffs_deflate_decode_10k_full_init/clang11 399MB/s ± 0% 409MB/s ± 0% +2.68% (p=0.008 n=5+5)
wuffs_deflate_decode_10k_part_init/clang11 409MB/s ± 0% 421MB/s ± 0% +2.96% (p=0.008 n=5+5)
wuffs_deflate_decode_100k_just_one_read/clang11 518MB/s ± 0% 517MB/s ± 0% ~ (p=0.095 n=5+5)
wuffs_deflate_decode_100k_many_big_reads/clang11 322MB/s ± 0% 319MB/s ± 0% -0.93% (p=0.008 n=5+5)
wuffs_deflate_decode_1k_full_init/gcc10 173MB/s ± 0% 175MB/s ± 0% +1.07% (p=0.008 n=5+5)
wuffs_deflate_decode_1k_part_init/gcc10 205MB/s ± 0% 208MB/s ± 0% +1.26% (p=0.008 n=5+5)
wuffs_deflate_decode_10k_full_init/gcc10 408MB/s ± 0% 396MB/s ± 0% -2.94% (p=0.008 n=5+5)
wuffs_deflate_decode_10k_part_init/gcc10 421MB/s ± 0% 408MB/s ± 0% -2.88% (p=0.008 n=5+5)
wuffs_deflate_decode_100k_just_one_read/gcc10 542MB/s ± 0% 519MB/s ± 0% -4.13% (p=0.008 n=5+5)
wuffs_deflate_decode_100k_many_big_reads/gcc10 340MB/s ± 0% 327MB/s ± 0% -3.77% (p=0.008 n=5+5)
wuffs_json_decode_1k/clang11 1.26GB/s ± 0% 1.34GB/s ± 0% +6.90% (p=0.008 n=5+5)
wuffs_json_decode_21k_formatted/clang11 681MB/s ± 0% 684MB/s ± 0% +0.47% (p=0.008 n=5+5)
wuffs_json_decode_26k_compact/clang11 1.00GB/s ± 0% 1.14GB/s ± 0% +14.26% (p=0.008 n=5+5)
wuffs_json_decode_217k_stringy/clang11 786MB/s ± 0% 907MB/s ± 0% +15.40% (p=0.008 n=5+5)
wuffs_json_decode_1k/gcc10 1.20GB/s ± 0% 1.22GB/s ± 0% +1.41% (p=0.008 n=5+5)
wuffs_json_decode_21k_formatted/gcc10 681MB/s ± 0% 719MB/s ± 0% +5.59% (p=0.008 n=5+5)
wuffs_json_decode_26k_compact/gcc10 957MB/s ± 0% 976MB/s ± 0% +1.94% (p=0.008 n=5+5)
wuffs_json_decode_217k_stringy/gcc10 773MB/s ± 0% 781MB/s ± 0% +1.01% (p=0.008 n=5+5)
wuffs_png_decode_image_19k_8bpp/clang11 256MB/s ± 0% 256MB/s ± 0% ~ (p=0.421 n=5+5)
wuffs_png_decode_image_40k_24bpp/clang11 311MB/s ± 0% 313MB/s ± 0% +0.57% (p=0.008 n=5+5)
wuffs_png_decode_image_77k_8bpp/clang11 907MB/s ± 0% 904MB/s ± 0% -0.28% (p=0.008 n=5+5)
wuffs_png_decode_image_552k_32bpp_ignore_checksum/clang11 821MB/s ± 0% 812MB/s ± 0% -1.08% (p=0.008 n=5+5)
wuffs_png_decode_image_552k_32bpp_verify_checksum/clang11 790MB/s ± 0% 782MB/s ± 0% -0.94% (p=0.008 n=5+5)
wuffs_png_decode_image_4002k_24bpp/clang11 315MB/s ± 0% 315MB/s ± 0% -0.09% (p=0.008 n=5+5)
wuffs_png_decode_image_19k_8bpp/gcc10 266MB/s ± 0% 273MB/s ± 0% +2.94% (p=0.008 n=5+5)
wuffs_png_decode_image_40k_24bpp/gcc10 329MB/s ± 0% 324MB/s ± 2% -1.65% (p=0.008 n=5+5)
wuffs_png_decode_image_77k_8bpp/gcc10 952MB/s ± 2% 967MB/s ± 0% +1.57% (p=0.016 n=5+4)
wuffs_png_decode_image_552k_32bpp_ignore_checksum/gcc10 871MB/s ± 0% 894MB/s ± 0% +2.59% (p=0.029 n=4+4)
wuffs_png_decode_image_552k_32bpp_verify_checksum/gcc10 831MB/s ± 0% 851MB/s ± 0% +2.45% (p=0.008 n=5+5)
wuffs_png_decode_image_4002k_24bpp/gcc10 336MB/s ± 0% 335MB/s ± 0% -0.53% (p=0.008 n=5+5)
2023-06-23 21:04:24 +10:00
Nigel Tao
de55ff7746
cgen: emit "break/continue" not "goto", part 2
...
name old speed new speed delta
wuffs_jpeg_decode_19k_8bpp/clang11 241MB/s ± 0% 241MB/s ± 0% ~ (p=0.690 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11 213MB/s ± 0% 213MB/s ± 0% ~ (p=0.690 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11 386MB/s ± 0% 387MB/s ± 0% ~ (p=0.270 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11 341MB/s ± 0% 341MB/s ± 0% ~ (p=0.556 n=5+4)
wuffs_jpeg_decode_552k_24bpp_420/clang11 356MB/s ± 0% 356MB/s ± 0% ~ (p=0.310 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11 484MB/s ± 0% 484MB/s ± 0% ~ (p=0.095 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11 362MB/s ± 0% 364MB/s ± 0% ~ (p=0.095 n=5+5)
wuffs_jpeg_decode_19k_8bpp/gcc10 245MB/s ± 0% 244MB/s ± 0% -0.19% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10 252MB/s ± 0% 254MB/s ± 0% +0.76% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10 513MB/s ± 0% 508MB/s ± 0% -0.88% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10 433MB/s ± 0% 434MB/s ± 0% +0.38% (p=0.016 n=4+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10 458MB/s ± 0% 456MB/s ± 0% -0.41% (p=0.029 n=4+4)
wuffs_jpeg_decode_552k_24bpp_444/gcc10 486MB/s ± 0% 481MB/s ± 0% -1.00% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10 465MB/s ± 0% 463MB/s ± 0% -0.39% (p=0.029 n=4+4)
2023-06-23 18:29:20 +10:00
Nigel Tao
f155db4d5c
cgen: emit "break/continue" not "goto", part 1
...
name old speed new speed delta
wuffs_jpeg_decode_19k_8bpp/clang11 229MB/s ± 0% 241MB/s ± 0% +5.29% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11 205MB/s ± 0% 213MB/s ± 0% +3.89% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11 375MB/s ± 0% 386MB/s ± 0% +3.01% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11 326MB/s ± 0% 341MB/s ± 0% +4.80% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11 339MB/s ± 0% 356MB/s ± 0% +5.14% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11 475MB/s ± 0% 484MB/s ± 0% +2.04% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11 343MB/s ± 0% 362MB/s ± 0% +5.77% (p=0.008 n=5+5)
wuffs_jpeg_decode_19k_8bpp/gcc10 245MB/s ± 0% 245MB/s ± 0% -0.07% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10 254MB/s ± 0% 252MB/s ± 0% -0.52% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10 514MB/s ± 0% 513MB/s ± 0% ~ (p=0.151 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10 434MB/s ± 0% 433MB/s ± 0% -0.35% (p=0.016 n=5+4)
wuffs_jpeg_decode_552k_24bpp_420/gcc10 459MB/s ± 0% 458MB/s ± 0% -0.12% (p=0.016 n=5+4)
wuffs_jpeg_decode_552k_24bpp_444/gcc10 486MB/s ± 0% 486MB/s ± 0% -0.03% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10 467MB/s ± 0% 465MB/s ± 0% -0.26% (p=0.016 n=5+4)
2023-06-23 17:46:40 +10:00
Nigel Tao
8916f1b6ea
lang: add if.likely and if.unlikely
2023-06-20 18:00:48 +10:00
Nigel Tao
e7df7cafac
cgen: add WUFFS_BASE__GENERATED_C_CODE macro
...
This disables UBSan's "unsigned-integer-overflow" runtime checks.
Updates https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=59966
2023-06-20 17:04:35 +10:00
Nigel Tao
44e745dd0e
std/jpeg: optimize EXTEND'ing MCU bits
...
name old speed new speed delta
wuffs_jpeg_decode_19k_8bpp/clang11 224MB/s ± 1% 223MB/s ± 0% ~ (p=0.190 n=4+5)
wuffs_jpeg_decode_30k_24bpp_progressive/clang11 206MB/s ± 0% 208MB/s ± 0% +0.86% (p=0.016 n=4+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11 374MB/s ± 0% 375MB/s ± 0% +0.26% (p=0.016 n=5+4)
wuffs_jpeg_decode_77k_24bpp/clang11 319MB/s ± 0% 319MB/s ± 0% +0.16% (p=0.029 n=4+4)
wuffs_jpeg_decode_552k_24bpp_420/clang11 329MB/s ± 0% 329MB/s ± 0% -0.06% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/clang11 465MB/s ± 0% 465MB/s ± 0% -0.12% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11 332MB/s ± 0% 331MB/s ± 0% -0.15% (p=0.008 n=5+5)
wuffs_jpeg_decode_19k_8bpp/gcc10 176MB/s ± 0% 208MB/s ± 0% +18.26% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10 246MB/s ± 0% 243MB/s ± 0% -1.03% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10 472MB/s ± 0% 479MB/s ± 0% +1.33% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10 334MB/s ± 0% 385MB/s ± 0% +15.33% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10 351MB/s ± 0% 407MB/s ± 0% +15.74% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10 425MB/s ± 0% 457MB/s ± 0% +7.38% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10 349MB/s ± 0% 411MB/s ± 0% +17.74% (p=0.008 n=5+5)
2023-06-18 17:37:23 +10:00
Nigel Tao
724aec33df
cgen: remove unnecessary parens for ptr-to-array
2023-06-13 22:39:21 +10:00
Nigel Tao
19f56ebfd2
lang: allow "slice_var as ptr array[etc] etc"
2023-06-13 22:38:25 +10:00
Nigel Tao
8ac22ceab2
cgen: allow "var x : nptr array[etc] etc"
2023-06-13 10:49:37 +10:00
Nigel Tao
04344db374
cgen: remove "// ¡ BEGIN set_color_u32_at"
2023-06-11 12:33:36 +10:00
Nigel Tao
7511bda9e5
cgen: refactor patch_pixconv's set_color_u32_at
2023-06-11 12:02:47 +10:00
Nigel Tao
43d9c604a2
cgen: unroll etc__swizzle_ycck for 444
...
name old speed new speed delta
wuffs_jpeg_decode_552k_24bpp_444/clang11 440MB/s ± 0% 459MB/s ± 0% +4.48% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10 393MB/s ± 0% 412MB/s ± 0% +4.82% (p=0.008 n=5+5)
2023-06-11 11:23:29 +10:00
Nigel Tao
41fb661626
cgen: make patch_pixconv etc__bgrx__hv11 explicit
2023-06-11 11:20:49 +10:00
Nigel Tao
1b0900ac73
cgen: re-organize patch_pixconv.go generated funcs
2023-06-11 10:47:29 +10:00
Nigel Tao
379000a711
cgen: optimize etc__swizzle_ycck for 420 bgrx/rgbx
...
name old speed new speed delta
wuffs_jpeg_decode_30k_24bpp_progressive/clang11 172MB/s ± 0% 200MB/s ± 0% +15.74% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/clang11 292MB/s ± 0% 362MB/s ± 0% +23.88% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/clang11 256MB/s ± 0% 307MB/s ± 0% +19.79% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/clang11 264MB/s ± 0% 318MB/s ± 0% +20.32% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/clang11 269MB/s ± 0% 320MB/s ± 0% +19.13% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10 202MB/s ± 0% 224MB/s ± 0% +11.01% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_sequential/gcc10 350MB/s ± 0% 454MB/s ± 0% +29.83% (p=0.008 n=5+5)
wuffs_jpeg_decode_77k_24bpp/gcc10 248MB/s ± 0% 311MB/s ± 0% +24.97% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_420/gcc10 261MB/s ± 0% 327MB/s ± 0% +25.49% (p=0.008 n=5+5)
wuffs_jpeg_decode_4002k_24bpp/gcc10 259MB/s ± 0% 324MB/s ± 0% +25.38% (p=0.008 n=5+5)
2023-06-09 19:21:28 +10:00
Nigel Tao
aec9003ea0
cgen: refactor patch_pixconv.go
2023-06-09 17:47:55 +10:00
Nigel Tao
311ea1a1f4
cgen: more optimize etc__swizzle_ycck for 444
...
name old speed new speed delta
wuffs_jpeg_decode_552k_24bpp_444/clang11 356MB/s ± 0% 443MB/s ± 0% +24.62% (p=0.016 n=4+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10 348MB/s ± 0% 380MB/s ± 0% +9.26% (p=0.008 n=5+5)
2023-06-09 17:15:31 +10:00
Nigel Tao
5d5d01a189
cgen: add "¡ INSERT patch_pixconv" mechanism
2023-06-08 23:26:37 +10:00
Nigel Tao
ca2909b6d7
cgen: optimize etc__swizzle_ycck for 444 bgrx/rgbx
...
name old speed new speed delta
wuffs_jpeg_decode_552k_24bpp_444/clang11 227MB/s ± 0% 275MB/s ± 0% +20.76% (p=0.008 n=5+5)
wuffs_jpeg_decode_552k_24bpp_444/gcc10 223MB/s ± 0% 249MB/s ± 0% +11.51% (p=0.008 n=5+5)
2023-06-07 22:25:02 +10:00
Nigel Tao
4a2f570d56
cgen: simplify bulk_etc method's generated code
2023-06-05 13:28:16 +10:00
Nigel Tao
2865c5bfbd
std/jpeg: call slice.bulk_{load,save}_host_endian
...
Updates https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=59540
name old speed new speed delta
wuffs_jpeg_decode_30k_24bpp_progressive/clang11 131MB/s ± 0% 168MB/s ± 0% +28.44% (p=0.008 n=5+5)
wuffs_jpeg_decode_30k_24bpp_progressive/gcc10 167MB/s ± 0% 175MB/s ± 0% +4.80% (p=0.008 n=5+5)
2023-06-05 12:51:50 +10:00
Nigel Tao
9c3ca6257d
cgen: generate 123u (instead of 123) even more
2023-06-04 22:09:19 +10:00
Nigel Tao
677a1c5b8e
cgen: builtin generates unsigned values more often
2023-06-04 22:01:54 +10:00
Nigel Tao
2f18dc61d0
std/jpeg: call slice.bulk_memset
2023-06-04 21:22:14 +10:00
Nigel Tao
50d765839c
cgen: generate 123u (instead of 123) more often
2023-06-01 19:58:50 +10:00
Nigel Tao
02a6a13236
cgen: drop redundant "& mask" in "(x & mask) as T"
2023-05-22 16:03:24 +10:00
Nigel Tao
7d73f3cfa4
pixconv: fix ycck implicit promotion to signed int
...
Updates https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=59182
2023-05-22 14:00:17 +10:00
Nigel Tao
a41149e73c
std/jpeg: implement triangle-filter upsampling
...
"script/confirm-matches-djpeg.sh test/data/*.jpeg" is now all matches.
2023-05-21 22:05:38 +10:00
Nigel Tao
94df43c530
std/jpeg: prepare for triangle-filter upsampling
2023-05-21 22:04:45 +10:00
Nigel Tao
5ab65d0923
cgen: generate 123u instead of 123 (for std/jpeg)
...
Updates https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=59018
2023-05-16 22:19:43 +10:00
Nigel Tao
85b244aa49
std/netpbm: add new package
2023-05-16 16:29:58 +10:00
Nigel Tao
7514dede23
std/jpeg: decode color images, not just gray
...
Updates #42
2023-05-14 23:03:33 +10:00
Nigel Tao
8cfe304f3c
std/jpeg: implement Inverse DCT
...
Updates #42
2023-05-08 21:51:47 +10:00
Nigel Tao
0bbc4c0083
std/jpeg: add new package
...
This is just a placeholder decoder implementation (and all of the
required plumbing) that produces a 1x1 reddish-purple image. Follow-up
commits will add flesh to the metaphorical bones.
Updates #42
2023-04-21 18:33:00 +10:00
Nigel Tao
4834cb97c8
base: deprecate ETC__PIXEL_FORMAT__NUM_PLANES_MAX
2023-04-16 11:12:06 +10:00
Nigel Tao
e126c998e0
std: limit supported image dimensions to 0xFF_FFFF
2023-04-16 08:57:55 +10:00
Nigel Tao
6e84987d33
std: change set_quirk_enabled to set_quirk
2023-04-14 21:42:15 +10:00
Nigel Tao
f3caf09d77
lang: add read-only type decorators
2023-04-10 15:29:12 +10:00
Nigel Tao
6e8349129c
base: remove deprecated names
2023-04-09 16:12:49 +10:00
Nigel Tao
00d5e35865
floatconv: optimize parse_number_f64 fallback
...
The time taken running script/manual-test-parse-number-f64.cc on the
parse-number-fxx-test-data suite falls from 3.565s to 2.491s (a 1.43x
ratio; the inverse is 0.70 = 100% - 30%).
Fixes #113
2023-04-08 14:56:32 +10:00
Nigel Tao
4d4c3c4c3c
floatconv: tweak Simple Decimal Conversion
...
This tweaks the code and comments added in commit 36d7748e "Merge pull
request #90 from sarastro-nl/improvement/optimize-SDC" and commit
d46220ca "optimize SDC". Both of those two commit messages are short but
see the discussion re algorithmic changes on PR 87 (yes, 87, not 90):
https://github.com/google/wuffs/pull/87
Also run clang-format.
Also update doc/changelog.md
Compared to before commit d46220ca "optimize SDC", when running
script/manual-test-parse-number-f64.cc and disabling both the
etc__parse_number_f64_eisel_lemire function and the "If both man and
(10 ** exp10) are exactly representable by a double" fast path, the
tests still pass but the number of etc__high_prec_dec__small_lshift and
etc__high_prec_dec__small_rshift calls drop:
Function Before After Ratio
lshift 31174584 25762258 82.64% = 100% - 17.36%
rshift 21592604 20982502 97.17% = 100% - 2.83%
The time taken drops from 15.984s to 13.710s (85.77% = 100% - 14.23%).
To repeat, these are the improvements after disabling the Eisel-Lemire
and other fast paths. Simple Decimal Conversion is the rarely invoked
fallback parse_number_f64 algorithm. The practical improvement (with
Eisel-Lemire etc enabled) is smaller.
2023-02-04 14:48:25 +11:00
Nigel Tao
36d7748ed5
Merge pull request #90 from sarastro-nl/improvement/optimize-SDC
...
optimize SDC
2023-02-04 10:30:29 +11:00
Nigel Tao
3705e0d93a
cgen: io_reader.is_closed doesn't need derived var
2023-01-31 23:33:02 +11:00
Nigel Tao
d7c48ae76b
cgen: have io_limit update meta.closed
2023-01-31 22:05:20 +11:00
sarastro-nl
d46220ca00
optimize SDC
2022-11-21 22:10:19 +01:00
Nigel Tao
9445c8b9d0
Guard header declarations on the MODULE_ETC macros
2022-10-28 17:11:14 +11:00
Nigel Tao
b0e9efff3f
Avoid (NULL + 0) in derived io_buffer variables
...
This addresses a "runtime error: applying zero offset to null pointer"
UBSAN (Undefined Behavior Sanitizer) warning using clang 15.0.1:
https://logs.chromium.org/logs/skia/5e005cc1b1981011/+/steps/dm/0/stdout
The offending line of code was "io1_a_dst = io0_a_dst + a_dst->meta.wi"
in wuffs_lzw__decoder__write_to and "io1_a_dst = NULL + 0" was Undefined
Behavior even though io1_a_dst was never dereferenced.
This commit avoids initializing io1_a_dst to (NULL + 0) when io0_a_dst
is NULL, falling back to initializing it with just NULL.
As discussed in https://reviews.llvm.org/D67122 while (nullptr + 0) is
Defined Behavior according to the C++ spec, (NULL + 0) is Undefined
Behavior (by omission) in C11 6.5.6/8: "If both the pointer operand and
the result point to elements of the same array object, or one past the
last element of the array object, the evaluation shall not produce an
overflow; otherwise, the behavior is undefined."
The benchmarks (an excerpt of the full suite is below) seem quite
sensitive to this simple change that's outside of hot loops, sometimes
much better and sometimes much worse. I don't know why.
name old speed new speed delta
wuffs_bzip2_decode_10k/clang11 63.1MB/s ± 0% 58.4MB/s ± 0% -7.43% (p=0.008 n=5+5)
wuffs_bzip2_decode_100k/clang11 49.4MB/s ± 0% 46.2MB/s ± 0% -6.35% (p=0.008 n=5+5)
wuffs_bzip2_decode_10k/gcc10 60.9MB/s ± 0% 56.3MB/s ± 0% -7.59% (p=0.016 n=5+4)
wuffs_bzip2_decode_100k/gcc10 49.6MB/s ± 0% 47.0MB/s ± 0% -5.15% (p=0.008 n=5+5)
wuffs_deflate_decode_1k_full_init/clang11 196MB/s ± 0% 195MB/s ± 1% -0.63% (p=0.008 n=5+5)
wuffs_deflate_decode_1k_part_init/clang11 226MB/s ± 0% 224MB/s ± 0% -0.95% (p=0.008 n=5+5)
wuffs_deflate_decode_10k_full_init/clang11 409MB/s ± 0% 420MB/s ± 0% +2.84% (p=0.008 n=5+5)
wuffs_deflate_decode_10k_part_init/clang11 418MB/s ± 0% 431MB/s ± 0% +2.97% (p=0.008 n=5+5)
wuffs_deflate_decode_100k_just_one_read/clang11 517MB/s ± 1% 542MB/s ± 0% +4.78% (p=0.008 n=5+5)
wuffs_deflate_decode_100k_many_big_reads/clang11 330MB/s ± 0% 338MB/s ± 0% +2.45% (p=0.008 n=5+5)
wuffs_deflate_decode_1k_full_init/gcc10 188MB/s ± 0% 177MB/s ± 0% -5.38% (p=0.008 n=5+5)
wuffs_deflate_decode_1k_part_init/gcc10 218MB/s ± 0% 209MB/s ± 0% -4.11% (p=0.016 n=4+5)
wuffs_deflate_decode_10k_full_init/gcc10 402MB/s ± 0% 407MB/s ± 1% +1.19% (p=0.008 n=5+5)
wuffs_deflate_decode_10k_part_init/gcc10 413MB/s ± 0% 419MB/s ± 1% +1.64% (p=0.008 n=5+5)
wuffs_deflate_decode_100k_just_one_read/gcc10 520MB/s ± 0% 532MB/s ± 0% +2.25% (p=0.008 n=5+5)
wuffs_deflate_decode_100k_many_big_reads/gcc10 330MB/s ± 0% 335MB/s ± 0% +1.56% (p=0.008 n=5+5)
wuffs_gif_decode_1k_bw/clang11 781MB/s ± 0% 645MB/s ± 0% -17.46% (p=0.008 n=5+5)
wuffs_gif_decode_1k_color_full_init/clang11 176MB/s ± 0% 181MB/s ± 0% +3.11% (p=0.008 n=5+5)
wuffs_gif_decode_1k_color_part_init/clang11 215MB/s ± 0% 223MB/s ± 0% +3.46% (p=0.008 n=5+5)
wuffs_gif_decode_10k_bgra/clang11 786MB/s ± 0% 801MB/s ± 0% +1.94% (p=0.008 n=5+5)
wuffs_gif_decode_10k_indexed/clang11 208MB/s ± 0% 211MB/s ± 0% +1.44% (p=0.008 n=5+5)
wuffs_gif_decode_20k/clang11 261MB/s ± 0% 252MB/s ± 0% -3.43% (p=0.008 n=5+5)
wuffs_gif_decode_100k_artificial/clang11 578MB/s ± 0% 583MB/s ± 0% +0.86% (p=0.008 n=5+5)
wuffs_gif_decode_100k_realistic/clang11 224MB/s ± 0% 223MB/s ± 0% -0.79% (p=0.008 n=5+5)
wuffs_gif_decode_1000k_full_init/clang11 229MB/s ± 0% 225MB/s ± 0% -1.73% (p=0.008 n=5+5)
wuffs_gif_decode_1000k_part_init/clang11 229MB/s ± 0% 225MB/s ± 0% -1.69% (p=0.008 n=5+5)
wuffs_gif_decode_anim_screencap/clang11 1.31GB/s ± 0% 1.29GB/s ± 0% -1.06% (p=0.008 n=5+5)
wuffs_gif_decode_1k_bw/gcc10 650MB/s ± 0% 631MB/s ± 0% -3.03% (p=0.008 n=5+5)
wuffs_gif_decode_1k_color_full_init/gcc10 169MB/s ± 0% 168MB/s ± 0% -0.51% (p=0.008 n=5+5)
wuffs_gif_decode_1k_color_part_init/gcc10 202MB/s ± 0% 202MB/s ± 0% -0.18% (p=0.008 n=5+5)
wuffs_gif_decode_10k_bgra/gcc10 766MB/s ± 0% 790MB/s ± 0% +3.08% (p=0.008 n=5+5)
wuffs_gif_decode_10k_indexed/gcc10 202MB/s ± 0% 208MB/s ± 0% +3.16% (p=0.008 n=5+5)
wuffs_gif_decode_20k/gcc10 250MB/s ± 0% 258MB/s ± 0% +3.20% (p=0.008 n=5+5)
wuffs_gif_decode_100k_artificial/gcc10 563MB/s ± 0% 566MB/s ± 0% +0.57% (p=0.008 n=5+5)
wuffs_gif_decode_100k_realistic/gcc10 217MB/s ± 0% 220MB/s ± 0% +1.49% (p=0.008 n=5+5)
wuffs_gif_decode_1000k_full_init/gcc10 220MB/s ± 0% 224MB/s ± 0% +1.49% (p=0.008 n=5+5)
wuffs_gif_decode_1000k_part_init/gcc10 220MB/s ± 0% 224MB/s ± 0% +1.43% (p=0.008 n=5+5)
wuffs_gif_decode_anim_screencap/gcc10 1.30GB/s ± 0% 1.30GB/s ± 0% +0.34% (p=0.008 n=5+5)
wuffs_lzw_decode_20k/clang11 293MB/s ± 0% 292MB/s ± 0% -0.41% (p=0.008 n=5+5)
wuffs_lzw_decode_100k/clang11 486MB/s ± 0% 537MB/s ± 0% +10.49% (p=0.008 n=5+5)
wuffs_lzw_decode_20k/gcc10 258MB/s ± 0% 276MB/s ± 0% +7.19% (p=0.016 n=4+5)
wuffs_lzw_decode_100k/gcc10 512MB/s ± 0% 527MB/s ± 0% +3.08% (p=0.016 n=4+5)
2022-10-20 11:18:09 +11:00
Nigel Tao
c226ed60f5
Use memcpy-based peeks and pokes on Microsoft C
...
I don't have a Windows machine readily available, but according to
https://godbolt.org/z/q4MfjzTPh and the https://imgur.com/UD5a7MF
profile mentioned in #72 , this could improve inner loop performance.
Updates #72
2022-06-12 17:18:49 +10:00